Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp396684rwd; Tue, 30 May 2023 23:06:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6kuaea5Phvx+9fgFaEkVtYn3FPYw3kcjfBSHoPV4UG/7xaWh/45udiMcqpnZYr9xXA4YTG X-Received: by 2002:a05:6870:9186:b0:19e:bde7:f0cc with SMTP id b6-20020a056870918600b0019ebde7f0ccmr3338172oaf.34.1685513188761; Tue, 30 May 2023 23:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685513188; cv=none; d=google.com; s=arc-20160816; b=ff5DpaTlwAvhidUjq3MZL03O1F/JuEaQRImKZVD2eORQd+XiuimTDg0EUf8NhKIgPF jzUYp9bR3jW5pwZfn1xHspEe8gIdnUAUIhDImvIlZdjuKp+L3urtPHACXeHBeuPShNv7 TKX85Iurr30r0Ju5ceNeJ5KLSvdg149RdeKmlLkImeU684Gu2D4je+vMyoIjCWArxXkZ wTwOnCVWWB1SLhomvERzHNAusOmEAAa0CqhDqbsofMKAQpyjHMfV2GglWzWDYZQcGZkc UqwohEo8Plo0PIoqJa8tNf/asfe77pkLsF/79gK5pTwM1C+F5YCLNGRsPm9T1TCAz2Qs BgaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=no3TEKUkmUVHzCsaYmjTpfXV5aF4dx90uX+omBYUYF0=; b=LFpQkN7H8H0PhXJgiXo5qRpu3twH1/2HcgMDdfn9cfhQXyb13fB0J1M51evetnaoT5 CtHbCBKJq1Lcx9T/TxKNJKl9mI4Iad3Zg0RcnAZr0Omeugum5E5X1Cmhl+oi/WpbQ+aV 0XHApA3GACz4Oa6R7ENrcNiqtwKKzylfq57yMnE6ZO62fRNQnY/0jgWEZIJDXF9R2QMg jfn9apu/QybdDAyCIaiyafVYMTM7eGoMbV9NBkFib5v2LWwIFTfg6zVzbpZSzXsuLso/ v0UNYBTwFD40v2/QxU9BDg6DKOWq1WrPRdJPSba5cHdT3TRQd8sCHfJ/5W9Td+DH3IEF woAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2DDNQ3l7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a129-20020a624d87000000b00643ae7da34bsi3044289pfb.221.2023.05.30.23.06.16; Tue, 30 May 2023 23:06:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2DDNQ3l7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234294AbjEaGBn (ORCPT + 99 others); Wed, 31 May 2023 02:01:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjEaGBm (ORCPT ); Wed, 31 May 2023 02:01:42 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2A60122; Tue, 30 May 2023 23:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=no3TEKUkmUVHzCsaYmjTpfXV5aF4dx90uX+omBYUYF0=; b=2DDNQ3l79qF9AhCeffpq9LM+wL fdS0aLm8eJ9zcYqtUEHnxAcURykn/5yZqBrSWnCBBalC91f1jgU8W3+RjRpsHfRbP6AfZqnbvvUQl GZcuibr56JdORnHZ7ysNbtaSDLkJeqxxACu1HvGMCGjc6LiSUG5TJ6jD8W+4umfRQw+StNSrWbY7w RZ0gSWg/kbuQDgoJE5msEk3bQoZHhwjGy0wYJkMvw/LznVRg/CngjjnnFzv0Zxfnrd7HEVH7CeHf1 PTomZycSMUMtO0dSvFg7c4rddEIZak8fvfKbzxEmEzNkmXUwMrZX0dpsWXnLJQUjTsfZCYBIvUDEo kt5uhIUw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4Etd-00GEid-2F; Wed, 31 May 2023 06:01:21 +0000 Date: Tue, 30 May 2023 23:01:21 -0700 From: Luis Chamberlain To: Maninder Singh Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, song@kernel.org, yhs@fb.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, thunder.leizhen@huawei.com, boqun.feng@gmail.com, vincenzopalazzodev@gmail.com, ojeda@kernel.org, jgross@suse.com, brauner@kernel.org, michael.christie@oracle.com, samitolvanen@google.com, glider@google.com, peterz@infradead.org, keescook@chromium.org, stephen.s.brennan@oracle.com, alan.maguire@oracle.com, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Onkarnath Subject: Re: [PATCH 1/1] kallsyms: add kallsyms_show_value defination in all cases Message-ID: References: <20230531042600.819453-1-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531042600.819453-1-maninder1.s@samsung.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 09:56:00AM +0530, Maninder Singh wrote: > so bpf_dump_raw_ok check is not changed. Since you're adding a new file and making no changes to tons of code but also making somew new changes I can't tell easily what is new or not. Although I can see we're now adding a false case for bpf_dump_raw_ok() it would be best if just split this int wo separate patches. One non-functional, and a second wwone which extends the code. Luis