Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp399837rwd; Tue, 30 May 2023 23:09:49 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6mRR8oTG4A1Cry7ThGdz2KXVyerb0RIp96jGSzcDpeoQDin/qKKuLj2RJKJ+nVSwEoTMQQ X-Received: by 2002:a17:90b:3885:b0:256:7000:3789 with SMTP id mu5-20020a17090b388500b0025670003789mr4794164pjb.9.1685513388699; Tue, 30 May 2023 23:09:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685513388; cv=none; d=google.com; s=arc-20160816; b=XVDkLJnv6gdntDg1f8h9YItV0rr+OUIlZXHITxPbHWuj21v2Gt+27MjiOiPELufFd+ xLUxErVSTqn3I9rkyElVgBeNdEVxP1bRe2FIJ0qXFhSz1UMp41Y1WIun4d8El4M4GK1I Ogg5U71F5610gvk2WR6gVfcI7VFzmfdAvz9vtEv9qXoB5VDzD/fSusOP3Z0KT/kE8tCq EjUx6XKuP2T4L0BGAuju5toIJHlYqmfo/thxXdxc7Pj7eovU5UN1hDXIGL4PyvKFDlIi A02g5nV8bTqzuePyugpC8ei6RsbWqZEbllwUJS7JHT1+DTbmKctu/+jWkhjW24tOh3+C Zl4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=r+uCSX0FlAx5seguD2P6anTVmMxo76ufibjreIZ+WQU=; b=ceokMwrLUlnisWbUD9g4CUecmFrPRb+pLRW9y43V1LQG3ky8+MN57/zFDS8RhJFzdJ anhOmrh746Swbh/QsurzArV+XFTIOKWwnDiiQ9uW/iAbbvRxq3KO0+hN5m14xSJjZktH krbPXebIUb/i6ATQ5CDAKUecZcBEMLSxVUlgCVxd4YxSn6K6gJ8YWDYjH9ao8rbEyh6R t5ITSU7PGbVJTCAXmQt/kCNOi7ms8yJlO1EpkjTvia6hEcht7ZAh5VWbWh5yNIiOkixr sW1YuVAt9DvuPg2p492oZfBAwxLNjkq61q2ceU0uMEd513+JF3xcWq06DaFvibMe6+t3 I6QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bmu7G3tm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cq19-20020a17090af99300b0023b481b8dcesi417803pjb.102.2023.05.30.23.09.36; Tue, 30 May 2023 23:09:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Bmu7G3tm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234357AbjEaGHe (ORCPT + 99 others); Wed, 31 May 2023 02:07:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234350AbjEaGH3 (ORCPT ); Wed, 31 May 2023 02:07:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4A9129; Tue, 30 May 2023 23:07:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B3B6363577; Wed, 31 May 2023 06:07:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 226BFC433EF; Wed, 31 May 2023 06:07:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685513243; bh=r+uCSX0FlAx5seguD2P6anTVmMxo76ufibjreIZ+WQU=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=Bmu7G3tmFFXzXdxYA+SEq2xr3JUeRgpBE4xGQAqT05BGZMC1lqTcx+w05b26ymEv8 QzUJtBOevoCnK0q5g2WeIN/7lnRW9zl/Hl5WpVb5BjcEV4F398JWmipu2oPMmp3U7k 09t6/bqRljcE+q2WZEYkiTSsBBbmmEQn9HcDMdBhvX5sFIc+kbk+daB9WPyo2X/w/0 5hbkCOhN7jg8+FzeF0GoJqF0Tfpi+sLyDNnvffVJp2KIV1/pt08/i5GHKh07QHK0sR bqKu3pp+YthKQvUg3t2XMiFLc/7mbgxrMRyYgkd21pswvSsYrVtwdVD3YA/jF2gmxz XSzkfjfjpRpXw== Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-55825988b7bso870529eaf.1; Tue, 30 May 2023 23:07:23 -0700 (PDT) X-Gm-Message-State: AC+VfDwzPzyn9ozlKJOwx5NztgAS/lnJs90sFHWpBId/Wg44JF5iEYyV dUfJU/acIUTc7GiqU5o+Si5TLJU71hJ4YE7UDhg= X-Received: by 2002:a05:6808:1383:b0:39a:4ac8:34ae with SMTP id c3-20020a056808138300b0039a4ac834aemr1139847oiw.12.1685513242300; Tue, 30 May 2023 23:07:22 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a8a:acd:0:b0:4de:afc5:4d13 with HTTP; Tue, 30 May 2023 23:07:21 -0700 (PDT) In-Reply-To: <20230531021043.39728-1-luhongfei@vivo.com> References: <20230531021043.39728-1-luhongfei@vivo.com> From: Namjae Jeon Date: Wed, 31 May 2023 15:07:21 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] smb: Change the return value of ksmbd_vfs_query_maximal_access to void To: Lu Hongfei Cc: Steve French , Sergey Senozhatsky , Tom Talpey , "open list:KERNEL SMB3 SERVER (KSMBD)" , open list , opensource.kernel@vivo.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-05-31 11:10 GMT+09:00, Lu Hongfei : > The return value of ksmbd_vfs_query_maximal_access is meaningless, > it is better to modify it to void. > > Signed-off-by: Lu Hongfei Acked-by: Namjae Jeon Thanks for your patch!