Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c920ff12-8674-0847-3486-35e63fdb546c@meta.com>
Date:   Tue, 30 May 2023 23:08:38 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.11.2
Subject: Re: [PATCH] bpf/tests: Use struct_size()
Content-Language: en-US
To:     Su Hui <suhui@nfschina.com>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20230531043251.989312-1-suhui@nfschina.com>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <20230531043251.989312-1-suhui@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnZ2MEVFdFMyN2QzUVk0VHhlZUl6djBqRG5CYVB0dkY1a1Jvd1hrVm5vQTJq?=
 =?utf-8?B?a25NQzUyTUoydk1wL2tLbEVLSEtxQi83NFk3VDZhcnNkRFRIZFR3dDM3cC8z?=
 =?utf-8?B?UkMrTlJDZ241NXBZVTc0RU5qQy9aNkpyOGdzNE9IcXNiOFh5VUxsQmFHZ0Jp?=
 =?utf-8?B?cTZBYmo4R3lwMFlmSktGQllNTUVRS0dNOUhGanA3cFNPS1RQQ1NURFcxY2hQ?=
 =?utf-8?B?Nk5lZm8wK2lxUEpZWklGMmFYVWpCUVl5ZjhKd21iMGZtV2NiRDVFQWYyOFUx?=
 =?utf-8?B?MkVQRllFYkhOL1lkWlRDR1VsdHNJNkFlNWNXUk83ZjBzV1hhcFdXT2VxZmlL?=
 =?utf-8?B?NTNBRU5QVWw1ZDMxQnJKTWhtM2lFYmNqNnhUYTNCTjJ3dnYxZmRFR1NPZDNx?=
 =?utf-8?B?d0pTOE16QUZlVnlOUEEzbStBNU1BSjVTQWFySG1ZTFNYcVlBTEIxdVVZS3VF?=
 =?utf-8?B?RFZpaXlCWG45Z3BKVjZlc0hlZW9WZWpxT012UFdYZ01HYXI5NWVxZ0RSdUww?=
 =?utf-8?B?Q0JWb3AwN2wwemZoNk5TRHF0VE0waDZMcWZzTDhzVXVESHN5RHpRVzh1TnRY?=
 =?utf-8?B?cS85VllPTVQ4UWs5dlJOOHkvb1VSOGQ5UUMrQ2s5UG93R05hdHZHbUszVGVw?=
 =?utf-8?B?cjZwUGkwaFQwRVhyNUZtaHBFaFppVXA2SzM5eTdHc2lLdCtLTlV0Q25oZ1FN?=
 =?utf-8?B?dnIxSDhxTVk1UnJWNHA3czkrL0RjVnBSU2laa1pVSW1zWVNva2RDU2R1Wk93?=
 =?utf-8?B?R0xJYnJGNzBYMmJrRjF2U2I4Z0V4L2pKRVErOWsrTXZqZlV4d1I3cDUvTFdr?=
 =?utf-8?B?aEt2U2o5bktEWmtjVHRSRzFQUzJQdTlvZ0RsTTRxeSt4ZG1QdnBTTnVuOWgy?=
 =?utf-8?B?alRzUGw2ejNhSUVOWjVjWU9WQjBLRm5qR0NTaEpaV0pWWmkvNHhxZFRHUU5M?=
 =?utf-8?B?WDBpaGlDN0ZzUXRIWFdKeW5JTHpVQjZiODlIS25WOGFka0RtdWZyUFRNa3VY?=
 =?utf-8?B?M1VMdTRVd0tKald4UWNZM3JlMURNZ1pLbWd5Rm1VUWZXc04wR1M4eXZ5dUZX?=
 =?utf-8?B?VlFCNk56YlNhNnErUU5hZ0hSTmVudkUyNGpnc2J5eDZnclorejR5cjJTRWw0?=
 =?utf-8?B?VEtxNWkvSmthaTdOay9lTVpGQzNxR2hxV2cxNmhoZHdmR0x6cXNYSUNITjJo?=
 =?utf-8?B?bmU5WWhsdjVFQllyVzlFRjNBcWpTa0FFOW9GZ2JqNkdpU1dsUWxFUlNyODc0?=
 =?utf-8?B?Tkt5WGJlRDk0eTcvZWxQZUt0NXQzN0FZdnJtMVVkN1ZTQkJBSTFjSi9haWJG?=
 =?utf-8?B?Yk1zZGgrUFMwVTM5UUdyVk5kQWV1aXpmVTduMElRSmhHM2t6TkZXbDZHaEVk?=
 =?utf-8?B?dVFic3dXeGczc0dCckNoR3ZRR3pQQ0U2ZDVtcmYzQVUySzdxWElTU3VYUG56?=
 =?utf-8?B?Smx3QmN2WG5OY1UyMHVlcy8xOGdxRWVsckdKVGVmVmtnOWZiYUpzcVlzVHhD?=
 =?utf-8?B?c0ZEeW5HMmlCZHZkc3A5am4xSXUwQzcvS0dRbFZVNEJzTU9PRHdRSEx6WUhr?=
 =?utf-8?B?OWVnZ014Z2hlcUNnRkhxL2pFLzRRNDZ5c3pxNmhBZ2xBRzhtcUk5ZHdtZzR5?=
 =?utf-8?B?bnR1clRyQXNoY21nQ3VUOGVmaTdWelA5K20wbFZwTGdraFB4U1h1ZmdxbSt6?=
 =?utf-8?B?ajZMelJYUWFDYmpIRlM0MnBNbS9lR3B5dmR5R0c4Y00xVG85NTRVdGtXTlZw?=
 =?utf-8?B?UDV3Ri9KZWNPRzZLOU5CelNMc0lEekVwNjNaeXNLdnVQOG11dndTd0NxaGpx?=
 =?utf-8?B?c3pFMDZveWVtaElLWVB1NkZPMDVEQXRGc0dKKzZhMHAxdUVPUkFIOWlrbElZ?=
 =?utf-8?B?ZURVb3dBZWpFMWo5QmwvdlBwbHdtNDRZYmhUeFZIMExOQnplOTdraHY5STha?=
 =?utf-8?B?ekc1TjlBRWNHT3BaTFpyWTQ4VmwwU3BQRThWUC9pUHc4TEt2cDljTGUwWHZn?=
 =?utf-8?B?bzhoWEFPQUhsblByUjRRRVFVNkhUdjIvUU41cEtxYzhMMFYzK1Q2RWhHYWZY?=
 =?utf-8?B?OVQ4OFdQS2plTmlreWNCK2VNWFpiOS82TjJUazVBL3lVejU0UG8vMEg0YTJu?=
 =?utf-8?B?Zk1rK2dsQTdvM0Y1R3F0ek9henJWOVNZYXFtNk5DVFN3djRVSkhtMURZNG9F?=
 =?utf-8?B?L1E9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 53530790-0f43-4eb4-fb47-08db619d7c50
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 06:08:42.8070
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LRUDfOTBzynOYPIFlE0AulHqPY91nJdZrUhHJkmaMvqLI7MAl4SIIJfzET5uOB/f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR15MB6213
X-Proofpoint-ORIG-GUID: vkREIp9Onc81-7MAXgA7NiNkmuzuCb9d
X-Proofpoint-GUID: vkREIp9Onc81-7MAXgA7NiNkmuzuCb9d
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-31_02,2023-05-30_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/23 9:32 PM, Su Hui wrote:
> Use struct_size() instead of hand writing it.
> This is less verbose and more informative.
> 
> Signed-off-by: Su Hui <suhui@nfschina.com>

Acked-by: Yonghong Song <yhs@fb.com>