Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp429289rwd; Tue, 30 May 2023 23:45:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4OJJRPrly/9XPsYlVrIGui09xBEd4O51yvGTQbrXiW55i2khw8jsBf8+F3hBVjihUZ1uzJ X-Received: by 2002:a92:c68c:0:b0:32f:80a1:2e44 with SMTP id o12-20020a92c68c000000b0032f80a12e44mr1719674ilg.9.1685515517393; Tue, 30 May 2023 23:45:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685515517; cv=none; d=google.com; s=arc-20160816; b=e7RJsO+btre44QaT1Uot9sF1SXkYJt0WPAQLYs41oRK5JvULknAKl71iPG/LGLtfxW nVGAA8w1EeW5slsjl1R4NENpf9YGYAgIR5TTZtcFrEgaGUe9r+u0QFLIHgBPE+a7Bg0Z xqhut1IHGa0gcWej8Y2Hnscj3cE+BkIvxm/ZGyCH+zyYWMGb4qY88mou62BtU/bb16t3 sJybaUkPWi5b6dpMkEej9vv2gHFeod02Hdm9mcJK6BNy3vVbXwm/ifzKb0nbKCZa1kSM HlX+C7SoWsZXuNedgy5mkNX9RrgLnd1twZuseGBjnyhIXLv6AtAEyv+lJzqECEyWqqb1 paMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GKSE3WKcFP+0y2+KYQZrdUMJBuNXttwzMhijqi8gHec=; b=ViLx7XjHRPi0Rdaf45TICF3zoMxE+v6lQkEATZ1CxxxE1CRHQsB0TCZ68SwJ2ZxwDU eJBETfMPtaLjGUFVpXFseyW6shtLHMJqEyhtb2b8bj+EhnH/bz+7Tp9K1Y0XewDCCkNg oLnlHSniI3FMSh+CL2fRyp6Vcg95UfcjTSIkr67Brn4p+Q+pJECnrNnuBICGjUutgqzY BjexEeA7bjsXmZYv7jDp5AUyoDBcunp/yiE5F0N5rpek+cL0TDVokf7Vy3Q9n1wN0mAQ JA4KWYk88bQL/CPkmbwXDSnfKmWULlLBeMM4sE/tKkLqNOFEJRpRCJgc0eMiaWNGK+IH xv6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QijCDzcR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w7-20020a170902e88700b001a979e702b2si381343plg.416.2023.05.30.23.45.00; Tue, 30 May 2023 23:45:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QijCDzcR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234094AbjEaGep (ORCPT + 99 others); Wed, 31 May 2023 02:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbjEaGem (ORCPT ); Wed, 31 May 2023 02:34:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82F7E99; Tue, 30 May 2023 23:34:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14A2363709; Wed, 31 May 2023 06:34:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47F03C4339B; Wed, 31 May 2023 06:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685514880; bh=VbJXJ5zz+WVpnyRQMyry3uFyArPowS0EQwKqrDggAFo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QijCDzcRmZbR2iHcYZtpEYpw6bAFdDHejD9UBEfPcsfUQaOT2Tt/9k/VxjOQbGdxA QDJOoV3DxLF8Vt54AzGdX21lutd/xZParafTh73vV+oSfsHSBfYegP2u43MtzMdh7T oecQFkldm7MpwUtQXBxIVMqWCTm8H6aKcfEFofaRrDbR/1Uw4TtdcONaphzmDXRyWo RppPS1Z2PYrZsAbT/p225lgG8fwFiDplK5sUt3//lMWdXQ8SE4/4sM7D9Jp+t8x4OO 15wDxV6BJaKVjOV9VqVi/DHRoXdI0/deofPd9pw5Icn/svT+DQpujic4PwX6f/MJ3z olvSJGHdp3NRw== Date: Tue, 30 May 2023 23:34:38 -0700 From: Jakub Kicinski To: Matti Vaittinen Cc: Matti Vaittinen , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v7 0/9] fix fwnode_irq_get[_byname()] returnvalue Message-ID: <20230530233438.572db3fb@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 May 2023 09:22:15 +0300 Matti Vaittinen wrote: > The fwnode_irq_get() and the fwnode_irq_get_byname() may have returned > zero if mapping the IRQ fails. This contradicts the > fwnode_irq_get_byname() documentation. Furthermore, returning zero or > errno on error is unepected and can easily lead to problems > like. What's the merging plan? Could patch 1 go to a stable branch and then driver trees can pull it in and apply their respective patches locally?