Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] soc: qcom: pmic: Fix resource leaks in device_for_each_child_node() loops
Date:   Wed, 31 May 2023 14:44:10 +0800
Message-Id: <20230531064410.35001-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HseWw9AxUr3PStFv1G2hCi93blLofP0eSOtbvAFcKU5BNlX2O8Jabx0zUSN2?=
 =?us-ascii?Q?Xc/ugfQhKS3lxdGTn/h2QSuV5B6RIqiCOEYW4WIpmPQdW1Zjc0/qHOOqtheP?=
 =?us-ascii?Q?luROQvUYd+DSFRENKdNgp4Pbc40erVlDVf0fTR3Y4zRBQBEuulSvun/Q3tjn?=
 =?us-ascii?Q?u8Q41kNSsuH5h6GaaMHR9jl+ZU1Rv1Fbbo+aZlwkn0s/6TcoxiKLuhULortO?=
 =?us-ascii?Q?SYDU3+IRQrzkT+BrOIdL8ghWAXhQ1FHQ3ilpv/Y/nZdCWHBBXlBwLULKvEja?=
 =?us-ascii?Q?NC5FCr7XwRgerYUuMz9ijpuHZD3ht+PYYaIhTqhS4xrZFJxSxM9/9H7x1Ayt?=
 =?us-ascii?Q?Py2Ib2h0xF2U/+XpGW0oTU6B3DfUOmcR4ildbgr40YtQCVFmTLAwTpCgSExK?=
 =?us-ascii?Q?Eain5MlfCSeIV3EFIxtm0dpj46CglLBYmKWxja1ZRavsPph8bqop+Ts6esjp?=
 =?us-ascii?Q?rSTabz5vtY5odbJePLBEBo2rqjkstxqYnVfFMn+WHzAaYAKujiRXoDVfhVra?=
 =?us-ascii?Q?bbcTQQ23vSA8+ZDIJu0FbraHDPW++OFJj+h5rwhR92EdaK0Umc/2UVQudJIp?=
 =?us-ascii?Q?JL1ucUjuUbJ8jwlrC8SStPa+WFQ/pxzSn6n5Y8K6W8RytAQq4R0Qr/XiylO+?=
 =?us-ascii?Q?RamW4NcAu7ppO7D/Qv6fBrpV1pQuRAxrcEI+1m6N/bBT4Kp1upLYIZPk8/G6?=
 =?us-ascii?Q?4ZOfGqVc39PhDI4Vn2P81tx85vEUCWGbkhvFxGiQ+1TJTqz+Ab0CCHZxA3cN?=
 =?us-ascii?Q?9YmXOWS2WmPwclWR/eHT8Eluuptx7+CJxUTH+Wz9zGdnSCatvRsiUUqeO+1/?=
 =?us-ascii?Q?g48GgfUSgUJd9XXJEolWM6K4F7lc4wB9/EFIoIZCM6nICyE6A+ZNOtv6wZkB?=
 =?us-ascii?Q?6mXHwxS/BPTo2NpOV3MgUueH0utnv5pgLU7PZAz8O64O96fvPkfddGlV36rA?=
 =?us-ascii?Q?fYzIxqomE7+5l2hQQVDedsIbmINnOt3P9ijZkmK0Zwlqb8LOY/vNpulH5QjS?=
 =?us-ascii?Q?oKviCx513j9hcqYmqiDDuFck1MZ5Jo9Mi3PRvP3ynWVohPyL1IBrKbvAU5pt?=
 =?us-ascii?Q?huzgjNhFfKXXw9xIIyebYDSVQbzaYnz77EUV/I9pvTnDG0oQNRBgRXjNCIL6?=
 =?us-ascii?Q?gKFuZLxdCML7vDHcOLA32njRgFFWtx3DuwPscqVJh8+UeRDAkbTLThqvL2zK?=
 =?us-ascii?Q?KmR1Sz7uVQ2buqjouRE5RMpKbqRPlaVBWUfdNtKdQGVdYqOnldvevXCuL1Cp?=
 =?us-ascii?Q?ngwOlyiqqjxIZwfufhVFbQUH8wtg8Z/B5Mx2+PbeCVC/UUUQmmXQzZxyFamd?=
 =?us-ascii?Q?DEvOuqYoioV16lwMgCb6dLTqCkzry3jLJTjFT95ckrFgZYdiYK3n/oasiige?=
 =?us-ascii?Q?CCJa1AbOq+FhAY9QLn6jNgaPxI0YFSC4W0E580nGrSFRonIgmHzchrTttqgB?=
 =?us-ascii?Q?50knez9q3LVQv61wacawXC7oR0FI9T5ilJZr//lSkidbWU/t5KMUaljnstF1?=
 =?us-ascii?Q?MNBoNuLah4JpRnhmcjDxFAVcrA/Ky/5VXTFEkl85zOcCXQF8SRmL0INJv0sK?=
 =?us-ascii?Q?r/9tyHTK8YdJDeAQ36j5VznPU1seq4pNa1lfWco8?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1b0c61-47dd-4c5d-65c6-08db61a27758
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 06:44:22.0005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JXWHOuf28ls5RbECEWW6SAjMyR5v36AOdqkHAwNfJZXtuHwwnuYrAfYT0164c1YKVmAjCoAtFVHYItKp+W/59A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB5884
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The device_for_each_child_node loop in pmic_glink_altmode_probe should have
fwnode_handle_put() before return which could avoid resource leaks.
This patch could fix this bug.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/soc/qcom/pmic_glink_altmode.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index 4d7895bdeaf2..3faabaf9ef08
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -396,7 +396,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 		ret = fwnode_property_read_u32(fwnode, "reg", &port);
 		if (ret < 0) {
 			dev_err(dev, "missing reg property of %pOFn\n", fwnode);
-			return ret;
+			goto err_node_put;
 		}
 
 		if (port >= ARRAY_SIZE(altmode->ports)) {
@@ -406,7 +406,8 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		if (altmode->ports[port].altmode) {
 			dev_err(dev, "multiple connector definition for port %u\n", port);
-			return -EINVAL;
+			ret = -EINVAL;
+			goto err_node_put;
 		}
 
 		alt_port = &altmode->ports[port];
@@ -421,7 +422,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		ret = devm_drm_bridge_add(dev, &alt_port->bridge);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->dp_alt.svid = USB_TYPEC_DP_SID;
 		alt_port->dp_alt.mode = USB_TYPEC_DP_MODE;
@@ -430,26 +431,30 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 		mux_desc.svid = USB_TYPEC_DP_SID;
 		mux_desc.mode = USB_TYPEC_DP_MODE;
 		alt_port->typec_mux = fwnode_typec_mux_get(fwnode, &mux_desc);
-		if (IS_ERR(alt_port->typec_mux))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
+		if (IS_ERR(alt_port->typec_mux)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
 					     "failed to acquire mode-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_mux,
 					       alt_port->typec_mux);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->typec_switch = fwnode_typec_switch_get(fwnode);
-		if (IS_ERR(alt_port->typec_switch))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
+		if (IS_ERR(alt_port->typec_switch)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
 					     "failed to acquire orientation-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_switch,
 					       alt_port->typec_switch);
 		if (ret)
-			return ret;
+			goto err_node_put;
 	}
 
 	altmode->client = devm_pmic_glink_register_client(dev,
@@ -458,6 +463,10 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 							  pmic_glink_altmode_pdr_notify,
 							  altmode);
 	return PTR_ERR_OR_ZERO(altmode->client);
+
+err_node_put:
+	fwnode_handle_put(fwnode);
+	return ret;
 }
 
 static const struct auxiliary_device_id pmic_glink_altmode_id_table[] = {
-- 
2.39.0