Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530154252.7895-1-osmtendev@gmail.com>
In-Reply-To: <20230530154252.7895-1-osmtendev@gmail.com>
From:   David Rheinsberg <david.rheinsberg@gmail.com>
Date:   Wed, 31 May 2023 08:35:18 +0200
Message-ID: <CADyDSO6nY2=UONuHk0PMszWJ_Hnpg6h-VYX40xGtU2CnhTcy+w@mail.gmail.com>
Subject: Re: [PATCH v2] hid-wiimote-debug.c: Drop error checking for debugfs_create_file
To:     Osama Muhammad <osmtendev@gmail.com>
Cc:     jikos@kernel.org, benjamin.tissoires@redhat.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi

On Tue, 30 May 2023 at 17:43, Osama Muhammad <osmtendev@gmail.com> wrote:
>
> This patch removes the error checking for debugfs_create_file
> in hid-wiimote-debug.c.c. This is because the debugfs_create_file()
> does not return NULL but an ERR_PTR after an error.
> The DebugFS kernel API is developed in a way that the
> caller can safely ignore the errors that occur during
> the creation of DebugFS nodes.The debugfs Api handles
> it gracefully. The check is unnecessary.
>
> Link to the comment above debugfs_create_file:
> https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L451
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>

Looks good, thanks!

Reviewed-by: David Rheinsberg <david@readahead.eu>

Thanks
David

> ---
> changes since v1
>         -In v1 the IS_ERR was used for error checking which is dropped now.
> ---
>  drivers/hid/hid-wiimote-debug.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/hid/hid-wiimote-debug.c b/drivers/hid/hid-wiimote-debug.c
> index a99dcca2e099..00f9be55f148 100644
> --- a/drivers/hid/hid-wiimote-debug.c
> +++ b/drivers/hid/hid-wiimote-debug.c
> @@ -173,7 +173,6 @@ int wiidebug_init(struct wiimote_data *wdata)
>  {
>         struct wiimote_debug *dbg;
>         unsigned long flags;
> -       int ret = -ENOMEM;
>
>         dbg = kzalloc(sizeof(*dbg), GFP_KERNEL);
>         if (!dbg)
> @@ -183,13 +182,9 @@ int wiidebug_init(struct wiimote_data *wdata)
>
>         dbg->eeprom = debugfs_create_file("eeprom", S_IRUSR,
>                 dbg->wdata->hdev->debug_dir, dbg, &wiidebug_eeprom_fops);
> -       if (!dbg->eeprom)
> -               goto err;
>
>         dbg->drm = debugfs_create_file("drm", S_IRUSR,
>                         dbg->wdata->hdev->debug_dir, dbg, &wiidebug_drm_fops);
> -       if (!dbg->drm)
> -               goto err_drm;
>
>         spin_lock_irqsave(&wdata->state.lock, flags);
>         wdata->debug = dbg;
> @@ -197,11 +192,6 @@ int wiidebug_init(struct wiimote_data *wdata)
>
>         return 0;
>
> -err_drm:
> -       debugfs_remove(dbg->eeprom);
> -err:
> -       kfree(dbg);
> -       return ret;
>  }
>
>  void wiidebug_deinit(struct wiimote_data *wdata)
> --
> 2.34.1
>