Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <af5b0669-2621-7fce-358c-76dca7b521c5@amd.com>
Date:   Wed, 31 May 2023 12:58:46 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH V2 5/9] ASoC: amd: ps: add support for SoundWire DMA
 interrupts
Content-Language: en-US
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        broonie@kernel.org
Cc:     alsa-devel@alsa-project.org, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, Mastan.Katragadda@amd.com,
        Arungopal.kondaveeti@amd.com, mario.limonciello@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20230522133122.166841-1-Vijendar.Mukunda@amd.com>
 <20230522133122.166841-6-Vijendar.Mukunda@amd.com>
 <fea3c862-1470-7911-ff77-5d945b1d77cf@linux.intel.com>
 <2dfeee7c-32bd-c054-22ff-3a2266e62c90@amd.com>
 <f11f3370-0b72-cb1f-21cf-c574ef03fd72@linux.intel.com>
 <017abf89-a1aa-0c85-e244-a56c05b7c6e2@amd.com>
In-Reply-To: <017abf89-a1aa-0c85-e244-a56c05b7c6e2@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anFsT2gwb2k3Q1loV3FXYVlicWxPRUh0djlQRWtsR2ovVGZoenhhc2V5L2E3?=
 =?utf-8?B?c0VlQVkvTHVRUmJYYjZSSTNqVDltV3VmMlFGdUVWblFkYldySHlQcG9UdGVk?=
 =?utf-8?B?R0lzV2lkcGE3MEloOGh4Q3BNbGRmM3Y2QmYwdmtZN3ZLTXBWUVFrUGxGTHpJ?=
 =?utf-8?B?MHpxV3NLU2xtSTZTSDBuOU9DTld1d2l5TmpFTTFyUWFLYzAvbFFob3ZtdExn?=
 =?utf-8?B?bEljMHlKaTJqMUFJM0FrWXkyd0hOa0k1enZYbmp1cTdFbkVnTExqSm1pT05y?=
 =?utf-8?B?WHlHQ0REMnRBNlZnRWVwSngwMzR0ZDB4a3VyNGdzRkZMVXExTUpFL1UxVkVu?=
 =?utf-8?B?azhNOXpGWkJzbEt6c2NsMk9FdUduRGJFUzBVc0cxS2tDUTUyYzVMUVZuTnFH?=
 =?utf-8?B?NjA1cENGcEZTK1Z4SEFSMVRPWk9Rbm9HTEY3WXRoUE1sa3BzTFBkVjlrSzRY?=
 =?utf-8?B?MFY4S01nVTdNQTRldTF4RmNDSFU0OGJXL29ZeTh1VnUzWTJya1BMUE8rUnRt?=
 =?utf-8?B?c0hUUjJmQ1lYTEsvU1FVUE85MEJyc2xzQjV0bWdIRy9YdFNMbVRhTXBJWWty?=
 =?utf-8?B?SW8yTlRMZDZkcVpDb1VBbjIrT3IyOFFaeVdLdng1NVM1OE9IeUJ5RzNnWW5Y?=
 =?utf-8?B?SjY4c1cyV3Zyc3Q3bGViekgxVytPWDN2Yk9tQVJoRGVNdlpaTWhxZnVjMkg1?=
 =?utf-8?B?SkxzVk8xcWlIUzhVUGVjU2R0a1c1cGpMamN2bGV1c2NRQjFXdUNsZmUwaHEx?=
 =?utf-8?B?aURSRGRuWDFYdHVSWUYrZ1ArNnI1ZE13TGJPWG1kOUk5SmQ4V1ZGUFk0Y2o2?=
 =?utf-8?B?czNsbFdySng2Uk15QWUxcEFIeWVhYjlqenFHLzhpUkM1N20wZ1VDOStzb1ZI?=
 =?utf-8?B?YWpzY3REV0hmcU1iam9LZ3NyUmQxNDY5T2NIWTdTeHB3ZjN3cGNxR3pWc0xK?=
 =?utf-8?B?b3I1RkIrR0Jkay9WNnEyZEhkYlZ1TVJmVk1SR1VLUEs1ZTVMbVNrcWVtS1Vo?=
 =?utf-8?B?cnhIVjlscXZucEZGWG9ZVFoxZzRDUDF3bkxVMUl0SW5BSTdFN2dwVG8rZndo?=
 =?utf-8?B?WXhlUE1UVUJqbVh2OEthZTlCRDRkMmRFR2o3ZmNyWXRlcFpjNnFsS0lvQ2ZW?=
 =?utf-8?B?aklZejFuZW9vR3JvQ2J2clRIaDJPT2VoYTNmOHdZckJ1OTBlMks4cXd6bTYw?=
 =?utf-8?B?bWJISFN4QnlleVBkNGJaNTBBbzYvYVNpcERYZ21ZQm9MbmZFSFBpbkNHNWJP?=
 =?utf-8?B?UlZ5MUJocjRtZjZkQTJEOWFxM1VNaCtTVU45WkFlNStqMzZPZklndWRub1Jt?=
 =?utf-8?B?cHdXT0loM082V3ZuTytrMDJqL0YxdHhmdFRETUpTZXUwN3JnQ2NiMWRaajYx?=
 =?utf-8?B?b0U5OWN5dXlQUmk0eWVLdVhZaE10eTVET1N5UFRLNzY1TmcrWWd5aUhZbFUv?=
 =?utf-8?B?aUk4VFZSOVVycGl4OG1ib243WVlwUExSYW4wVkdVM1h0T2NEM3pzZlUyWERW?=
 =?utf-8?B?SG5yZHc2N25rczJ3S3VER1h5b2lpcDVUNDAzVVhwNStPYmUxU0htdHhQbHhz?=
 =?utf-8?B?cUM2N3V1ZDlYZGxiYVVoZjZaQmtHQmY1OXpxcDlnRjl1Z2Q0YStKaUdSeHpU?=
 =?utf-8?B?amZKZldJbDF3UGpmZzR4RXFqZWgwdWdyYWQxVWlKQmpHMklpSktqdXAyMG4v?=
 =?utf-8?B?clZxU1lqVFM3Y0FrbGxEVUZzYzdUOHBQRXF3REI3dVlUQ044WXpWc2NsdzhO?=
 =?utf-8?B?UUlGUzczaVhTRVJLbnpHdy9sYU81NGVzc2RjRUNjU2ZBb3ZGbzREbWRJVUp4?=
 =?utf-8?B?NllCRUUwQ1RNNjVNSGtrdlM0M25OQWEwRk1pRkRibGd5ZGxyU2ludndhS1dt?=
 =?utf-8?B?QmNCUUlmOS9UVExjQkUwY3RsOGkrSWlVQ3ZTTDYvbnFRWWVMenBSTjFnYkhS?=
 =?utf-8?B?VmE4amN3aHlPa04xR1JVelBKTzE4RTR2anJUV1NRNThjSmQ1eWVrYmkwNHJj?=
 =?utf-8?B?RnRVTGhpcVBmMzFXemt1VUR5dXJjdnUzc0czdDQrRFlRRE5QcXB1RjJEbEJk?=
 =?utf-8?B?c0dzSVQzeG5JcGk1U1Y3UC95QWVXYlhYR0RhaCttNC9Ga2I2ck1jc3dPR200?=
 =?utf-8?Q?s9aVbBcbY3ccAMFbQ+jJl+w36?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4d66883-15f2-40c8-acfc-08db61a7ffd2
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:23:58.6430
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HlVH3QDfmMd5hFVDQDpP1Rk7CsmcFEq9Liv0YM3YhbCaZ/HxWOhADA41kIHr9Rbw8mE5zGxcYvPXqIjML/YXSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5984
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/05/23 13:15, Mukunda,Vijendar wrote:
> On 23/05/23 20:30, Pierre-Louis Bossart wrote:
>> On 5/23/23 02:36, Mukunda,Vijendar wrote:
>>> On 22/05/23 23:42, Pierre-Louis Bossart wrote:
>>>> On 5/22/23 08:31, Vijendar Mukunda wrote:
>>>>> Initialize workqueue for SoundWire DMA interrupts handling.
>>>>> Whenever audio data equal to the SoundWire FIFO watermark level
>>>>> are produced/consumed, interrupt is generated.
>>>>> Acknowledge the interrupt and schedule the workqueue.
>>>> It would help to explain why a work queue is needed is the first place,
>>>> as opposed to handling periods in the interrupt thread.
>>> For SoundWire DAI link, we are setting nonatomic flag to true.
>>> If we return period elapsed from hard irq handler instead of workqueue,
>>> soft lock up is observed during stream closure.
>>>
>>> We can use interrupt thread as well. To have a symmetry with
>>> SoundWire manager work queues, we have used workqueue for
>>> DMA interrupts.
>> Oh, I completely missed the model here.
>>
>> If you are using the bottom half/hard irq handler to read status
>> information, the natural thing to do would be to have an irq thread, no?
>>
>> Not sure I see the benefit of aligning with the manager work queues -
>> unless it makes your life simpler to avoid race conditions with
>> cancel_work_sync()?
> We can implement request_threaded_irq() and move the handling of
> DMA interrupts to thread function whereas we need to handle SoundWire
> manager interrupts in top half only. Reason as follows.
>
> As per our design, we are not masking the interrupts in top half and
> restoring mask after thread execution like Intel and
> our IP supports line based interrupts. If we move SoundWire manager
> interrupt handling to thread function, we have observed interrupts are
> reported but not handled properly due to thread execution is in progress
> sometimes.
> we will add comments for this design constraint in the code if we have to
> go with threaded_irq implementation.
>
> @Bossart: we are waiting for your reply.
>>>>> +static void acp63_sdw_dma_workthread(struct work_struct *work)
>>>>> +{
>>>>> +	struct acp63_dev_data *adata = container_of(work, struct acp63_dev_data,
>>>>> +						    acp_sdw_dma_work);
>>>>> +	struct sdw_dma_dev_data *sdw_dma_data;
>>>>> +	u32 stream_index;
>>>>> +	u16 pdev_index;
>>>>> +
>>>>> +	pdev_index = adata->sdw_dma_dev_index;
>>>>> +	sdw_dma_data = dev_get_drvdata(&adata->pdev[pdev_index]->dev);
>>>>> +
>>>>> +	for (stream_index = 0; stream_index < ACP63_SDW0_DMA_MAX_STREAMS; stream_index++) {
>>>>> +		if (adata->sdw0_dma_intr_stat[stream_index]) {
>>>>> +			if (sdw_dma_data->sdw0_dma_stream[stream_index])
>>>>> +				snd_pcm_period_elapsed(sdw_dma_data->sdw0_dma_stream[stream_index]);
>>>>> +			adata->sdw0_dma_intr_stat[stream_index] = 0;
>>>>> +		}
>>>>> +	}
>>>>> +	for (stream_index = 0; stream_index < ACP63_SDW1_DMA_MAX_STREAMS; stream_index++) {
>>>>> +		if (adata->sdw1_dma_intr_stat[stream_index]) {
>>>>> +			if (sdw_dma_data->sdw1_dma_stream[stream_index])
>>>>> +				snd_pcm_period_elapsed(sdw_dma_data->sdw1_dma_stream[stream_index]);
>>>>> +			adata->sdw1_dma_intr_stat[stream_index] = 0;
>>>>> +		}
>>>>> +	}
>>>> I am not clear on the benefits of the workqueue which only tests a flag
>>>> that's set ...
>>> In top half, we are checking all stream irq mask and setting
>>> corresponding stream id index in interrupt status array when dma
>>> irq is raised.
>>>
>>> Our intention is to handle snd_pcm_period_elapsed in process context.
>>> if the flag is set, call the period elapsed for the substream based on stream
>>> id in work queue.