Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a745c910-f4be-62f6-cb02-a610c04f4698@intel.com>
Date:   Wed, 31 May 2023 15:09:56 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH 2/2] iommu/vt-d: Use BUG_ON to check NULL value of 'table'
Content-Language: en-CA
To:     Baolu Lu <baolu.lu@linux.intel.com>, <dwmw2@infradead.org>,
        <joro@8bytes.org>, <will@kernel.org>, <robin.murphy@arm.com>
CC:     <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20230530092503.152926-1-yanfei.xu@intel.com>
 <20230530092503.152926-3-yanfei.xu@intel.com>
 <3e75f9de-4c67-93aa-9fb4-28da9849dd48@linux.intel.com>
From:   Yanfei Xu <yanfei.xu@intel.com>
In-Reply-To: <3e75f9de-4c67-93aa-9fb4-28da9849dd48@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0IrM2VqeVRKWWpIdm9ZTjlnVU8ydTN6SG9meGFvYkttNGxZcGJ0dW5mTTg2?=
 =?utf-8?B?YkRmb0M2RE9COGs1K3J3YlF5RVVFbGF1djk3M2ZqakUwVjFESXJDbXlKNGxn?=
 =?utf-8?B?bkNtbUUyK0pzUEU0SjF0MzVyLzdOQVlkUW9JUWI2ZytNTThrbXphTWZZZHVJ?=
 =?utf-8?B?bFRaMGgreUFRWkxHZFhoMEcwN0paTWl6aytvYVVneW55T0hDS1N4Y2c4bHlz?=
 =?utf-8?B?aExkOHVPRjhqQXl6ejlXd0VzNkFaRG56bitmWFBnenZqc01YK2FNWGRlS254?=
 =?utf-8?B?OHlhNGs1czVrNnVFa3g5bi9FdUhyeHN6SjBlV2oyTDQ5VkEra3gvN0d6YlQ0?=
 =?utf-8?B?Q1NUMklUUUM0TFNPOTZXbUxCdXRsUUlnbkVOTWxsMFM3NDFTY2s3d3RrcFVK?=
 =?utf-8?B?UlhNb1c5cDlZbVlWdEYvdVRkV1IyWGtod1g1OEhKR2VDcHdTeGNzNHpuQW9n?=
 =?utf-8?B?RHc3THBMTjlVK0YxaGNFY2QyNkJQbkRPcXlWNnFxRWN5VmNJMDZ1eXplbndY?=
 =?utf-8?B?T2xWT0JoVmxPVXJFUmx6cEFGUFRjMXUyNUl1amM5OEh0eUJzdXNMcVFrSVRM?=
 =?utf-8?B?eWVPS2w3UkxjRWZyc3BJOE1Kd1ZkTWNob09DT29wdzFlMTZNVkFWSlp4djRZ?=
 =?utf-8?B?YlJQblFEWnZCTHRZTmVTUDQ4b09HY3lXWHRNY2tFcGlQZHRCTlBRNlZicTNK?=
 =?utf-8?B?YVIvdEtIYm1Gd0xIbkFpZkREaVpJMDk0Z0ozekNTcHo2dW5CODhNVHg0Mlpp?=
 =?utf-8?B?V3ZnRllFdEZFdjVrR0JBSmdCSzNnRUZVbjZDRlVBVkM3YkFLMGxmQkZaY0s5?=
 =?utf-8?B?UHd3cytsVXJJMVoyL3c2eENxLzZDeWhSSGxqTFpNUC9WT2JBV0gweFdKK0FG?=
 =?utf-8?B?MW5KbUg4aTVRanZxbFAwSXVSNUtOY1pYT3R3enBMNFVLbUd5amtsNmpBRG1S?=
 =?utf-8?B?enJnN2RiSVAzZmthNkQzeDFDRzE1RGxSZ29TaEJEelJ5M0RWSWkvKzZxekw1?=
 =?utf-8?B?N2t1UHZaa2s1eTdUNG1YdjJ5QUZqcCtsQmp1TTNKYnVNa0hDd0xSZmFUM3dZ?=
 =?utf-8?B?QkF6RUV6bzZjQ0RDYTJ5dEkzWkpNYWVTYnk2b0ZDVkIwa0VidEEwZmpUS3Vt?=
 =?utf-8?B?Vy94dzRHQ2VLK2JKdEt3eXZWNVp3cS9rT25xbjFoQzRVMUJMd25qVWFOanNZ?=
 =?utf-8?B?TURuZFcxMkUzSk92NHdsbGJZMXplZ1lxNGxpQ09Sc2RkcUFJUkpmSVI1Ymlu?=
 =?utf-8?B?aGc4dGZrU1dqL1NPSjEwdEFIaGtoRGVUME1RbG1ENitYeUg0czJOd2pCb0xF?=
 =?utf-8?B?T1VLMXhzb3VOMGtNb0tGZTZaQnF4c1hxTkZEbGlBeUphVDltTUJrdzZ4alJQ?=
 =?utf-8?B?bFRPTmFQSmh3VGdSRkMyVnVvakxacTFoNzN0bEJVZ1M1M0FacVFqYnF0YXdm?=
 =?utf-8?B?T3cyczdXb2EydHZmeXBVUzhJNVhmMHNYajVaOGxZMzdRWTVvcDdKVXNNR2VJ?=
 =?utf-8?B?a25JcHk1NHhOaUNvb2tpREYzNlBIZGNnNTl6bERHQnYyd2VOMVZVTFFqZUVF?=
 =?utf-8?B?L2tqYmtaSXl2R1JNSzZCRU8vQWtPSUNMdUFyZGxtNm5CbEkwc25XcnhmWFNJ?=
 =?utf-8?B?b0ZFa1Qzb3ZCbWFTZ2hUTndEZUI3TDRhK250VHo3MGg2Z3BqUk1qZHI1V0ls?=
 =?utf-8?B?RHpmaFIrWG0yWUx6L0taek5SUExHWm8vOGhxSnQ3MU1ZbW1NZkx3c1JheFc0?=
 =?utf-8?B?N3NEMkd3bTU1ZlZXNGlueUEzRHVNUlBsQW1YcE1GQ2M0VVRwd09XR293blBq?=
 =?utf-8?B?WG8rMllIeXlBWGdSY3ZHUVNYaHg4aURzVkEydmYxKzErNzFENWwwK29NM05F?=
 =?utf-8?B?S2N2T3hGSlpkNE5hL3dNUjk4d0phbXAyazBkbkdQbWIzVUdtVHhlVDZMWHFC?=
 =?utf-8?B?MVVJS0R5ZElCbHF5RHJRMlNaSmpqaExZWmpJcEs5T2FLd2tiSTcyOWVmQVI0?=
 =?utf-8?B?aWIyUE1ETDBKVUoxejEvRnRXRWordm9uaUlPemdsV04xRjdRd0d0MHVNL1BB?=
 =?utf-8?B?ZmhQNUE3UW9Lc2gzcHgvV3dQdE5ET0k1Ti9NMzhxeVVMdGk2bE9oMEVjMVlx?=
 =?utf-8?Q?UvVIvCXe8EFgv8gYLC34xJg4b?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e1abf316-0070-45e1-de73-08db61a60f46
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4138.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:10:05.6646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bGchnVJlYqtWpIuhIoCj5C/XdS5G+Bn8ADRLurSwvE4CEhrU5KGLkW24U7jr/APxT0UZDuLRxqKz2r0giMkXcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7387
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Baolu,

On 5/31/2023 11:26 AM, Baolu Lu wrote:
> On 5/30/23 5:25 PM, Yanfei Xu wrote:
>> Checking NULL value of 'table' variable deserves a BUG_ON as the
>> following code will trigger a crash by dereferencing the NULL
>> 'table' pointer. Crash in advance with BUG_ON to avoid WARN_ON
>> plus NULL pointer dereferencing can simplify the crash log.
>>
>> Signed-off-by: Yanfei Xu<yanfei.xu@intel.com>
>> ---
>>   drivers/iommu/intel/iommu.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
>> index e98f1b122b49..8aa3bfdb7f95 100644
>> --- a/drivers/iommu/intel/iommu.c
>> +++ b/drivers/iommu/intel/iommu.c
>> @@ -1944,7 +1944,7 @@ static int domain_context_mapping_one(struct 
>> dmar_domain *domain,
>>       if (sm_supported(iommu)) {
>>           unsigned long pds;
>>   -        WARN_ON(!table);
>> +        BUG_ON(!table);
>
> BUG_ON() is not recommended. Perhaps,
>
>         if (!table)
>             -ENODEV;
>
Agree:) It is always better to handle the error than crash kernel.

How about:
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 8096273b034c..7f077e3a4128 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -1944,7 +1944,10 @@ static int domain_context_mapping_one(struct 
dmar_domain *domain,
         if (sm_supported(iommu)) {
                 unsigned long pds;

-               WARN_ON(!table);
+               if (WARN_ON(!table)) {
+                       ret = -ENODEV;
+                       goto out_unlock;
+               }

Thanks,
Yanfei

> ?
>
> Best regards,
> baolu