Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <be6e2b30-e1da-7028-2ac2-6eb0f9ba0632@intel.com>
Date:   Wed, 31 May 2023 09:33:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1 1/5] ACPI: thermal: Use BIT() macro for defining flags
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
References: <5675481.DvuYhMxLoT@kreacher> <3229381.aeNJFYEL58@kreacher>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <3229381.aeNJFYEL58@kreacher>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clgyZVI0c2p3TENQSWorczRPVEU3SzB6eGpzOVZybENvM2xhRjRnTlFQZ3o0?=
 =?utf-8?B?K1M1N3BXWG4zRm1CZ3FZWDBCRS9SQzNEUDBhWXYybUhnaGJBbHk4bDNJYkNK?=
 =?utf-8?B?U05RZmNqbDVDSUZoZXhvb3FEbDl1cG92TmcrV1puSFBqaHJBbE51akN3ZFkr?=
 =?utf-8?B?NE0wMlJnR0FIdy95MnlxY2ErdE5MN2hvTlhDbmF5b2tIbU1RRll6Q2kvR1Ni?=
 =?utf-8?B?blBqL2xhQmhBZERkZXdCTE4yKzJmQm94d3V3aXBTTFZZai81WUlRY2pZVUJY?=
 =?utf-8?B?WHJJOWdrcmluSzZscDB3WmNLWXBmYnZxOGtKbTNLMWlVdE9qQ1JLNkhOQUd0?=
 =?utf-8?B?V00rc2M5SjB2UkYrSHp3UWVNTDNrT3dYTmQ0blB3U050RnBYWUNCcklVKzMx?=
 =?utf-8?B?cWRLeWVJL3Rvb0hkNVVEMjMrSzc3YnIxN1hNSVhBUHFNSjJIMlZSUVJGY09k?=
 =?utf-8?B?dnR1dmVNVWZwQkNNNnFLeUNGUXNJSURIVGlrcHhoL1NoTWEvckRKMG5ZQmNF?=
 =?utf-8?B?S2kyRXVzdVdyclViZ2FwSVlacFRkTFI4Wkh4WkdYZ0h0R3BrdnE0bDZmZFhG?=
 =?utf-8?B?YmRXbk1EWjlwZ0lzamkxSC9ZVEhndFRwRzEvRld6VElJK2FUNE9UQ2tPTG9F?=
 =?utf-8?B?bDlXS2RzVVM5K09KVXlzYmgveHBVblNZQWVwaHpyejVJNDRqVjhFWGxYcFI4?=
 =?utf-8?B?YjZOVzBmT01QcXV6eEp3bG4xYVc1UFFrNklMcDdGdUdTRTBsUzVmcjRjemdJ?=
 =?utf-8?B?cGMwWEs0VXREcHNGeXpDS3dlM1pYeld1cDhMcnJnU21sZXhtZ0UzWlhmL3JG?=
 =?utf-8?B?UXFGOEl1NWRvUVR2ZTRHcVFuTVNRM0ltc1dtc3N3VzZWaVZGa2RVdFB1Z2Z4?=
 =?utf-8?B?cVRHbDdMTEpQVnN4akhXZDFaeEJOSXFaZjFZNHFKazRBR3RROWxxbHc3Ujd5?=
 =?utf-8?B?d2p5RUt4WHpLWkkyMmthZlJXV2NnRTJIbHVUMmo5RnZnMDJrWnFSU1VTbjY2?=
 =?utf-8?B?UWxJS0RSRmZ0VElKdndlWUVHYkxsWXllb0hnMElONDRLQlhrbjRlTDNITURu?=
 =?utf-8?B?dzBRcmdTeDc1YUkxYUFNd2orUThTdEZmNGdKUjNsb3k2Nzl2SHZ6NEpuZnVx?=
 =?utf-8?B?OExqWEJMQXgrejlmME9JVjRkbnVTbW16cTFRZGIzMjJhQko0cktzZlplS3BW?=
 =?utf-8?B?Z2dnL2RZdnVXRU44ZEZ4ZTRDZUsyN1RuZXp2dWxYZlFJenJvNG5URUNvbTFW?=
 =?utf-8?B?TllMWldSL2JqRHlVNTA3WmlaSXV5NkkyTGw5MkFIQ2tLa2l3VmEvRFptN05I?=
 =?utf-8?B?clQ2V2c4NTFtRlNoSWxTMVNGUzFNUDFzT2doOXFrNU40NmFSWFhsZnN2Tyth?=
 =?utf-8?B?bCtQSGRGR1YwYkQ3Q3RpelE4RFVlWHdIVVJXRVErUjJlK2VDMVpONHhHTlRp?=
 =?utf-8?B?WHRBUWhWRVZ3dWhvZDFMUGVLdWt1NHR3QTVJbWVkS2ZJZVQ2ckllckZ2enJa?=
 =?utf-8?B?c09iMXEySnlBekp4UjhIVjJjUXBUSU1tRkNGQUdmQjErOTN2U0dtWnJUaXR0?=
 =?utf-8?B?cDRzQzJTVGRPaXM5UW1iamhiaXkzcWl5dFlmWTJhRnhFMHUyZDFtM2VyWml5?=
 =?utf-8?B?dm5WQUlwWWNFazRqdU5GMThidkdTSit2dlVEZytoRkJGQ2tzdEI5RlAveTZ4?=
 =?utf-8?B?UFdIUjF4YTdkeThUclhLQU5QaUt4Y1B3Z1d6MkdwNUlyOWNjV2k0S3B0NXFL?=
 =?utf-8?B?bGZBV0o2aVo2cUd1eXVUYXp5ek9WNUZBcEhlU2sxbkcxSVNDMVdCTHpTQVNl?=
 =?utf-8?B?cEhLcGxTRitxMGY1NjMxM0diTU12djBiNUJEMVpNQWgvM01mNDBvcEVRWG5D?=
 =?utf-8?B?V0dIZGNkem1uM2xwWmZtdGZtRXo2S29XSHpWQnlrYS85dGVaR0lxYnZFZ3dm?=
 =?utf-8?B?MXFEUTZwT2toMkRqVWd3eTYrSGdHU3dUV1ZvOXQvM1ZXVG1pVG5ERzBiU3JN?=
 =?utf-8?B?ait1Z2lCemFyblEyTmpmaG9rYVpVK1NOUDlBczNOMWQzMytDY1pqcm9mTG12?=
 =?utf-8?B?Rm1DdnVJdjh0TWJQa0VJZ0UxbUNhUXM1OVVoczRIVVlOejM4UDdqUWhlajFS?=
 =?utf-8?B?SDdoclhYdkpVYit0UDluNHAyWGxudHd0TUJKb0ZMbVZvc3ZaY3ZYUUpkUmE4?=
 =?utf-8?B?d1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 757ed175-6e3f-430e-1b6c-08db61a960c5
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:33:50.7004
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0zj8BKSxpgFkAmfPo0dqE2YJ3OL/N9DDPblYEVMiETzegTGdJXQpkrCRgYcX/B4eKkvRawjSF/4g4h0wWg5THmC+A783ueR5lqXM/2pMmA8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7269
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/2023 5:44 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Use the BIT() macro for defining flag symbols in the ACPI thermal driver
> instead of using "raw" values for the flags.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/thermal.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -232,11 +232,11 @@ static int acpi_thermal_set_cooling_mode
>  	return 0;
>  }
>  
> -#define ACPI_TRIPS_CRITICAL	0x01
> -#define ACPI_TRIPS_HOT		0x02
> -#define ACPI_TRIPS_PASSIVE	0x04
> -#define ACPI_TRIPS_ACTIVE	0x08
> -#define ACPI_TRIPS_DEVICES	0x10
> +#define ACPI_TRIPS_CRITICAL	BIT(0)
> +#define ACPI_TRIPS_HOT		BIT(1)
> +#define ACPI_TRIPS_PASSIVE	BIT(2)
> +#define ACPI_TRIPS_ACTIVE	BIT(3)
> +#define ACPI_TRIPS_DEVICES	BIT(4)
>  
>  #define ACPI_TRIPS_REFRESH_THRESHOLDS	(ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE)
>  #define ACPI_TRIPS_REFRESH_DEVICES	ACPI_TRIPS_DEVICES

Looks good to me,

Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>

>
>