Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d93db4e9-16b4-d20e-0769-d6f9b8826b64@intel.com>
Date:   Wed, 31 May 2023 09:48:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1 2/5] ACPI: thermal: Drop redundant
 ACPI_TRIPS_REFRESH_DEVICES symbol
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
References: <5675481.DvuYhMxLoT@kreacher> <8222291.T7Z3S40VBb@kreacher>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <8222291.T7Z3S40VBb@kreacher>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzhiWTVQRkJFSmxXVENpZ1pWNFNRTCtlb3lKdWpmNEoyMlFuVjVNeWJlU0RP?=
 =?utf-8?B?WEhrQlJKQ1hMSUVKWi9URkZRQW5GT1BnK2NudTltWkJpUENEVFo2UTZWZ3dl?=
 =?utf-8?B?RC9ITGJZdnAxbC9lTDhwTmZhRS9OMENJWnN2UFRjMnZvZERpeU1BdDdVWnF2?=
 =?utf-8?B?Z21yKzdIcTdXT3B4NVVNQjdJSTBQUFJCZUFmT3BZOHE2Z1FNL3RuSDcxVDJ5?=
 =?utf-8?B?ZFFZTDl3Y2ZoaWh6d0hFUTE4cVRUeU8vTVlqZVptazVTa0NKRU1sNmJabSs2?=
 =?utf-8?B?a2VvY2pMaGQ1U3JjVUJNWW4vdmUydXFBQ2oxcG9peEhNSHVmUll6QnJOQnpC?=
 =?utf-8?B?Y29yUTVLd3pycUsyWVc2RG8zUnJQcGwxTXFIOWN6d1dsTHYyQnFzdzJ6emhr?=
 =?utf-8?B?QURJN1ZvOE5aQ2dzMHRISDVEcnlMY3owUC84MXhqbGpic0pwZlBnRkFvOUVw?=
 =?utf-8?B?TGdrN2NjVDg2WXp2dkZ3UUVvZzJiMkdoYkU4OXFXSTNVM09HWnV1RDRwUk5s?=
 =?utf-8?B?L0Q3ZFJEUTRPS0JZMG5QVUxjb2tRbG5tY3VrK2wzb0ZxRk03ZXdHeEtVTFBh?=
 =?utf-8?B?MC9iVGtUQVB6Tnh2VW5TamVXOEpkYjNSeTgwVVVEcFdsd1BUR3RUTjFBL1JH?=
 =?utf-8?B?SUQ0WERNUDJqNFFGblZaNDBWTzk2YmRnYkg3U0Y1NEJIWXNWYjYrV1cwNFhK?=
 =?utf-8?B?cGlJdWlIVkhQSFdSSkEvNGlhMjgyV3pqcStUY1VNOWQxRDhVcGo0cFZPRWNt?=
 =?utf-8?B?WGtrcDhydHc5MVEzWXNHM09pRnpRTjNNdVhSUkgwVDdaUzFKdlpnTGszOXFx?=
 =?utf-8?B?dG8vWWZaN2gzVGZ4YnBSQUR3S3dUM1hWL0RIR3FpMjNQZU1BVGVSaGRmK1Bu?=
 =?utf-8?B?TGZiZEhjVk56cFFCOGZZVFQxdWFFY3BqeFRwb2ZEVkNQS1Vxd1FHVXlNM1NY?=
 =?utf-8?B?aVVqN0k3ZlY5ZHlzVTY1OHlnck10UVhlSHdBbzY2eHZ4MHY2TlM4S21tZE12?=
 =?utf-8?B?Z2ZENWFVWkdwRlJYaWloTE5NZ1J1N3FndVVqUXAvYTBDTDFwRkhvWG1WM0hp?=
 =?utf-8?B?UFBKYTl3cTdKS0pucmFwV1BSWUlRSXRtMzFScGlxSU5JQ1VsZFYwMUFiR0Vv?=
 =?utf-8?B?RngxNnBUVkg0NmxLOHN5RDNtdkd6Ujk4Mmd3YzFCb3FTcVpXVjI2YU5uMWRn?=
 =?utf-8?B?SVA3Wmpab25Hei9nN3hmWk5ZZ0NKcWNCcVNaVEdmOVBzdHFIcmZZUWxNa1My?=
 =?utf-8?B?dGlOMzFIRUg2MWI3R2tFZUtlcUZhNUNpU094cm9YRVl4dWRXUE8xZWtiNDY0?=
 =?utf-8?B?RFErRTAzdVFuTkxVTGkrT0t1RDEvOUxWSVNZUjV0UG91V2xyUFB1RU4ybCtX?=
 =?utf-8?B?Rkoyd2pwZStmVVZqdlJTZzFSVmZ1VnhZRDdMcHVZN1h1RHEzVStFK2RXMllr?=
 =?utf-8?B?ZVV3MkhyUnpxRHVNdWpRb3d1c2tUVVJhaDRJenZabHVwaWRKRndkV0JiZ0hn?=
 =?utf-8?B?ZlRxcnlqako1YWJOTzJoQVUxcHlnaGlVYVZhQ0xkQXJxVjJyL3U5NDlxNGJu?=
 =?utf-8?B?MGtidTdGekJXUEJSeVpHR2FzMFY4MVVaKy9rU0JjdmZ2dGM2STBZcjlJWmNu?=
 =?utf-8?B?SE1YVVgvNVFPQ0NyOGtqcmFkbUpYdUpjR3RJdWxtSENnWDZHdkNVSlVZUFZT?=
 =?utf-8?B?Z052R2NoSmpiSzc2bGpQczlFQ2dMS1JKYkVub3JBQlZMdFRoOWtob3pDb0xJ?=
 =?utf-8?B?R2dQcFVVUzV0Q2dnTjlSV29ka3pBdU9rcFJ4eTY3aGZ1QWQycTF0b0hSQ2lQ?=
 =?utf-8?B?ckptT0tqbG1SM3JHYjNZTzh3SnVQVm1ZVkpPYzF5R2p3L1Mva2J2RGhuQXRG?=
 =?utf-8?B?cUQ4cjZZVmdiWHNLMTQyY1hOQk1lYXhMaWFONnp1bkp6bisxVDNkWi9MM0hQ?=
 =?utf-8?B?THN0Z1RRWHFXanROOUo5Rlc4OXFvbTgyd1VuWGxzQTdXU3U5WG9XM0t5SDFH?=
 =?utf-8?B?cWNkK0dBYkFFb3BET1hQOEppTVQ3S3ZIUG9OQWhMQlBTZWtNQ1FjbzRrQ01V?=
 =?utf-8?B?cFlFTUdZc0RuNVFValNNWTdJM2dQY3VIRzlqY21URkVDNTBKWmJmM29sMm1z?=
 =?utf-8?B?d3hHenBCc1lCRnhSaTYyN3cwemxYOTNaRUVIUWphUkl2NVBVMnVUenVVN0xt?=
 =?utf-8?B?eHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d52137f-b881-4c7f-595b-08db61ab7f2f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:49:00.7285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IertamohWYpMVUe/DIK1rs8ZZHa4Hwhm0Mnn8w2ktFiG4KxTdL3V8N+d+1gYGvvkERDi/7QWvdEc1Tpea1vGur6/M1n16XgiXnG2H1Rbnsg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7675
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/2023 5:44 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Drop the ACPI_TRIPS_REFRESH_DEVICES symbol which is redundant, because
> ACPI_TRIPS_DEVICES can be used directly instead of it without any
> drawbacks and rename the ACPI_TRIPS_REFRESH_THRESHOLDS to
> ACPI_TRIPS_THRESHOLDS to make the code a bit more consistent.
>
> While at it, fix up some formatting white space used in the symbol
> definitions.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/thermal.c |   13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -238,12 +238,11 @@ static int acpi_thermal_set_cooling_mode
>  #define ACPI_TRIPS_ACTIVE	BIT(3)
>  #define ACPI_TRIPS_DEVICES	BIT(4)
>  
> -#define ACPI_TRIPS_REFRESH_THRESHOLDS	(ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE)
> -#define ACPI_TRIPS_REFRESH_DEVICES	ACPI_TRIPS_DEVICES
> +#define ACPI_TRIPS_THRESHOLDS	(ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE)
>  
> -#define ACPI_TRIPS_INIT      (ACPI_TRIPS_CRITICAL | ACPI_TRIPS_HOT |	\
> -			      ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE |	\
> -			      ACPI_TRIPS_DEVICES)
> +#define ACPI_TRIPS_INIT		(ACPI_TRIPS_CRITICAL | ACPI_TRIPS_HOT | \
> +				 ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE | \
> +				 ACPI_TRIPS_DEVICES)
>  
>  /*
>   * This exception is thrown out in two cases:
> @@ -906,13 +905,13 @@ static void acpi_thermal_notify(struct a
>  		acpi_queue_thermal_check(tz);
>  		break;
>  	case ACPI_THERMAL_NOTIFY_THRESHOLDS:
> -		acpi_thermal_trips_update(tz, ACPI_TRIPS_REFRESH_THRESHOLDS);
> +		acpi_thermal_trips_update(tz, ACPI_TRIPS_THRESHOLDS);
>  		acpi_queue_thermal_check(tz);
>  		acpi_bus_generate_netlink_event(device->pnp.device_class,
>  						dev_name(&device->dev), event, 0);
>  		break;
>  	case ACPI_THERMAL_NOTIFY_DEVICES:
> -		acpi_thermal_trips_update(tz, ACPI_TRIPS_REFRESH_DEVICES);
> +		acpi_thermal_trips_update(tz, ACPI_TRIPS_DEVICES);
>  		acpi_queue_thermal_check(tz);
>  		acpi_bus_generate_netlink_event(device->pnp.device_class,
>  						dev_name(&device->dev), event, 0);
>

Looks good to me,

Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>

Also I wonder, whether I should wait with another revision of my patchset 'Remove .notify', since it will
obviously need to be rebased on top of that changes.

>