Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <026e23bc-275c-332d-ee7b-f0cbc874fca2@intel.com>
Date:   Wed, 31 May 2023 09:58:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1 3/5] ACPI: thermal: Move symbol definitions to one
 place
Content-Language: en-US
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux ACPI <linux-acpi@vger.kernel.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
References: <5675481.DvuYhMxLoT@kreacher> <2224091.iZASKD2KPV@kreacher>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <2224091.iZASKD2KPV@kreacher>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFBLWkRDbEYwQ3hIUUJGUHRCcmdmR2xla1dwZEx5UHJXOG4wSm9LRG4waU9S?=
 =?utf-8?B?ZUV5MXlPaVBOZkFEamNmQTFLakJmVUhYQ2hYSjJ2UlFLb2xyWC9MaXZuemdJ?=
 =?utf-8?B?ZUVVejZTQ2NPTjNqRm1uQ1V1cWp1RU1RWW1VKzBEcGhTOUVDOWZGS1kxZTJv?=
 =?utf-8?B?YzFyTnBXc2E1dTJvaTlPR0N4eU9hdGVCU0pRKy8vTllUdFVWSVBKSEEwK3VM?=
 =?utf-8?B?djV1anNWNk9LM0VZd2hXT1lxZzVNV3hJbi81MktHQnlETi9hVG5OdUtIemVV?=
 =?utf-8?B?S3k5bEdWSzFOSFdvcTlyUmx1ekxEVWxwM3dsay9XQ1FuR2RpNDZVRFdUdkNY?=
 =?utf-8?B?VEF4WHJ2cEdGUksvZldrbnJzeUVZbFJNU1JDazhta2xDRDNXQkkxOXhjdnFp?=
 =?utf-8?B?VG5kcS9aTHhmUFkvNFQwK3pIVHJPeXcwS2EzQWoyYklFNTdqVXpUZklnZ21J?=
 =?utf-8?B?TEhuak41NC8zMWtWRmRPRkNaUng3dXZwSGdxRGxKM0UxaWROTlVSN2ZXTllU?=
 =?utf-8?B?Y1JQL0FsR0wrOFRjTEYrWHdPK0VIMmcvcUNLSXJ4UHdTRWJ3NGlEZFFvclhX?=
 =?utf-8?B?bGVqUnR5UkZFVUdLQ0VhR1c5ZkdnN2EwQzF6UzhqQzY4ZWJ3YkZscEl0aTlP?=
 =?utf-8?B?TFZKanh0dmUrSDI2NWFQTFNyODNJZnRWM1RjenV6bld2VWRYTGlHUFI5NnJz?=
 =?utf-8?B?TmRtRzFyUlZpRFNNOXV1c2FCTFNweGk4TGpsT1d0T0pYR0llUVhlSVU4V3VF?=
 =?utf-8?B?NzBBQ2kwL2ZLTlU0TXB5R2t2VjdrZUR6QlVSalBEUW9LOUZoK0RybmFDdmZq?=
 =?utf-8?B?RlVZZm9XTzlnTndWcVZjY3FEUlhVQVlkRW5yalBVVkpHUTA2aDlVaUM5OWhW?=
 =?utf-8?B?cUxjekJzVFBJSGk1R1VoSXhJZHZDT2tTVitHQkVBemM2TmxRZWJJRXhaZXFj?=
 =?utf-8?B?R2JLcWNPWnVGaEZGNHlLM3p6Sm5pUUMvRlBURHI3UjNLL0hzaGxKdGlPU3Aw?=
 =?utf-8?B?QjlMZ21HZFhVM0QzVUtoS0dwWDdmZUpjdUhWTXZ4d2t1Mnd1SmUwWGYrWGdL?=
 =?utf-8?B?Qi9oVktFYnFqNWpjeVZuSUJmRkV4U3QyNEVIc1lpWkhRM3M2b0J0ZjM5Q0ZG?=
 =?utf-8?B?dTNVMTFJdEhKWk9aa1p3TlFBeWprRVhqMVFwcnJocWVNbG4zVzhidlE3TlQv?=
 =?utf-8?B?LzNZOXlpbWV5ejdVZHJta1BDam51TTArRWdHMWR5aFo3YjArV0VUR3FOcVhZ?=
 =?utf-8?B?d1E1d2g0aUZ6aWRjVWpQQWFlaHpkNUs4Z2dsempFa21LN1lCOWpnbmNLTkl4?=
 =?utf-8?B?YTlQdWZmaDZ2RzZBTXlqWEE5STk2LzdGN1RrT20xNzJERnJpcjR5Y0lacnVH?=
 =?utf-8?B?a1p4M3ZyUTdWSTE0UTJFVGZ3VUhaQk9zYzQyTEx4NmlrZWZWdGZRK3JJbEli?=
 =?utf-8?B?TkpKSWkzNmt2RUFjZEE0NU1ySEl5M0RxenJLUGtQOHdMdjVIOUg0V0lNeU5Y?=
 =?utf-8?B?RVhqa1FyWmVqM0haeHBnNXoyTFJKKzkySDBpRXh3Q0VlVmRYbXo5a2thQ0xH?=
 =?utf-8?B?Z0JkM0dpcXVHVDM2TStJUTNlR1hCd2FjcmlQYkRxc1Nibk0veHRWaVJDRzN2?=
 =?utf-8?B?SFlxbjBwSGlSckdLUk1OWVJRQzZXVXVocTM1ZU9HMWpyWTd0VDBoOTFUdmpu?=
 =?utf-8?B?UUZvOTdsdjV1YXh5bTJRdDBobFNlUnRKSlI5eUw0MUo0RERzblNsdjAyRDFJ?=
 =?utf-8?B?QW0wUktQLzNjcmdpbzZRaGVWTjRyTGR4Y3VwOEFRR0RpQmc0OUI4RFA0dXFR?=
 =?utf-8?B?anRGa3dWM3ZRQU9BNysydWx1Nlg4ZUNyVEoySmhTWm42RFArNXR3bjlyMG1a?=
 =?utf-8?B?VTM3U3YyTWY3K3Q2b3NYcG1ScFJHckdraUEveE9YR3JIcithUExxSTVYSU9G?=
 =?utf-8?B?YjNsSzJTVXhQY0hPYjJYOHZGTnVWS2ZqOEI2aUtjTjNlQUhoem5QeVdRdERa?=
 =?utf-8?B?YXBYWE1VVEhHTWlIUXJ6OStpckc2b2d2Yk9nR1YyeEZmT0xEK3I1a3ZsMzMr?=
 =?utf-8?B?Z3gzRXo3YUthaEhZMXd3YXVoVEdMRmovSWdFS2JPLy8wd2JNbDVlVWtHc2tp?=
 =?utf-8?B?UmhXYVJVODNBSHFkRWNUTW1KdWJ3cFhHb0p2TEx5OTF5QTJxVWk5d2dKQnIz?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d92f53a4-9458-4524-f6f7-08db61acc995
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:58:15.0455
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cutHbdgYhcj6p7aalmqf7ubKZw3V+sfnGC+Bv1MY4YiUiQ/cSO97BusD1/z6V6l0bmWUGBL6aaR0qU/jRfcxNZg5n6iiJg6v2Qh1Tk18opY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8465
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/2023 5:44 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Move all of the symbol definitions to the initial part of the code so
> they all can be found in one place.
>
> While at it, consolidate white space used in there.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/thermal.c |   58 ++++++++++++++++++++++++-------------------------
>  1 file changed, 29 insertions(+), 29 deletions(-)
>
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -40,8 +40,35 @@
>  #define ACPI_THERMAL_NOTIFY_HOT		0xF1
>  #define ACPI_THERMAL_MODE_ACTIVE	0x00
>  
> -#define ACPI_THERMAL_MAX_ACTIVE	10
> -#define ACPI_THERMAL_MAX_LIMIT_STR_LEN 65
> +#define ACPI_THERMAL_MAX_ACTIVE		10
> +#define ACPI_THERMAL_MAX_LIMIT_STR_LEN	65
> +
> +#define ACPI_TRIPS_CRITICAL	BIT(0)
> +#define ACPI_TRIPS_HOT		BIT(1)
> +#define ACPI_TRIPS_PASSIVE	BIT(2)
> +#define ACPI_TRIPS_ACTIVE	BIT(3)
> +#define ACPI_TRIPS_DEVICES	BIT(4)
> +
> +#define ACPI_TRIPS_THRESHOLDS	(ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE)
> +
> +#define ACPI_TRIPS_INIT		(ACPI_TRIPS_CRITICAL | ACPI_TRIPS_HOT | \
> +				 ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE | \
> +				 ACPI_TRIPS_DEVICES)
> +
> +/*
> + * This exception is thrown out in two cases:
> + * 1.An invalid trip point becomes invalid or a valid trip point becomes invalid
> + *   when re-evaluating the AML code.
> + * 2.TODO: Devices listed in _PSL, _ALx, _TZD may change.
> + *   We need to re-bind the cooling devices of a thermal zone when this occurs.
> + */
> +#define ACPI_THERMAL_TRIPS_EXCEPTION(flags, tz, str) \
> +do { \
> +	if (flags != ACPI_TRIPS_INIT) \
> +		acpi_handle_info(tz->device->handle, \
> +			"ACPI thermal trip point %s changed\n" \
> +			"Please report to linux-acpi@vger.kernel.org\n", str); \
> +} while (0)
>  
>  MODULE_AUTHOR("Paul Diefenbaugh");
>  MODULE_DESCRIPTION("ACPI Thermal Zone Driver");
> @@ -232,33 +259,6 @@ static int acpi_thermal_set_cooling_mode
>  	return 0;
>  }
>  
> -#define ACPI_TRIPS_CRITICAL	BIT(0)
> -#define ACPI_TRIPS_HOT		BIT(1)
> -#define ACPI_TRIPS_PASSIVE	BIT(2)
> -#define ACPI_TRIPS_ACTIVE	BIT(3)
> -#define ACPI_TRIPS_DEVICES	BIT(4)
> -
> -#define ACPI_TRIPS_THRESHOLDS	(ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE)
> -
> -#define ACPI_TRIPS_INIT		(ACPI_TRIPS_CRITICAL | ACPI_TRIPS_HOT | \
> -				 ACPI_TRIPS_PASSIVE | ACPI_TRIPS_ACTIVE | \
> -				 ACPI_TRIPS_DEVICES)
> -
> -/*
> - * This exception is thrown out in two cases:
> - * 1.An invalid trip point becomes invalid or a valid trip point becomes invalid
> - *   when re-evaluating the AML code.
> - * 2.TODO: Devices listed in _PSL, _ALx, _TZD may change.
> - *   We need to re-bind the cooling devices of a thermal zone when this occurs.
> - */
> -#define ACPI_THERMAL_TRIPS_EXCEPTION(flags, tz, str)	\
> -do {	\
> -	if (flags != ACPI_TRIPS_INIT)	\
> -		acpi_handle_info(tz->device->handle,	\
> -		"ACPI thermal trip point %s changed\n"	\
> -		"Please report to linux-acpi@vger.kernel.org\n", str); \
> -} while (0)
> -
>  static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
>  {
>  	acpi_status status;

Reviewed-by: Michal Wilczynski <michal.wilczynski@intel.com>

>
>