Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] soc: qcom: pmic: Fix resource leaks in device_for_each_child_node() loops
Date:   Wed, 31 May 2023 15:55:13 +0800
Message-Id: <20230531075513.55182-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ATwFXqEzy0YPO7KoABkuDd9+GAetoGXMBwmo15fqH83uJevbeMGqVQb3uW15?=
 =?us-ascii?Q?d+SiGwD6p3/UpaONbCKWbpBKATq9qqcNdIiUHsm0TtgJ49TmjQL0QVz86Mtr?=
 =?us-ascii?Q?hUo+T3QX5wVmvCu12uCNn4q4OljlC4j8U6bAqLuBI250uMDgB3Tc6I93VtLl?=
 =?us-ascii?Q?24/3G2SvUsyo1xM8zmhAK3XjlyXeN0rYMn7fmeZtTe7YollG9KS3W8OqZQge?=
 =?us-ascii?Q?urAxsJPx4CnuiJSYUhhuhuC4iC8d18kbZTDhsZeU7EFH2AuXYjK2vagelXxL?=
 =?us-ascii?Q?OSvozOjtpP38curCsRgQDCOnVugaR20AiuZJWmhwpxphFM8TX2oNYkTX5KhP?=
 =?us-ascii?Q?9GSUUSX9I3S1HabUExzyUNC4UG1IaiGTsxTueM1+mS/lfEt7Yx8S/7jglhAO?=
 =?us-ascii?Q?xWG+kmkEwFexBJ/hZBkUvPDV/8b7MaxA9VH9AAYf3arrr1Us2YWa7YgBF6p5?=
 =?us-ascii?Q?ZMZrCWPqKXb6YjATd58XqdSLcZGQVT4evv1Nq8Q0eGrdmYID7ZuOoVO3h8dq?=
 =?us-ascii?Q?+YX+QoapjEz5+UXcQDFOdRKaL92n3cuTwt2CeTp4prdMbEei3vqJVsd4o//S?=
 =?us-ascii?Q?VsLXdG9ZA/7gtfhfIAxxARGRQW3PpAoem3PdQ2MPlykj/VeI3oKi9QnKZ1UZ?=
 =?us-ascii?Q?GkoyzfPbyBxKrvI05qsYO6XlfFTawkWBkb500JUbHNNDXns1WTkcpPPWK+rT?=
 =?us-ascii?Q?St/S7N2oKf+ROATGPEQpX785Wjuiycxw1enhicFauvws913oYIzahj30NGpH?=
 =?us-ascii?Q?U6xC9xOZALwwXfcC5pgNGXkjmaZuVT9YapbUObqfLKewNmT4rNO1Askj0bwv?=
 =?us-ascii?Q?AXyArIl+vLXT2CL7Hre1HdJSicOJA8W8IpDmJOk11TFCFI7f2TZUhlljWSYM?=
 =?us-ascii?Q?OyEF5G+7UFesNZn23CJLCvvSE75mi7ZVI6xoobW7NIXDJDknYT1qdNcxkUtL?=
 =?us-ascii?Q?ajmDyERSpLYPq/LcE5HlhdaXQoihtg976BYwf52UNA855u3HWq8kT+ZaNovG?=
 =?us-ascii?Q?7CDFEfr3JLE5C2tPCsLaeriOBva5FwtTdt+SFrHsSCcHHHdzWhOmP5tvOC7Z?=
 =?us-ascii?Q?WQBAa//37RdRq+VsnkdlbpQU+ZsPlqnfkifZE5ERKOpohrT71Gt8jaeDLFy8?=
 =?us-ascii?Q?7XrghFr7wooSWVdcXy7xg9UW4c4CQU6MQjFNDSs9MLfhUksv5IYyqfseEVwr?=
 =?us-ascii?Q?N75pFpI6dZ7+/lj4YPPtbZ+pmlVjMqNXD3t9quRLc+g+Ijkozba0dUpFWmPh?=
 =?us-ascii?Q?iVok52VLrYrvSTG+APbDkMnKEt0kw1BaWf4CHuXlW6eecy0NUGZ7ZRM5H3cQ?=
 =?us-ascii?Q?qBnD0KEMZGKHfNHBGT9V7DyW6j6s9rRseafMfV5W+mDdz+snCpolwoYmyUxN?=
 =?us-ascii?Q?lk2bGNB89lvNQmQKcDeE0NE6AAaPAe3A8xbJcnwiwn/fFQDxJq3y1kUfF4G3?=
 =?us-ascii?Q?Bm5C0w/fNs4lc4HdNJ1zVfX88NbMygOmyUS93rapcyRI3SUa4vRj4jacRKk8?=
 =?us-ascii?Q?9iibAwtA222ysbVKyuO4+SIVra+7XQMurl3CcZ3+pwPPch75M76wIOLIgqvO?=
 =?us-ascii?Q?6ycCruVgVc8H5sQg/4aI9uew+EHeel0/H2zEGy5m?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e06a9905-e936-4c99-f0a6-08db61ac6314
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 07:55:23.0164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +SOWLCXGby+H9+0Bx7X+XlFD0q05cgAN5P3YyuQs6hHaeCBNUcVmIU7pZt9gE+k16hiIctgPSIEyNIyZDdOCjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5551
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The device_for_each_child_node loop in pmic_glink_altmode_probe should have
fwnode_handle_put() before return which could avoid resource leaks.
This patch could fix this bug.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/soc/qcom/pmic_glink_altmode.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index df48fbea4b68..a7fc6570fa1e
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -395,7 +395,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 		ret = fwnode_property_read_u32(fwnode, "reg", &port);
 		if (ret < 0) {
 			dev_err(dev, "missing reg property of %pOFn\n", fwnode);
-			return ret;
+			goto err_node_put;
 		}
 
 		if (port >= ARRAY_SIZE(altmode->ports)) {
@@ -405,7 +405,8 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		if (altmode->ports[port].altmode) {
 			dev_err(dev, "multiple connector definition for port %u\n", port);
-			return -EINVAL;
+			ret = -EINVAL;
+			goto err_node_put;
 		}
 
 		alt_port = &altmode->ports[port];
@@ -420,33 +421,37 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		ret = devm_drm_bridge_add(dev, &alt_port->bridge);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->dp_alt.svid = USB_TYPEC_DP_SID;
 		alt_port->dp_alt.mode = USB_TYPEC_DP_MODE;
 		alt_port->dp_alt.active = 1;
 
 		alt_port->typec_mux = fwnode_typec_mux_get(fwnode);
-		if (IS_ERR(alt_port->typec_mux))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
+		if (IS_ERR(alt_port->typec_mux)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
 					     "failed to acquire mode-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_mux,
 					       alt_port->typec_mux);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->typec_switch = fwnode_typec_switch_get(fwnode);
-		if (IS_ERR(alt_port->typec_switch))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
+		if (IS_ERR(alt_port->typec_switch)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
 					     "failed to acquire orientation-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_switch,
 					       alt_port->typec_switch);
 		if (ret)
-			return ret;
+			goto err_node_put;
 	}
 
 	altmode->client = devm_pmic_glink_register_client(dev,
@@ -455,6 +460,10 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 							  pmic_glink_altmode_pdr_notify,
 							  altmode);
 	return PTR_ERR_OR_ZERO(altmode->client);
+
+err_node_put:
+	fwnode_handle_put(fwnode);
+	return ret;
 }
 
 static const struct auxiliary_device_id pmic_glink_altmode_id_table[] = {
-- 
2.39.0