Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp531985rwd; Wed, 31 May 2023 01:38:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ64z7ARoPi7U84e+LT3DDRvyHk4hdwog4E6kKt7P6DhNHrfoHZnyDKpIyLZ0G1OmjhofPy1 X-Received: by 2002:a25:d24b:0:b0:bab:cd90:87be with SMTP id j72-20020a25d24b000000b00babcd9087bemr5595699ybg.51.1685522320097; Wed, 31 May 2023 01:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685522320; cv=none; d=google.com; s=arc-20160816; b=o3NsmjnyrigCKQEmFwvLo5+SXh0fyxAL9frCftHeorg7enDap7ee06cYmcxtjbDLAL FfheLKZiBqe8w+E+80uyqurvv5gAd4HBrCpO/ExXNi8awSOQ0/AS/Hs1RYsY6aQWH6zP mnjpDqSZDZYKgciEsr634gerbPvWencom7RMsHDHDVvp3Ju5rGN05zfX3qwOcRoxTYpR rd2rXkqb1dAtE4eSTn9lfcAvuMbGBDYGVn6VrvIMyDCKMdk6Q+FdmYT/Y8CPDwC/C68D I8uwj4uIt7zXbcMFUjr9FfBl1BVRcGXu8CbkxAWBZeDMgUHrKpWmbnVLViT/S4ChUuBg /ExA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=WjVw2+3UIqg/C7RI4A2Dte4NnpZKfMDxLM/or0Jjru0=; b=H9tJiaWMseYCRii4r9F6EIHCQQI7XAA25E/b3j63K6qr6DbMd9z5qg4SJMYUIRVvBm qOaD4gVmqLJPNy094LX+d0rxhPkAIGfZgYEL8b6Pk4IL7qZWPvIQBXBaXmQ4HSfoMulg dQwuvhHqKOal7i9GvctGvO6FxNVDZw3i6jlVv6U+U+jFlTrIByMsgyrGH1B0hIhCaCpd bDJFlMErqEwMoaB7QL2LuMzeMsIlxbDGxsCenvZJ16tg2NdR/OyY814bwPRug7owWwPm Jx3thmyuqlqB5iw2NPb3lVRO6adBw8KZR/wfO89DdHXx3G/oc+pYN1SAetL1v6MS/Crz IQiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FhF29Dom; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a170902c40700b001b176ba9f1asi494736plk.551.2023.05.31.01.38.28; Wed, 31 May 2023 01:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=FhF29Dom; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234954AbjEaIZX (ORCPT + 99 others); Wed, 31 May 2023 04:25:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235277AbjEaIZI (ORCPT ); Wed, 31 May 2023 04:25:08 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D822F99; Wed, 31 May 2023 01:25:07 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab] (unknown [IPv6:2001:b07:2ed:14ed:a962:cd4d:a84:1eab]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 12D9B6605840; Wed, 31 May 2023 09:25:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1685521506; bh=1aF/ujhueME6nmzpnzqxi8tyyhgx1bzMbLCCVhzmmro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FhF29Dom6kf+vxi5Mwx18c7tyyeDjQ0aXX7AEKH/9Fatul1QgqSjWjvcueJkQNSxq 1/AK+qg7K3RQTiQ+SNXplQomxOs1Ff6/BPVNBr1hXnWtVBchmUqvOGYOK5jP7f7ZIS i7p+dBDtFmg3IELg3IQ6n/s3MCfkbl7c1KA0O4EhdnMwNZK9ii9WJutUDnlx6n+Kc/ lbsKvB8xNz0AOxUzOIwcPfVI6z2BqWlEPlRHPi/t+BhNjQEs6A11E/TH/cK4QgC4Zm wZBHypXXE41b9oQDgwJ7kWaejiEzFpTHajlaYyzI32+4kjIXV8uZqUwYEHXy0+4p5c /pQQaSVVH6tMw== Message-ID: <0f75de5e-db68-6ad7-3176-f8143f0df922@collabora.com> Date: Wed, 31 May 2023 10:25:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp_pwm Content-Language: en-US To: Shuijing Li , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jitao.shi@mediatek.com, Fei Shao References: <20230531031001.7440-1-shuijing.li@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230531031001.7440-1-shuijing.li@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 31/05/23 05:10, Shuijing Li ha scritto: > There is a flow error in the original mtk_disp_pwm_apply() function. > If this function is called when the clock is disabled, there will be a > chance to operate the disp_pwm register, resulting in disp_pwm exception. > Fix this accordingly. > > Fixes: 888a623db5d0 ("pwm: mtk-disp: Implement atomic API .apply()") > Signed-off-by: Shuijing Li > Reviewed-by: Matthias Brugger > Tested-by: Fei Shao Reviewed-by: AngeloGioacchino Del Regno