Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 10:08:28 +0200
From:   Lukasz Majewski <lukma@denx.de>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexander Duyck <alexander.duyck@gmail.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Subject: Re: [PATCH v8 2/3] net: dsa: mv88e6xxx: add support for MV88E6020
 switch
Message-ID: <20230531100828.3f0a3200@wsk>
In-Reply-To: <dd68b82b-7bb7-3f4f-7243-e3a4b745cd97@gmail.com>
References: <20230530083916.2139667-1-lukma@denx.de>
        <20230530083916.2139667-3-lukma@denx.de>
        <dd68b82b-7bb7-3f4f-7243-e3a4b745cd97@gmail.com>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/KuUStryJVJf1l7OpeRAR0j6";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/KuUStryJVJf1l7OpeRAR0j6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Florian,

> On 5/30/23 01:39, Lukasz Majewski wrote:
> > From: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> >=20
> > A mv88e6250 family switch with 2 PHY and RMII ports and
> > no PTP support.
> >=20
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch> =20
>=20
> > --- =20
> [snip]
>=20
> >   /* List of supported models */
> >   enum mv88e6xxx_model {
> > +	MV88E6020,
> >   	MV88E6085,
> >   	MV88E6095,
> >   	MV88E6097,
> > @@ -94,7 +95,7 @@ enum mv88e6xxx_family {
> >   	MV88E6XXX_FAMILY_6097,	/* 6046 6085 6096 6097 */
> >   	MV88E6XXX_FAMILY_6165,	/* 6123 6161 6165 */
> >   	MV88E6XXX_FAMILY_6185,	/* 6108 6121 6122 6131 6152
> > 6155 6182 6185 */
> > -	MV88E6XXX_FAMILY_6250,	/* 6220 6250 */
> > +	MV88E6XXX_FAMILY_6250,	/* 6220 6250 6020 */ =20
>=20
> =C3=BCber nit: only if you have to resubmit, numbers in ascending order.
>=20

I hope that v8 will be the last iteration :-)

> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/KuUStryJVJf1l7OpeRAR0j6
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmR3AHwACgkQAR8vZIA0
zr0ziwgAsgmaxJ2Kf6VzDlQZtAa1xjjVuuhFXpuqSMx3oF6IXJMsm8Wd3Au+Drt8
We83e2pK0DTOKy+L5GaFwmW4rA6cAuK867XJeOPgQCABP8v2N1DVGxtFVJFAGiaZ
+FFjGbst1D8DM1jLQra278VCYjUmnQQdD8ae8iqeSuJLRUoCBZUa5Y4+Q8amRybP
qE+Nu8gSOUgVw+8nmkV+P/K+sVyRR7HGgifNQCLl2u5EeNjrWMAsFgZEqRI8NUUE
CBmVj44mzLeWEyuxUos7osxQ86lImI5ZZNDAe4D8t9g6Dgls2TY8DFCakMu9EOxK
rppGFFweVvo9SzNB78LbDTLcngw67Q==
=jEBG
-----END PGP SIGNATURE-----

--Sig_/KuUStryJVJf1l7OpeRAR0j6--