Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp552915rwd; Wed, 31 May 2023 02:02:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6EEEClVl2Th38SyBWoiQMzMYn62Vb9jNohKFR0PQvt9+qMp7FuQhewVsb2Ri6eiKyIz+av X-Received: by 2002:a05:6808:2888:b0:39a:55e5:c437 with SMTP id eu8-20020a056808288800b0039a55e5c437mr548942oib.21.1685523749743; Wed, 31 May 2023 02:02:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685523749; cv=none; d=google.com; s=arc-20160816; b=oF1kcZa26uEl6TiK7JqZXmw0wLqdrOm7SaSNgqjKqwwBCCLKQe3NR0PeWOPFrn8lJD X791mp9NC3nP/BkSo0xDDQQbrPybx3qx0ivO/ccpPk6kb0FLrinYvRHWTYdR6qwE7xZ3 BddZAoJMDUpszuoKRvYsXqUzWTYGvtvmOaeAFDs4mhz5NnP3cULDjduk6TMpfsfypJmc y6Wj9/9PwNO+AAM1ZvKcB4C5hDWxLP5uNiT/nK0HT2PvnGY+t+S3WLSTHrcwFXvv4aYG jv+R54NHf9V3qfr5urwh1QSZ2kcAVccbxsOY1vfBwHcq3s5tdLxQBxk0vNWrD4aXB6ep uZeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=t64Hzu6zM+aWHS7TdPfza23+IuD8Tjx7jNFzWlii980=; b=wFCZcAFfFlVPq5dh8KbX9S9V5hVOzZyPOb7EV7XS38UrYI0K6Y+mD//XDbc1zVLXce A+mnseBmzKfi6E6jz3M7D9U6cDg0Nh2nYEv6stb0j0kjoIk4CrbRhtIFAEFAdLlR/XpD kG0/1qIHpyi5L/j9vFni7tTmyW00CqYkG51ERFr1R7i7LJXIDlm0SSQA2by6Tnv9i7rH a3u/xaSCkkiXo5AkwteKBUt/IVLHAXguFPBDGuDVOpVpGup80RuANfZCR0XSob2DMPWd 68liSHKTCgjwQMYfdFpvS0E8SKut9WKkhaJc/O6HpqQVfFzdIIhr6NsWp1FEJBSZOAEx kAHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v3-20020a17090a458300b0024e4ace1a41si552051pjg.183.2023.05.31.02.02.17; Wed, 31 May 2023 02:02:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235200AbjEaIrl (ORCPT + 99 others); Wed, 31 May 2023 04:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234424AbjEaIrT (ORCPT ); Wed, 31 May 2023 04:47:19 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AB78611C; Wed, 31 May 2023 01:47:08 -0700 (PDT) X-MailGates: (flag:4,DYNAMIC,BADHELO,RELAY,NOHOST:PASS)(compute_score:DE LIVER,40,3) Received: from 192.168.10.47 by mg.richtek.com with MailGates ESMTP Server V5.0(746:0:AUTH_RELAY) (envelope-from ); Wed, 31 May 2023 16:46:54 +0800 (CST) Received: from ex4.rt.l (192.168.10.47) by ex4.rt.l (192.168.10.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Wed, 31 May 2023 16:46:54 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex4.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Wed, 31 May 2023 16:46:54 +0800 From: To: , , , CC: , , , , Subject: [PATCH] dt-bindings: power: supply: Fix rt9467 charger enable gpio active level Date: Wed, 31 May 2023 16:46:53 +0800 Message-ID: <1685522813-14481-1-git-send-email-cy_huang@richtek.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ChiYuan Huang The RT9467 charger enable pin is an external signal that used to enable battery charging. From the datasheet, the active level is low. Although it's already configured to logic low at driver probe function, but the current binding example declared it as 'GPIO_ACTIVE_LOW', this causes this pin be output high and disable battery charging. Fixes: e1b4620fb503 ("dt-bindings: power: supply: Add Richtek RT9467 battery charger") Signed-off-by: ChiYuan Huang --- Hi, This patch is to fix the active level for charger enable gpio polarity. Currently, the wrong active level makes the user confused and unexpectedly disable battery charging by default. --- Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml index 3723717..cdc7678 100644 --- a/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt9467.yaml @@ -69,7 +69,7 @@ examples: reg = <0x5b>; wakeup-source; interrupts-extended = <&gpio_intc 32 IRQ_TYPE_LEVEL_LOW>; - charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_LOW>; + charge-enable-gpios = <&gpio26 1 GPIO_ACTIVE_HIGH>; rt9467_otg_vbus: usb-otg-vbus-regulator { regulator-name = "rt9467-usb-otg-vbus"; -- 2.7.4