Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] soc: qcom: pmic: Fix resource leaks in device_for_each_child_node() loops
Date:   Wed, 31 May 2023 16:54:21 +0800
Message-Id: <20230531085422.4963-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HXdrksC6Sdf1EndXIdZq42c/C83B6xbOtZp5gTUd4vdpSQ5hLHbcvCzzgDwg?=
 =?us-ascii?Q?ZJngYeE50iG/9k9KOeSjxbl4j35j4mOkAgz5lSpAmT8wuHEBjJENQoqEdBbr?=
 =?us-ascii?Q?f4gJr2FQPSuHabvEt/eBd9wTvKbxxkkRbk6gG0JQcFtv0ysZDQWyVhKFvRjc?=
 =?us-ascii?Q?DGL1PpuT0s7UHMcFGE/MHIjjpVyiOUOj3XKfOb5YdOY72cR5D33xk3Zb0maF?=
 =?us-ascii?Q?GChSUGF+B7eytUqkwORnC/Gkyd6Mr1aVdsEFjYu1G1PbYESeSX7ClQL33D4p?=
 =?us-ascii?Q?iXtQgoimcfAcLLo65xnaAuf6fvAeinVY5mU0fXLW0R8yfpsd1IdmN40CN1+1?=
 =?us-ascii?Q?v7X+HNzbHVbuIGJpHyAYiP8AMXpr5hJGeJ/cDzqaw8kn4KfuKWKwSsjxb8EK?=
 =?us-ascii?Q?rKJX3xjRTkvPOWAX61KJOcTjvBvbC1OOJ07/5j5zn48TRkMa+bExNRfaLbHG?=
 =?us-ascii?Q?Vn7JODfxvQsBlWZualTfDIFCdNvzDzO2/G4uuyMr9tHdpsuXCd+C40E0sEAR?=
 =?us-ascii?Q?U21NnzjJ79HODd5hC6mfC7T2VIJ8ktJP+AE/UmkcWem2244JDmCzFRkmOYO8?=
 =?us-ascii?Q?qNXisPKHhYHA0MdGGXLiFB550tw+0n5w/eWcp0vMFvgGDk1hdfn+5bjvYVed?=
 =?us-ascii?Q?shWXNM3CjF5X70oV6kzSW++SA0zq0NcOzmuI+8NOfniONUSQSbbyw7XmZ38g?=
 =?us-ascii?Q?4RmVzSxRaPE9SG433VX1ngc+209VINxBC5V8vujGADW1EQ9I+NjHoaQzx2i5?=
 =?us-ascii?Q?LH+SYk5sApjkoKq9UbVmkT8rVOuTYrTY17hZUrSYdwg1Sr0Sx/HeOSS7ASUK?=
 =?us-ascii?Q?ARX0131NpBcYfkexnYP6h2r5PSnrqoM5PtdZIXR2iwxqqoNUK4ydbiN4Jz8h?=
 =?us-ascii?Q?WrcM7WxrVKgudNZYYXwW9z9b3LH1H8nNIHYsN8tzZijwLtkk74IyhL3IGqLb?=
 =?us-ascii?Q?L401l7Nl8CQzz+nHUQFCty2AI7E3NJPj8UuyKHofnKBosguCmWmoMpZ6XOSa?=
 =?us-ascii?Q?TbiIt4qbq0iHgTMvY5r2/loRhMCkjcjyG2F0usUz+B95IGytPx5pm2M28DLx?=
 =?us-ascii?Q?uxBCOZ0VX4zgfyUuTkIvw1dbOmlu6XawAA8EKeWjD/B7b7Dby0X3ahCCD11F?=
 =?us-ascii?Q?lmv5L35jvFkWsk97/BIqrENdXThXO6zsYVXB9EJ/d8kYfYbuMNb0q+4u28tB?=
 =?us-ascii?Q?Sw7zFO5alXX6AfAXjOL5JgFzwS0+OUTUuEVM1ckKmupwaK2+aCft7iuHmNJJ?=
 =?us-ascii?Q?//oh/Vc48SUZMT71KZvxOaXowZBg14jQq6TUfA0Z3YwyGmNumHGlbDYaDdVC?=
 =?us-ascii?Q?9dw7QY+8WSc6EsU+EQP54x9IuTExPUvVIuMAJSuwBXglFAe3MJdYEp/HrY2i?=
 =?us-ascii?Q?XsnVb40bzmKYj7Ag3fLFbaCt7baWyC6lqldn+NBlquif/uaMuXaWK46+uAYv?=
 =?us-ascii?Q?EKgiG58xsbB/dJBQ/u4gk9gCp7NlLu2BVBqCuW/4Rf8gTt8m6zL3og8eRw0A?=
 =?us-ascii?Q?46/VYow3L7e0laI3PQBL20lKFehFVLFQFKWGP8sYs8/nBu3DVg3exvwnYepm?=
 =?us-ascii?Q?2s2PGBQYWROM0pYxcpVVdpsZJgMBbOzgEdHHJ/JV?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 181daeb8-dab9-47ee-9210-08db61b4a5fd
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 08:54:31.3151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p3YCtoZtyZ28Q9J1qKAbU1ZnoqDZ64giuNW3E4/6WSbymCp0d/SxyxSBArpK05Dd3Y5jit4/4L5/GpH6xpw8Uw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4436
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The device_for_each_child_node loop in pmic_glink_altmode_probe should have
fwnode_handle_put() before return which could avoid resource leaks.
This patch could fix this bug.

Fixes: 080b4e24852b ("soc: qcom: pmic_glink: Introduce altmode support")

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/soc/qcom/pmic_glink_altmode.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/drivers/soc/qcom/pmic_glink_altmode.c b/drivers/soc/qcom/pmic_glink_altmode.c
index df48fbea4b68..a7fc6570fa1e
--- a/drivers/soc/qcom/pmic_glink_altmode.c
+++ b/drivers/soc/qcom/pmic_glink_altmode.c
@@ -395,7 +395,7 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 		ret = fwnode_property_read_u32(fwnode, "reg", &port);
 		if (ret < 0) {
 			dev_err(dev, "missing reg property of %pOFn\n", fwnode);
-			return ret;
+			goto err_node_put;
 		}
 
 		if (port >= ARRAY_SIZE(altmode->ports)) {
@@ -405,7 +405,8 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		if (altmode->ports[port].altmode) {
 			dev_err(dev, "multiple connector definition for port %u\n", port);
-			return -EINVAL;
+			ret = -EINVAL;
+			goto err_node_put;
 		}
 
 		alt_port = &altmode->ports[port];
@@ -420,33 +421,37 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 
 		ret = devm_drm_bridge_add(dev, &alt_port->bridge);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->dp_alt.svid = USB_TYPEC_DP_SID;
 		alt_port->dp_alt.mode = USB_TYPEC_DP_MODE;
 		alt_port->dp_alt.active = 1;
 
 		alt_port->typec_mux = fwnode_typec_mux_get(fwnode);
-		if (IS_ERR(alt_port->typec_mux))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
+		if (IS_ERR(alt_port->typec_mux)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_mux),
 					     "failed to acquire mode-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_mux,
 					       alt_port->typec_mux);
 		if (ret)
-			return ret;
+			goto err_node_put;
 
 		alt_port->typec_switch = fwnode_typec_switch_get(fwnode);
-		if (IS_ERR(alt_port->typec_switch))
-			return dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
+		if (IS_ERR(alt_port->typec_switch)) {
+			ret = dev_err_probe(dev, PTR_ERR(alt_port->typec_switch),
 					     "failed to acquire orientation-switch for port: %d\n",
 					     port);
+			goto err_node_put;
+		}
 
 		ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_switch,
 					       alt_port->typec_switch);
 		if (ret)
-			return ret;
+			goto err_node_put;
 	}
 
 	altmode->client = devm_pmic_glink_register_client(dev,
@@ -455,6 +460,10 @@ static int pmic_glink_altmode_probe(struct auxiliary_device *adev,
 							  pmic_glink_altmode_pdr_notify,
 							  altmode);
 	return PTR_ERR_OR_ZERO(altmode->client);
+
+err_node_put:
+	fwnode_handle_put(fwnode);
+	return ret;
 }
 
 static const struct auxiliary_device_id pmic_glink_altmode_id_table[] = {
-- 
2.39.0