Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Artur Weber <aweber.kernel@gmail.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org (open list:DRM PANEL DRIVERS),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] gpu: drm/panel: Optimize the workflow of s6d7aa0_lock
Date:   Wed, 31 May 2023 19:07:17 +0800
Message-Id: <20230531110717.36896-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aUysZ0NyWFg82v0qiNMhBGL4QoY8lVMa8b+2fd8W+HUZIT9c/ZDp0F1jEYAi?=
 =?us-ascii?Q?Iz333F11wfSsWUXIvBiJPYG68Xn2eb1tN1SCy7MmMouyLzKohz2oZrjHDuht?=
 =?us-ascii?Q?XqPinNMxLZWmnyD4r0Lgpt/nm7vijySNEG0tDtYXYONBG2xBWzdwdMeXucXS?=
 =?us-ascii?Q?vDJz9vUMwPdBiTmBQqE6xKj+69ivmmCDkCojExRyoab0Uf91czQ+LUPMEk19?=
 =?us-ascii?Q?KzKm2+4egLloYDhwVCmUQ9k2bAhSdenTavoYtxgy6K8DSmdfIm5404eOwaoM?=
 =?us-ascii?Q?+1zQxUB1cKO5xF1dTcRw0Omo+ns4Bondpeb9Lh4O0czEMm6a1tGlcO0j+Ur9?=
 =?us-ascii?Q?t1Oji2LpkX9QOv6k+q03Al0EnFT0XyttuPMOjRFDrLbAO4KIZdzXfXlzSpbK?=
 =?us-ascii?Q?2Pxg8k3C2X9DC6X3FzHn55ujZ4dR2LDmrENylX4NuGT8lYin0l1ximlNFxRG?=
 =?us-ascii?Q?v939B3fCyRwN1M5U7ibBRNW4ha7eQi/BPioqLZWPP3xuAy2kS0yLt4n/i22f?=
 =?us-ascii?Q?j7T2LpfK4iIbreYR+styoPjPTSb5wdMDwR7gUen9ivCL6xOdwz8zVrgSXjuS?=
 =?us-ascii?Q?MC2vTcvTatzdhzXfqUoRrXZ5uT784t/bK2V/06UhnZEHIZ+aNkvSfjfB/bZu?=
 =?us-ascii?Q?CWVtvzrw0fZ/ClH+T+MYUwKr3Uz+3KLUdVWgFLgQNXXnKZ7CZI/4TJa05biF?=
 =?us-ascii?Q?xhGyNmteY15jc0xvvbwYJDEXxxDt6UPubtvDwhzszv98UhWYXJiBu+vYHB49?=
 =?us-ascii?Q?TVjA3N7i27Gk6DFQLpW7I5zCTyyjzCUcntTl6t4CV+pFvaf7IPvcWsB8znw3?=
 =?us-ascii?Q?ulmHIfIEgofXYrsVkZGD46WrasKP+Xm0QQA4amEW8DQZkzSeEO3LWJXlpZbR?=
 =?us-ascii?Q?nmrHHSCc1QREGSGpdQweVIphDoFJjtGPTFW+d7mxuRqUr1X2nK3LjIOc6wzy?=
 =?us-ascii?Q?6w+M/1qaDXPY8CKMjsDImHyIbzmIEz9KCXEHB69WDNuczLHeKzoxp/ul0wrM?=
 =?us-ascii?Q?zemKpLb8/g3R8CfxQx5nzA/FCSlk9x1xDCoR4NDtc5EbsHrT3w4iaV70Wx+G?=
 =?us-ascii?Q?hli0h3iFGyQ6Ci8BzPH3oNDPfdeeKkuA4xM5E7hIctt76ZmlMwYsXt1q32nG?=
 =?us-ascii?Q?iV3aQ56P+JDU2IeSnc1PrQfYH0+9LgGYziBOEngsHE4SxZn2cVQzUSeDGSdD?=
 =?us-ascii?Q?3+/twML4iCOd0dCkv2Rn/TjGSCbqsmMZ5DAFm0njxfLxsSz25PB1UhZb80CG?=
 =?us-ascii?Q?uoLtd36CN1J08QtqrhoV9zB0hrWnSPKAQ55N7YONrMAEskCxXexfET+IfssW?=
 =?us-ascii?Q?q9eCYQZUIQzZKVfhcUlpFfW5YPcaqTRm/GahxgDCWQoxn6EuBLQxj3fc3Qxn?=
 =?us-ascii?Q?xQiF26+GXfUakaWoVpZtxijHeGXLt9tiMOE3rIrFJwKUQ4X1QuxDqUeMkSD8?=
 =?us-ascii?Q?L64YOZKr/WVDjKCXxVyCWPYSdJl5aUJnkGygDKEZoXK/PU0gtlaZ3GKgdvUX?=
 =?us-ascii?Q?cYuxab6P6scZ3gWD/oRJXr0eoXQ6lGGuqoArj64FgR/mohLJR3mxxL/MA/Dy?=
 =?us-ascii?Q?XQGK08Xg0UJQegRW4NmMXpOP4xCs2qfLA88eJ/MW?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 571ba621-1a20-4a75-9797-08db61c73797
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 11:07:26.4203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WxZfCDty5HzlxVU2Zn+Z9l1ARgf6DmkpazMQUmnjH8aBo62rvqD/L/CDadcxrgkWNP5eMBk9X6PFB+cT2S1EuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB5075
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch optimized s6d7aa0_lock's workflow.
Once mipi_dsi_dcs_write_seq failed, s6d7aa0_lock return immediately
and no further actions will be taken.

Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 30 ++++++++++++++-----
 1 file changed, 22 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
index 102e1fc7ee38..f98df32d1c55
--- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
@@ -69,15 +69,29 @@ static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock)
 	int ret = 0;
 
 	if (lock) {
-		mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5);
-		mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5);
-		if (ctx->desc->use_passwd3)
-			mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0x5a, 0x5a);
+		ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0xa5, 0xa5);
+		if (ret < 0)
+			return ret;
+		ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0xa5, 0xa5);
+		if (ret < 0)
+			return ret;
+		if (ctx->desc->use_passwd3) {
+			ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0x5a, 0x5a);
+			if (ret < 0)
+				return ret;
+		}
 	} else {
-		mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a);
-		mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a);
-		if (ctx->desc->use_passwd3)
-			mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0xa5, 0xa5);
+		ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD1, 0x5a, 0x5a);
+		if (ret < 0)
+			return ret;
+		ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD2, 0x5a, 0x5a);
+		if (ret < 0)
+			return ret;
+		if (ctx->desc->use_passwd3) {
+			ret = mipi_dsi_dcs_write_seq(dsi, MCS_PASSWD3, 0xa5, 0xa5);
+			if (ret < 0)
+				return ret;
+		}
 	}
 
 	return ret;
-- 
2.39.0