Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp704654rwd; Wed, 31 May 2023 04:25:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ58CLBzWWIq5oUg+Uwr3AtbrbzYLGh1+jwJU8zfnDDMO/8//kva1fxWfT0KwtW4omHpSHXQ X-Received: by 2002:a17:90a:f2d8:b0:256:540d:b54a with SMTP id gt24-20020a17090af2d800b00256540db54amr13209343pjb.8.1685532314084; Wed, 31 May 2023 04:25:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685532314; cv=none; d=google.com; s=arc-20160816; b=VjFYZQtou9ipNCt80Es1y5G1g93jiCC6mmOrlRZNxwTxnUyTGHB17A6tzkQAAlEeG5 dnyjKZ0DosusU7pHqzMFfkJvEQ/4NiCbxGvIP8r0zYFHBQS109oGJgYWbATkNL6HyrU4 aFUgXd/sPhGu/uATHNgoWo3bxJ7DEyCr6hOM2YITKjfthEzmPHT0HfHZZrc+EKs+Q6fr IhTq8lqaottK9uQBsXIgi3M0p5eUNi19dt0a/f3VLFPTHbHmxoOIGOnutEnCufkKAcE1 yFZivx9bctobpJDrB3A5F2Js2w0Op6DYkQ1FWNTb+jEF7J/edSgE0eGCgZkzNF5BXKo5 KcYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0mF96JxhPOfJm8OwVPyiERGBu/9SGI9YEMVv93ttrAE=; b=RZETFqIyz+PYxe30tYQTh8Hij/1hyVJJhL5VkXNaJS79nsbyja6nxZ4f+VJYxE0axn Z2PgAUQ0G87TtK2HzTud5LN0UQbp9Ip3hciw8F4DdGxbnW8csMtcH1ZpC2dABrX6bcyg HEhI5tFttg3PV3rJRY34BGCZsJJKwY+G5f5UJle0FyWP0rprTCWExC6IFVpTnRVGMufj 4tRdtEp8cO0IHgJy/T0JbOXLhNKESatdfpEcjZrXeoVwDShNCT0Y+hgbBVAg0lD2J2+s yMMmVO9YlFtQAtoZ28MAR/UXqAjQti6pdpEn8wJftq2Ks7N8crfmsk85dCoZ0ssOQcyU qEqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="K7S/m1yN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fh5-20020a17090b034500b002568322e3d0si846585pjb.34.2023.05.31.04.25.02; Wed, 31 May 2023 04:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="K7S/m1yN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235002AbjEaKxE (ORCPT + 99 others); Wed, 31 May 2023 06:53:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbjEaKw6 (ORCPT ); Wed, 31 May 2023 06:52:58 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D08188; Wed, 31 May 2023 03:52:54 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4f4b384c09fso6653783e87.3; Wed, 31 May 2023 03:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685530373; x=1688122373; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0mF96JxhPOfJm8OwVPyiERGBu/9SGI9YEMVv93ttrAE=; b=K7S/m1yN1z3wihwPQ0aqTmA8KTPkPzoE4oY+Og9RwgyPhTsaOBXcjY7r2d300+ffca kOLeizWVKQ6nVthj2EPf0aJSFkNGa5KAe4B/un7+eBje/DITcVV0Xd5UdvKMOLqqrGFX 1nOc6HcrUAFNIgZ4xd7xMUq4iLmwXgB3yDgc3N54GWlOER/f3wHDaTO3QojJ+oI7hTBl msvwt1w7DAy76NtRu6/dGzXXgPoXKFpCGf1/PJXnx7Hzen6p/OuP/cavKe1B8J8U5Fzc ZK3qKnDWhNH2Jde/ntE9HFFV5CpPfgJ8ohZT/gvfjPORjo6CLoEgR+hffPq2q9Y/lnC9 hiRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685530373; x=1688122373; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0mF96JxhPOfJm8OwVPyiERGBu/9SGI9YEMVv93ttrAE=; b=OQLoEXiDAiGBnKweHT+Ngl/q4Apt7qML3ms8YfeWnhwR4QIPZgfHmao/mSCOXlWA6y 7LXhA596P5TBgc/OXFU2zZs+yU2xQ5QXBk+Yjh5VwxgYeQDYHrScsJxRogyq/lNYBAHU I2KZ8g+SFgDS9uy9LsJ2USVgdO9rjGZSXT7ifeUyUm4oTU4yJ8vBk8kZJ4XDLupvJXD8 3qDv0TpjOVoeSxoBJewIZSpzJdHi7XCKOMs1X/kxWlRm55f0MByX8KJ8oB/sk2QZQtXx RjOTW8orMBTtrdixrgavMLPzzkJvQpk+h36UW3pJzG1vSW3/xCd2p+ZKE/T+JQduNP06 G1xQ== X-Gm-Message-State: AC+VfDwaLfc6old6+wXBhGm956uIVJDKMhO3FfiRK5cYgRvmqs9kLmmL B8xLLyoGVG3A8Hu8yFYCqljuxgklbLg= X-Received: by 2002:ac2:5605:0:b0:4f4:ce78:2f17 with SMTP id v5-20020ac25605000000b004f4ce782f17mr2316420lfd.13.1685530372868; Wed, 31 May 2023 03:52:52 -0700 (PDT) Received: from mobilestation ([95.79.140.35]) by smtp.gmail.com with ESMTPSA id z27-20020ac25dfb000000b004f13cd61ebbsm672102lfq.175.2023.05.31.03.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 03:52:52 -0700 (PDT) Date: Wed, 31 May 2023 13:52:50 +0300 From: Serge Semin To: Mark Brown Cc: Osama Muhammad , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] spi-dw-core.c: Fix error checking for debugfs_create_dir Message-ID: <20230531105250.6pd5jpngwbnbnbbc@mobilestation> References: <20230520224025.14928-1-osmtendev@gmail.com> <168546845148.691057.9965315836245052581.b4-ty@kernel.org> <20230530211446.foqpcfha6hjruhow@mobilestation> <30bcf77a-3e7c-4f13-94ab-f4efc52193dc@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30bcf77a-3e7c-4f13-94ab-f4efc52193dc@sirena.org.uk> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023 at 10:16:00PM +0100, Mark Brown wrote: > On Wed, May 31, 2023 at 12:14:46AM +0300, Serge Semin wrote: > > > Oh, thanks. I've absolutely missed the respinned version of the patch > > (it should have been marked as v2 though). Anyway the change looks > > good except it introduces a redundant empty line at the tail of the > > dw_spi_debugfs_init() function. Is it possible to rebase the branch > > and drop the line it? If it's not I'll send an incremental cleanup > > patch then. > > I'd rather just take the incremental patch here. Done. Please find the cleanup patch here: https://lore.kernel.org/linux-spi/20230530221725.26319-1-Sergey.Semin@baikalelectronics.ru -Serge(y)