Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp790036rwd; Wed, 31 May 2023 05:38:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fmVz1/1YRMxR6fm3EuhDcwXUYhcEVAszzfQJ0qnZ4xy62hgeIi7AyN5awN/GzOyfGQP1A X-Received: by 2002:a05:6a00:248b:b0:643:b37d:d350 with SMTP id c11-20020a056a00248b00b00643b37dd350mr6301621pfv.31.1685536705380; Wed, 31 May 2023 05:38:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685536705; cv=none; d=google.com; s=arc-20160816; b=Wxp2iaJ4nn4vB5h5by2LQ17ZrPaJGC/zCcF+FwYlOxYkA32X/K9r1AQQvmAaol5YQH 0qYOBJFv/7xIJhuB/lSdBJ0wIGH2tYMqnvmVmDQiBtMqJaUUNeY/sB+kEMDLVYlultKR FhjyXWtLHhfiB0jAN/F0QjYmVVrcev+tcncAQf0iJoQwgUpdhbM7Iz4JVf/ye+dLqrCw lYU8l+DnXH+7xo2AlyRlYQ0+aJ5+xzfi0LhocUVmc6NXK7yp5sXlLPdke4XD9/lfHfoJ 8lW60+KIo8dhHARZScymUlu+w3EWLz9LswTJgGJvWN61e2ky+10o/QcpVVs7LZIYg2VI EFDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=2RCEej4K5XPwpOdjmGnUsEFbXkDnSBYDQGM0QVWDj1s=; b=tTTSojndjn+kx4jdSNn4hgCejRFrTEdDC9PGPQYEx8iWaNaSeQImShREISQLy987Ct BNqba7rfjMjDID1bYuANGzMJuHmluY477rLVyNWflywef5sERrMAyP6M2iCiWMmiNbkC IZ1Ab0B+/ik81F0KyOiExDwES+5mOHO2/rMdrnSfSci8MnYA/5bHJ3+qs0P2lHevRnxT M50Q9Q+vrFo9049XmdGF+JAgdsbsjHHbstD6dTZdb7sZB3xKwdDIo8JCW+hwFJKzzT+U xRn/8Q6o1oM/S7wJ+unemJtMifWgnsDSWctQCPYsnwHbuYdgUkGzFtEfaPQtg6revPmV r+Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="L5DSDLE/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l5-20020a633e05000000b0053f4a727da6si893327pga.563.2023.05.31.05.38.13; Wed, 31 May 2023 05:38:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b="L5DSDLE/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232948AbjEaMVt (ORCPT + 99 others); Wed, 31 May 2023 08:21:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbjEaMVs (ORCPT ); Wed, 31 May 2023 08:21:48 -0400 Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAF7A10F; Wed, 31 May 2023 05:21:46 -0700 (PDT) Received: from [192.168.192.83] (unknown [50.47.134.245]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 568DC41E12; Wed, 31 May 2023 12:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1685535704; bh=2RCEej4K5XPwpOdjmGnUsEFbXkDnSBYDQGM0QVWDj1s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L5DSDLE/du/kQdCq1yNvvc3K4Gx6NmH+18ZvXkQ7sjp9P4es8/Q++47hs8diF+nVm wjk7Y8VH3VTf/gbt8XDwXbkyfKiJpZvL26u6vQWVIIzmdg9z96gCw+MxolgGQIVJVo Xw7O7DSXWwDF5W/wgNgxF0CfPBGk2UzvZnhooZukpTuPwuKBGqfDb9TWxbdUXkxjNq jTYMMDOmPyooRTUgQtnpZore5X+A0hgQyLi64VrUEv491y107FUwtZ4KduESsupr75 ibLCUDtoTx3Sm41No/ec9i+cR2WuQMr41nsjlpTlOS/DdaCy6MHRfb7fMm/i/4jxYq 01Tu6BfbuVfrg== Message-ID: <1f35dbba-9344-75c5-e870-31bc3198dbe0@canonical.com> Date: Wed, 31 May 2023 05:21:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] apparmor: aa_buffer: Convert 1-element array to flexible array Content-Language: en-US To: Kees Cook Cc: "Gustavo A . R . Silva" , Paul Moore , James Morris , "Serge E. Hallyn" , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org References: <20230511213441.never.401-kees@kernel.org> <7085879d-4d21-b90a-c08d-60450d1c7d38@canonical.com> <202305301555.102E1890@keescook> From: John Johansen Organization: Canonical In-Reply-To: <202305301555.102E1890@keescook> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/30/23 15:55, Kees Cook wrote: > On Thu, May 11, 2023 at 02:48:29PM -0700, John Johansen wrote: >> On 5/11/23 14:34, Kees Cook wrote: >>> In the ongoing effort to convert all fake flexible arrays to proper >>> flexible arrays, replace aa_buffer's 1-element "buffer" member with a >>> flexible array. >>> >>> Cc: John Johansen >>> Cc: Gustavo A. R. Silva >>> Cc: Paul Moore >>> Cc: James Morris >>> Cc: "Serge E. Hallyn" >>> Cc: apparmor@lists.ubuntu.com >>> Cc: linux-security-module@vger.kernel.org >>> Signed-off-by: Kees Cook >> >> Acked-by: John Johansen >> >> I have pulled this into my tree. > > Just a quick ping: I haven't seen this show up in -next yet... > oop, sorry looks like I didn't push, it should be fixed now