Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01197bb8-da0d-f726-79bc-d8ab7d3ea992@linaro.org>
Date:   Wed, 31 May 2023 14:35:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported sensors
Content-Language: en-US
To:     Peng Fan <peng.fan@nxp.com>,
        "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Cc:     "amitk@kernel.org" <amitk@kernel.org>,
        "rui.zhang@intel.com" <rui.zhang@intel.com>,
        "andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Alice Guo <alice.guo@nxp.com>
References: <20230516083746.63436-1-peng.fan@oss.nxp.com>
 <20230516083746.63436-3-peng.fan@oss.nxp.com>
 <3c59c4e0-68eb-b778-6b12-9f9e331f81dd@linaro.org>
 <PA4PR04MB94165217C8C0D9E8E0087AF988489@PA4PR04MB9416.eurprd04.prod.outlook.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <PA4PR04MB94165217C8C0D9E8E0087AF988489@PA4PR04MB9416.eurprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 31/05/2023 14:05, Peng Fan wrote:
>> Subject: Re: [PATCH 2/3] thermal: qoriq_thermal: only enable supported
>> sensors
>>
>> On 16/05/2023 10:37, Peng Fan (OSS) wrote:
>>> From: Peng Fan <peng.fan@nxp.com>
>>>
>>> There are MAX 16 sensors, but not all of them supported. Such as
>>> i.MX8MQ, there are only 3 sensors. Enabling all 16 sensors will touch
>>> reserved bits from i.MX8MQ reference mannual, and TMU will stuck,
>>> temperature will not update anymore.
>>>
>>> Fixes: 45038e03d633 ("thermal: qoriq: Enable all sensors before
>>> registering them")
>>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>>> ---
>>>    drivers/thermal/qoriq_thermal.c | 30 +++++++++++++++++++-----------
>>>    1 file changed, 19 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/drivers/thermal/qoriq_thermal.c
>>> b/drivers/thermal/qoriq_thermal.c index b806a0929459..53748c4a5be1
>>> 100644
>>> --- a/drivers/thermal/qoriq_thermal.c
>>> +++ b/drivers/thermal/qoriq_thermal.c
>>> @@ -31,7 +31,6 @@
>>>    #define TMR_DISABLE	0x0
>>>    #define TMR_ME		0x80000000
>>>    #define TMR_ALPF	0x0c000000
>>> -#define TMR_MSITE_ALL	GENMASK(15, 0)
>>>
>>>    #define REGS_TMTMIR	0x008	/* Temperature measurement
>> interval Register */
>>>    #define TMTMIR_DEFAULT	0x0000000f
>>> @@ -105,6 +104,11 @@ static int tmu_get_temp(struct
>> thermal_zone_device *tz, int *temp)
>>>    	 * within sensor range. TEMP is an 9 bit value representing
>>>    	 * temperature in KelVin.
>>>    	 */
>>> +
>>> +	regmap_read(qdata->regmap, REGS_TMR, &val);
>>> +	if (!(val & TMR_ME))
>>> +		return -EAGAIN;
>>
>> How is this change related to what is described in the changelog?
> 
> devm_thermal_zone_of_sensor_register will invoke get temp,
> since we reverted the 45038e03d633 did, we need to check TMR_ME
> to avoid return invalid temperature.


 From a higher perspective if the sensor won't be enabled, then the 
thermal zone should not be registered, the get_temp won't happen on a 
disabled sensor and this test won't be necessary, no ?

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog