Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp834365rwd; Wed, 31 May 2023 06:10:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ55scjH2Pwk8yVtkiiQJBWRU9eP7mOt7o0IozgTA2RHeLnZ6AGeTt4Rh1t12HyhDToknTAf X-Received: by 2002:a05:6a20:869a:b0:10c:c5df:8bb7 with SMTP id k26-20020a056a20869a00b0010cc5df8bb7mr3688562pze.30.1685538643249; Wed, 31 May 2023 06:10:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685538643; cv=none; d=google.com; s=arc-20160816; b=FatvtkejxEEmTQN1Bb3OA2xbkEnz+6W7U+PU8kxBwdaEFIjLYPB1sC5jVKcUOiOGWk VslAX1OvbqytqxK8ozNEXlqrUUJlOqm1fcjMPdCgkaE7kAKgBzq6/wdPb2cKNjADZIDQ TrIsLpfsOFtbH9ygDbxVrzYDm1UlBSq+rPoRblyiBM6PcPnjc2ntBfAd9iVVm3zfOZQf UG1jgoQcRkN4caAM6hWPtEexKNzyVnI+iJzgziRNyHeBW7cPVCAcFZjJWeP4Jk6zvNIM AQVBTPQ4C1UedvG1scucG8+X/79csdWP3v6pVXR4xext+4z9GK4O8Edbm3204gb+6LgZ NFRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=yQzRGUXZGKD7QHviBRf4JKBdZ3ynYUe71cHh/+CXF2Q=; b=y/kToK1CBdl9IYfJShVFYm8lEtU06vVPlRB4nCxgHLdbaaKzFKzkfbAyGmIswpcde4 ykFOYfAd5C8c3EgSWbyj4dyTKblfvgOB/f/mv7xJqtNqVXZ6nJk+ED9+l3Pk/1WSbtq5 0KZtaSunGAtkSBlzk5WkpIagVbFHZCj+H0hhqWuLUIy7W6ThiUaUql8S/2wV2o/tTMlY q1b2+mvDDN4vvIT/epEZDLIDpBXi1ZY2hT83eHlpAzbS5I30OevkitWA2J33v5IbbWbY png/ckcZ2XCGpOcAvZoczzIiO9pVfx2bQBT/KKY69rnHL4va/u+JYItfCVjOWHu52utm 0Jxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a637e01000000b00518b499da59si891924pgc.901.2023.05.31.06.10.27; Wed, 31 May 2023 06:10:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236192AbjEaNGE (ORCPT + 99 others); Wed, 31 May 2023 09:06:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236479AbjEaNFX (ORCPT ); Wed, 31 May 2023 09:05:23 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B768D19D for ; Wed, 31 May 2023 06:04:51 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 2EB2C68BFE; Wed, 31 May 2023 15:03:26 +0200 (CEST) Date: Wed, 31 May 2023 15:03:25 +0200 From: Christoph Hellwig To: Daniel Gomez Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Pankaj Raghav , "mcgrof@kernel.org" , "linux-nvme@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] nvme: Increase block size variable size to 32-bit Message-ID: <20230531130325.GE27468@lst.de> References: <20230530154231.8313-1-da.gomez@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230530154231.8313-1-da.gomez@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + u32 bs = 1 << ns->lba_shift; Make that 1 a 1U so that we're not going to run into sign extension issues when using up all bits in the u32 :) Otherwise looks good: Reviewed-by: Christoph Hellwig