Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Mehul Raninga (Temp) (QUIC)" <quic_mraninga@quicinc.com>
To:     Bjorn Andersson <andersson@kernel.org>,
        "Mehul Raninga (Temp) (QUIC)" <quic_mraninga@quicinc.com>
CC:     "agross@kernel.org" <agross@kernel.org>,
        "konrad.dybcio@linaro.org" <konrad.dybcio@linaro.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jirislaby@kernel.org" <jirislaby@kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Viken Dadhaniya (QUIC)" <quic_vdadhani@quicinc.com>,
        "Visweswara Tanuku (QUIC)" <quic_vtanuku@quicinc.com>,
        "Vijaya Krishna Nivarthi (Temp) (QUIC)" <quic_vnivarth@quicinc.com>
Subject: RE: [PATCH] serial: qcom_geni_serial: Setup serial port after Deep
 sleep
Thread-Topic: [PATCH] serial: qcom_geni_serial: Setup serial port after Deep
 sleep
Thread-Index: AQHZkugtQgsIHoUoGU+G+KIDXYHr3a9y6tGAgAFoUyA=
Date:   Wed, 31 May 2023 13:06:22 +0000
Message-ID: <SJ0PR02MB7742A7386189692ACACC0A3FE3489@SJ0PR02MB7742.namprd02.prod.outlook.com>
References: <20230530111557.10944-1-quic_mraninga@quicinc.com>
 <20230530150631.7eg6nkre6sva5dcz@ripper>
In-Reply-To: <20230530150631.7eg6nkre6sva5dcz@ripper>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR02MB7742:EE_|SA2PR02MB7804:EE_
x-ms-office365-filtering-correlation-id: 9158a4f3-b49e-4f37-5277-08db61d7d548
x-ld-processed: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d,ExtAddr
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6gVz9hmUOnn5NZJUmQ62xwuDoSqgCdRiCuPVnN1kCKHVurp6W5RM8RGEfZGoz8Co/tXtTQaXzbtUA+u+3hf2jhx432zZAk03Sz+nb/H2GDnvNLBd7IZWEcB6zKByG3QbDBl16xPJBbpQKzgyY2NsOIBkg2y21OOGrKQMpTq++TGOnBem5BoxK+lYrI3+PPdWb9Gk4O0xl6fJCceON+BBnb3exfTaO+D5zeR3EYc0gpZSMQBwVRznj9dpzNbzbs2RRzttRm4+LQJdkvjmXr6q/OLrNdFl5mxw3wbypOV6beYoJtzSIMIdKXD//xjsuXBfbU1shTZjdXlBzdaIgrXAnunPfHGoHe92aEmo8OIxUUQjci3LEE0alpQJ0eJncj8/4tWYoRAiYvQomu1ZobesgGEdCunCOGqQITYFoyNXTi4qbBPpH2yudOGDAHDsdEZxwAS6OH2CHDXfhmfI9QlVzOsJqq/NVpsXpulsUzFMXUoSoCYk8XOueEFTntpM6dK2cLkdKAyuSofLTrANiDm/eMAAreIidi74S+5Q0/cDYxrILQSsyTFP5EdJZkXuV1eO4r7EjRDaxEpIdnIal5yeTfL6NvzMh8gVq64WZTqY8H9p0s/QDBxHJWew6763PUpb
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR02MB7742.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199021)(86362001)(33656002)(71200400001)(64756008)(66476007)(54906003)(4326008)(66446008)(66556008)(478600001)(66946007)(76116006)(110136005)(316002)(5660300002)(7696005)(55016003)(2906002)(8936002)(8676002)(83380400001)(52536014)(41300700001)(38070700005)(38100700002)(122000001)(107886003)(6506007)(9686003)(186003)(53546011);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vbslEP7c8T4X6eBBUq+Np6qO7HY7gYaBlXcbNVtpdfentl8aTO4InCJY36iJ?=
 =?us-ascii?Q?0tsxCZdtphSIIJIJU59GxkEqKNoMvQa1s8pobRhgaifOkF0Q0ZrGSAgOD+OF?=
 =?us-ascii?Q?Ux7YYe9C7ePf5phu36Pf3c2q24QxiHi+UDzVWGYN2/vY8UMpbxgQztfkvJQS?=
 =?us-ascii?Q?2Iy5nLM8U6AeH+1Eaqn53Z06J9/N/OBunNXJkYF4GFTdhMSAN83Tm9P5nrba?=
 =?us-ascii?Q?Ff+7mjKBwuOb6zn+McetonriyypVTm1tieq0jtS8WXiBiLru1fue9vedYOCT?=
 =?us-ascii?Q?gT993p+WLsBVxibcG1ADnN8ISrBBr4RWKdajrhx5RMYW+TaqfT9k0blL/NnC?=
 =?us-ascii?Q?oN4u5N0nABIb/W3e6PAAVHDVRbmunYX6hSVMR7GWZ9TAE0lF6FodSI/R8xSp?=
 =?us-ascii?Q?WqyGMrob3UfENS3885GBItVOc5+WNE2x8jcteFCzcFjjWsqb0a6Ds2ghLJcm?=
 =?us-ascii?Q?QC7S0AEmsv8MJHFYrXjnuFhZoKyy52xLZPPe/GZV5lv8Ifcg1mkSk2WDxqdB?=
 =?us-ascii?Q?bEPoPpSPElzJRgYb2hM/BwP5ti6XgagdBt3vgk4/P9sgdWgLDChBTAz3biMi?=
 =?us-ascii?Q?fb/RBpfpu+l0a0om2IxeVXe54o9NjdClHwAfVWsaslU9I4F6MMuBgCaOg3gi?=
 =?us-ascii?Q?vpre77oNXDM9o/69+L0OqDC5Ks9AeSy/dptUOBYtr3IPJByk7X/cTN35Q6Fk?=
 =?us-ascii?Q?FqdlReLkKDtQKC/Cm7JELVMfhQmrK3olMJHg6ND/W/RuFLy1GxuE74IgzE45?=
 =?us-ascii?Q?oTE0SHef/cfXmMe9lyqWXErAfMvsJHA1AOn4hvhDf+ekq2q9FBdPiB8lhVVB?=
 =?us-ascii?Q?Wl532R6/oZAS4EJET/AxlgI/xOVlkcuRa01EPKpvgRWTjPJI39ayvoUaDaqD?=
 =?us-ascii?Q?BVKPUiiUX8uhWhak5YGFijUj+hTbcKH9awehBtYq3WumnZVCNIl48YpuZZaL?=
 =?us-ascii?Q?jzMKGe9aRzStr//Ru0Yqq5wzMtABY8RiFFPMBCRJwK8/ZU+0Q9J3LqtoVIhM?=
 =?us-ascii?Q?uD1cn8ilirJIrbTzJMaAl+kPPhUu+QhpFsDna/FcIGuknteMvckbeN1hb/aK?=
 =?us-ascii?Q?1rVvHzH3GTi+fRb/NsDsQ+EXJunRL1bklx3Zv2OI2zV7ZHOBi3N06luGUVBJ?=
 =?us-ascii?Q?OBpNp+YyxqHqQvL7oe9te3BJ2cOXFbwgNgGuIgoFPb27TY03AA4PaGY6NjF2?=
 =?us-ascii?Q?kFAvdeRCV/SnCHIPjkl6aCAni9ss7gwHa9hHy1Fsy9UAoSLAxT2WNoRJvcH+?=
 =?us-ascii?Q?1NKPBE8Pt+ORlUtwcxgaRqEgxK0rnUFxJcFGRCAWX/6dIE9q/Z11uYTBHaT5?=
 =?us-ascii?Q?E1EM4DjmZ4S/7AXCTz8n25trCBhJH8fpEAPKhDdRFgPFtST19efOTiGXb5/t?=
 =?us-ascii?Q?PdX5bjNqJjSXJ80dqTqa6YnFBJPN3ZwTp3X9grPKW0ZGq6kQLlwqAwyzHP85?=
 =?us-ascii?Q?Sa+9hdNRkx0r3f8QDXTBKID1Cf0cQCO7Q5CkghKOmBKjqk1A0fuTMO/kWTCc?=
 =?us-ascii?Q?h7ieTBShcD/1L7rEDZagGYUd5TywS7yC+vUHR80JIU+ZZEktfP8CsxdTThK2?=
 =?us-ascii?Q?L2E36lGWFJbgXhUNjJw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: cFnLXd3mwCoS6obsh5Dodw/0cPpLmaXiA4eLBscSejNDqJ3ubVa6tfOVwf6rzEk8NSyg0rhKe+oBpHUg7u/bjLvr6sWMJoq8VzNEhJubGVgS7pJTHLhcfDqKFAQgydJqqXo93Nujz5F0B+SU37euzu/IbEpTYWakO6EnUXT82UU54jw2dZNwpkcVwJUNZZ+nggtRl7bTIgD6DFgEB78EkBrQBAJgM9yDYb7o8Zsr7VRxuWnqCep9zB6lhsc0iBVsvxW11yZAdqE+/9msoWFImeiyjGq4YRE02fNe1iUZ/cDt3WGj8bYU4BVmtNJi3dcN0A6hWRCcn48ZPgNmsqfMkMjVMJPl2YHgM/5RH7eUChZqiVh2QfzwH88FmhScmXpNSn0LeNBcATH2dCMWVysWnCntF9x7SGrghi7K0xSc2a28mCuUxFsaGiRLogReNv/UCWTsHbfYqR1IlyHUvQpDUP8C8qM98XJewtFtU5BulLS/xI3mjWOFYlyH0ppZCA59wIqKt8N44Ba/HU0ReW9SHu6TcjyFgWjy7URNcWUZn/IeKceXLiwCQHrOGFBrJe+oj93Pa4I0l724jE/NZBkiDojjTY575l9cje1dU386m7NVm4S0vuJ1bV+YTPcd6HGkiqZr/Hji/SrAJmobSSKHjzSjJWpm9tZI7JxfXjJfI1se7usNI9qXpeTVkxYXYUz6YJtuKD9cZiHLF/cdaAu8Y4p7X4TCp8nIMVkCWSJJ8ySYg0zpdb/YqrAXnFqdQG6/4jxKIhrbSsQoy7k/aSbhyttZZHkf0zlLfWFJsD1AIo2ieNK0/bm7fSMWqlUO9Q3FMia4m8E9gVY5bgjTu1zazgW5oiUp6KFh8FhvGihKsSv2Cgwg3u3Xr+hSnw9rQgvBu0DopdsHyoD9kbeb8fVABA==
X-OriginatorOrg: quicinc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB7742.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9158a4f3-b49e-4f37-5277-08db61d7d548
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 13:06:22.7197
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 98e9ba89-e1a1-4e38-9007-8bdabc25de1d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M+BKHN9DOwjzx2HV0Pi449bMcdZ8YOdBTz6N4lC7EBOH+Z2ijn1/3/IlprN1ldlyQPreJyao/64MVWX2tyQJ1Ui7QUETOywSFy7YDsTFfzI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7804
X-Proofpoint-GUID: KwkL_4IZq-oCwTGciZfp8AYIcE3DahLw
X-Proofpoint-ORIG-GUID: KwkL_4IZq-oCwTGciZfp8AYIcE3DahLw
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-31_08,2023-05-31_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0
 lowpriorityscore=0 mlxscore=0 priorityscore=1501 malwarescore=0
 bulkscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 phishscore=0
 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2304280000 definitions=main-2305310112
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Andersson,
Thanks for the review. Kindly find my reply inline below

> -----Original Message-----
> From: Bjorn Andersson <andersson@kernel.org>
> Sent: Tuesday, May 30, 2023 8:37 PM
> To: Mehul Raninga (Temp) (QUIC) <quic_mraninga@quicinc.com>
> Cc: agross@kernel.org; konrad.dybcio@linaro.org; gregkh@linuxfoundation.o=
rg;
> jirislaby@kernel.org; linux-arm-msm@vger.kernel.org; linux-
> serial@vger.kernel.org; linux-kernel@vger.kernel.org; Viken Dadhaniya (QU=
IC)
> <quic_vdadhani@quicinc.com>; Visweswara Tanuku (QUIC)
> <quic_vtanuku@quicinc.com>; Vijaya Krishna Nivarthi (Temp) (QUIC)
> <quic_vnivarth@quicinc.com>
> Subject: Re: [PATCH] serial: qcom_geni_serial: Setup serial port after De=
ep sleep
>=20
> WARNING: This email originated from outside of Qualcomm. Please be wary o=
f
> any links or attachments, and do not enable macros.
>=20
> On Tue, May 30, 2023 at 04:45:57PM +0530, Mehul Raninga wrote:
> > While exiting deep sleep, serial port loses its configuration hence it
> > prints garbage characters on console.
>=20
> Presumably it lost its configuration sometime after suspend, rather than =
while
> resuming the system?

I will reword commit message in V2 as below:
Serial port lost its configuration sometime after suspend hence it prints g=
arbage characters on console after resuming.
>=20
> >
> > Set serial port configuration while resume from deep sleep.
> >
>=20
> What happens if you do this unconditionally?

pm_suspend_via_firmware returns true indicating system is resuming from dee=
psleep. In case we are not resuming from deepsleep, this serial port setup =
is not required.
>=20
> > Signed-off-by: Mehul Raninga <quic_mraninga@quicinc.com>
> > ---
> >  drivers/tty/serial/qcom_geni_serial.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/tty/serial/qcom_geni_serial.c
> > b/drivers/tty/serial/qcom_geni_serial.c
> > index 8582479f0211..c04b8fec30ba 100644
> > --- a/drivers/tty/serial/qcom_geni_serial.c
> > +++ b/drivers/tty/serial/qcom_geni_serial.c
> > @@ -20,6 +20,7 @@
> >  #include <linux/serial.h>
> >  #include <linux/serial_core.h>
> >  #include <linux/slab.h>
> > +#include <linux/suspend.h>
> >  #include <linux/tty.h>
> >  #include <linux/tty_flip.h>
> >  #include <dt-bindings/interconnect/qcom,icc.h>
> > @@ -1737,6 +1738,8 @@ static int qcom_geni_serial_sys_resume(struct
> device *dev)
> >       if (uart_console(uport)) {
> >               geni_icc_set_tag(&port->se, QCOM_ICC_TAG_ALWAYS);
> >               geni_icc_set_bw(&port->se);
> > +             if (pm_suspend_via_firmware())
>=20
> I'm not familiar with this api, but aren't all our systems implementing f=
irmware-
> assisted suspend?

Not all the platform supports deep sleep hence to differentiate if resume i=
s from deep sleep suspend or normal suspend, this api is required.
>=20
> Regards,
> Bjorn
>=20
> > +                     qcom_geni_serial_port_setup(uport);
> >       }
> >       return ret;
> >  }
> > --
> > 2.17.1
> >