Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp872218rwd; Wed, 31 May 2023 06:38:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7RKOZPjsJQ/UEDBC61XquGqgdRTMVgoGl5Mw93n29hrLcYpkPq2Clxn/iWVN13lEqK2zq8 X-Received: by 2002:a05:6a20:5485:b0:10d:951f:58bd with SMTP id i5-20020a056a20548500b0010d951f58bdmr5916821pzk.19.1685540309589; Wed, 31 May 2023 06:38:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685540309; cv=none; d=google.com; s=arc-20160816; b=W3dlNQi1AOU7V936Lqkn6lXjt5h9VyzAAOK0FDsSDA8Gd8Qf7nGR0VaWBhbEHp0rp/ d6tDLIU1VRSIOr2lK4TvX2fTTjrcOhPhhnbRzZgjSixHugILwr4cuLhSCYkH4SFPaJkt S3KhLV+7NSLvKu7H1mCCj9Z7cXxHlswvpqFH3LU92rxU0+gn6z3JB3dOvruKMyIqqj/z DmbktaVAvxAknOp/QiMGcttipQV5jZpNPbpgCJLdd+noCAcwWsJX9SpRMicgw2wHdlcw d7fnOujmR96ru0MbmCFmty3HDrrT8RtYaVuyHH+H8PaoaCG3rtSeeqQ/fxp/RpRyYXJE ihPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iwcEeN504DjhoOuzUj5OlMFLIvNRYfbkpg8/TQf12A4=; b=wVQsEneee0/La7w0apCgTtT3xoUZGRqYDfVMoXxFfdk3kBlvVlM/Z+ZeVLyaH6Xalj +tX+IWlZBORisWX4pv6iw1pTl7V2/ls52fTd5hrsW6+HdqpMm8XkyDAs0vlBqyrdyE+C IWzHqQpLGT3qjNgpIpdOd+t5upng6E/2FZHD69Te4iRUtiwQF4ZdJa4k6hGSMJHv170z xdRbzkEW7W6eZQNGA5ifOZQrFYbDdCRZgY8G+81n9pgCbK93gnZOXF+Rf46/0w2lk30U 3OLh9MPAACx/DXsfpULjHtCSCCobMqkDSO2LR445iW024+b9CrSTngBO0jflUutbbRQT zUaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Wr+xtuxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w125-20020a623083000000b006435149f9ccsi3582208pfw.63.2023.05.31.06.38.14; Wed, 31 May 2023 06:38:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Wr+xtuxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232788AbjEaNKS (ORCPT + 99 others); Wed, 31 May 2023 09:10:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235873AbjEaNKO (ORCPT ); Wed, 31 May 2023 09:10:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BE5713E; Wed, 31 May 2023 06:10:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E7C9762861; Wed, 31 May 2023 13:10:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A8B0C433D2; Wed, 31 May 2023 13:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685538605; bh=N7v6UdCdoRDaOMtpTdXXMBT2de0u9wjqumzPzRpdTAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Wr+xtuxP/fN6kmb8aGSppryJP3huDhA21hKsAT3N8F9gvrVKbCQ0F7VJzgKL4cssQ DWwxG3Y5twq5W5vXGLpbJL+4m8CLRQPnqCDeayf1bGLEcWDZZsn/WUHmy/HAYWTHdm /A80iws/6gDkmrEB8MvL+qVRj06ibzBfIGO2xB+8= Date: Wed, 31 May 2023 14:10:02 +0100 From: Greg Kroah-Hartman To: Ricardo Ribalda Delgado Cc: Mathias Nyman , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH] xhci: Do not create endpoint debugfs while holding the bandwidth mutex Message-ID: <2023053152-pegboard-oncoming-18ce@gregkh> References: <20230531-xhci-deadlock-v1-1-57780bff5124@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230531-xhci-deadlock-v1-1-57780bff5124@chromium.org> X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 02:40:02PM +0200, Ricardo Ribalda Delgado wrote: > xhci_debugfs_create_endpoint needs to take the mm->mmap_sem, which is > not serialized with the hcd->bandwidth_mutex across the codebase. > > Without this patch a deadlock has been observed with the uvc driver at > the functions v4l2_mmap() and usb_set_interface(). > > Cc: Stephen Boyd " :(