Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 16:33:07 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH net-next 3/5] net/sched: taprio: add netlink reporting
 for offload statistics counters
Message-ID: <20230531133307.7oqrcujtqhw7olzj@skbuf>
References: <20230530091948.1408477-1-vladimir.oltean@nxp.com>
 <20230530091948.1408477-4-vladimir.oltean@nxp.com>
 <87wn0ptota.fsf@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87wn0ptota.fsf@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CTON53mXeU59Jteqi9QgeawZsYCO7NZQZNR7VhjENjrjABBe6gUHxxFZwOX9?=
 =?us-ascii?Q?ncaXSlOG0SKALEyPAFNhRk/tEv5uLNdrv4wPSp2eH3wSjFRTuhBU9gEPbqL3?=
 =?us-ascii?Q?ab00MprnyB8v7EzJRJZaDxN7AntY/+1ETVHcIiS1jOPN8pQ7FTKyqMmTmcXM?=
 =?us-ascii?Q?6vMn3gRDTjV9vESFidYBpeCXoxIEsuZ57bh0oqJUmpGO4XdB6D5Hb61BbZzD?=
 =?us-ascii?Q?CiB6hoU8u1XeSbtCf25ZAxbfyZEtFDRfjKU5wjLfadwIqadyyNLFgUYtGVg8?=
 =?us-ascii?Q?laP6yYx/4eEPNT1ukfrq33Rx8uBcOQNUBuziiKsE5Io6rGD2O8b5J8rReUFl?=
 =?us-ascii?Q?u/0eCP3T661SHI3dyjXToKPo5FcBmL9bdJ1NYrYsmD6FRK7zJZ5kJZzlTI4r?=
 =?us-ascii?Q?sOiofpme0CJAVhLHENrRHQ+Gc9uaW0a2SMytQkRDmwBefZoeriRG+pJTzppl?=
 =?us-ascii?Q?6EDVuOCYcyUnNGZlXJzW+rGj8Y70KZ1NL9BYvfj1cCrXcw884/cMgpCM/kT3?=
 =?us-ascii?Q?IbjkJzmHYRlr+sqjT7C0EgMeCU6/hC0ngvPMvOfhTzGr5pLyaUsPCAIbRZ2z?=
 =?us-ascii?Q?re3kBJI1PetbvFpmuD/p7C69x2qez2ez9mioawWuW7J8rOJUTywoFGWiJDFL?=
 =?us-ascii?Q?pJ9FYcmK3iH5PcsIPvq4avTe9YGtoB3PkB9/kTRNONyfPY04SOh8pr3jqa73?=
 =?us-ascii?Q?SWXXeqNqCUdCoK3a88nY10ozUgI0S0FlxbsYZPZ4+a0N93pQfb7pL9AsEJoq?=
 =?us-ascii?Q?mAeGxPTXRj6UtoowYxRzgPoGB7w8ZaYMtuvZYVjYXeVbG1VS2Uy/aDw8QmCk?=
 =?us-ascii?Q?5EOCHHSL/wYUXFk4Eul9CRBApk+P224YhYBt2jD/eBpQk9VJEt54d2fhxM4w?=
 =?us-ascii?Q?m7uR3srP5RzflDtZAV6tHzf7t4/T5pf3A88KKPN4SVT6qadYJFkwuLv9jkhV?=
 =?us-ascii?Q?Hu8KHgaOFbcfws9KsGLOEwY72R5VTgyadViBFuce4qiqwlxsXar2U8y7Tu7F?=
 =?us-ascii?Q?I0aTn1EkQ0lYQruFefFLAbIlqqKZ3fHXxe8ygJpGlSeSReYbrisS9JtKaIFA?=
 =?us-ascii?Q?OFVJKz0t7U4jXe1H+lSbifYji2Pfvp5hxKumm28C/sCX7uMjziUHBNzY8U0U?=
 =?us-ascii?Q?J6+GBvi+k+pt8ACjNYIgRWER/+CshN4Ore5NU3vCMKF/B+4o48OgoiVQcQrF?=
 =?us-ascii?Q?cRhIuicrJU86CBVyNClFx5bzxcLmVgkb9TyKIVFYR5rl+21YTS9tMaWeeQj3?=
 =?us-ascii?Q?1/uk2ZnvAApLXEQuQxt8xVQhEO5Bx2b1NQa3KF1MhNPhcB2oY1iEib1lGYWP?=
 =?us-ascii?Q?HqbNWUTf2xoEm5ImCxiMB08ooHOZE1AGkCpxXUBN0Igec3c7rmw6QmxA0C3Z?=
 =?us-ascii?Q?nqZIFoDUumS32fgvuu3/Mcy8TovFiD2HpBGj7kJgFFG/AI52BGchEm+PT1II?=
 =?us-ascii?Q?6Gsk8fQjHTPgJ/yaIGoIMhp+6VVTro6XywiJt5uRbTbimqYcRb54VnpGfiP/?=
 =?us-ascii?Q?RVXRFgb3O0kcCddzyRpZ/8UfiYG/LHumsvoLJBH7ESmLbAb74i6qQZRu7a9A?=
 =?us-ascii?Q?NDsVs/QW28Kozp2zngWvIqcT7dDrokmtP+TzLbvweD6MYvKrAjOpLcJ2JLeX?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbb73503-82cf-47f8-0f73-08db61db947b
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 13:33:12.3233
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FyrMwy6MEUK2G9UQJ7xyfLxp382KJFCZcFJF6O299fJUw+7a93bFF6dMgnjZ8ZPs/QzU5A1EAFGlcdy0ZUL0hQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7498
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2023 at 03:52:17PM -0700, Vinicius Costa Gomes wrote:
> > +	memset(stats, 0xff, sizeof(*stats));
> 
> The only part that I didn't like, at first, was this, that the
> initialization of the offload struct is divided into two parts: one to
> set the command/tc, and one to set the "invalid/not set" value to all
> stats fields.
> 
> I was thinking of adding a macro to do initialization of the stats
> fields, but it has a problem that it won't complain when a new field is
> added. Your solution should always work. I don't have better
> suggestions.

Right, it's no coincidence that it's where it is and the way it is.
Again, I drew inspiration from stats_prepare_data() in ethtool.

> Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>

Thanks for the review.