Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230531125918.55609-1-frank.li@vivo.com>
In-Reply-To: <20230531125918.55609-1-frank.li@vivo.com>
From:   Juhyung Park <qkrwngud825@gmail.com>
Date:   Wed, 31 May 2023 22:53:52 +0900
Message-ID: <CAD14+f1YoiSVvq2M1v8u5bUdCNN_0nurY4ued6ZFu1gaBSHxDw@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: flag as supporting buffered async reads
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
        linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Lu Hongfei <luhongfei@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Yangtao,

I remember hearing that f2fs can perform relatively poorly under io_uring,
nice find.

I suggest rewriting the commit message though. From the looks of it, it
might suggest that FMODE_BUF_RASYNC is a magic flag that automatically
improves performance that can be enabled willy nilly.

How about something like:

f2fs uses generic_file_buffered_read(), which supports buffered async
reads since commit 1a0a7853b901 ("mm: support async buffered reads in
generic_file_buffered_read()").

Match other file-systems and enable it. The read performance has been
greatly improved under io_uring:

    167M/s -> 234M/s, Increase ratio by 40%

Test w/:
    ./fio --name=3Donessd --filename=3D/data/test/local/io_uring_test
    --size=3D256M --rw=3Drandread --bs=3D4k --direct=3D0 --overwrite=3D0
    --numjobs=3D1 --iodepth=3D1 --time_based=3D0 --runtime=3D10
    --ioengine=3Dio_uring --registerfiles --fixedbufs
    --gtod_reduce=3D1 --group_reporting --sqthread_poll=3D1

On Wed, May 31, 2023 at 10:01=E2=80=AFPM Yangtao Li via Linux-f2fs-devel
<linux-f2fs-devel@lists.sourceforge.net> wrote:
>
> After enabling this feature, the read performance has been greatly
> improved:
>
>     167M/s -> 234M/s, Increase ratio by 40%
>
> Test w/:
>     ./fio --name=3Donessd --filename=3D/data/test/local/io_uring_test
>     --size=3D256M --rw=3Drandread --bs=3D4k --direct=3D0 --overwrite=3D0
>     --numjobs=3D1 --iodepth=3D1 --time_based=3D0 --runtime=3D10
>     --ioengine=3Dio_uring --registerfiles --fixedbufs
>     --gtod_reduce=3D1 --group_reporting --sqthread_poll=3D1
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  fs/f2fs/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 015ed274dc31..23c68ee946e5 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -546,7 +546,7 @@ static int f2fs_file_open(struct inode *inode, struct=
 file *filp)
>         if (err)
>                 return err;
>
> -       filp->f_mode |=3D FMODE_NOWAIT;
> +       filp->f_mode |=3D FMODE_NOWAIT | FMODE_BUF_RASYNC;
>
>         return dquot_file_open(inode, filp);
>  }
> --
> 2.39.0
>
>
>
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel