Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Justin Tee <justin.tee@broadcom.com>
Cc:     Kees Cook <keescook@chromium.org>,
        Justin Tee <justintee8345@gmail.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        James Smart <james.smart@broadcom.com>,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] scsi: lpfc: Use struct_size() helper
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1leh4froo.fsf@ca-mkp.ca.oracle.com>
References: <ZG0fDdY/PPQ/ijlt@work>
        <CABPRKS9ykHvaOGUboDXZ261LLPS78+YFpOZAcJEeLKGfEUe21g@mail.gmail.com>
        <202305261041.4C23B96F@keescook>
        <CAAmqgVPcSa36H7J2ABPmgCkkn8d7Asy+Wdn-xmQLuPqTupE5Gg@mail.gmail.com>
Date:   Wed, 31 May 2023 11:26:49 -0400
In-Reply-To: <CAAmqgVPcSa36H7J2ABPmgCkkn8d7Asy+Wdn-xmQLuPqTupE5Gg@mail.gmail.com>
        (Justin Tee's message of "Fri, 26 May 2023 11:06:55 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?plCD1d88nlC4GvWwRj5PbYWG8acFAxkvBWtx+xST8H4WPl6a5iV5g/UQ0ogh?=
 =?us-ascii?Q?LsqpCB9rhQjXD411yV3u2IQ1692JRaq9MJcKUcomL+fltNnnki0HyhgXACnb?=
 =?us-ascii?Q?TqH8KafmjldTwDHtbwqdZY9jG/Q102NVTadtE92H4wzwv+/5CLHLHCdhLTdJ?=
 =?us-ascii?Q?Wo0VJntoqdD0Jj3rqGEiZmmfSxm+vrOQZwwfJDLy3vHIfe28NmklbJpfcZsu?=
 =?us-ascii?Q?L5rYSr9Xe5fXONS5VaSvgp1Y+jHzY6QdaEIgCL6z3yTrRBMzyOYIM8b+goUs?=
 =?us-ascii?Q?pt/4jg1ZPAWgxaq40WNRc6cBEcTaduMZ6wx9Z9jaHm83CqoF07ls+nCetAsw?=
 =?us-ascii?Q?T+bW5x0OfZP2zwkKkG6Eyrdj6wQhNfosiBZQBsINbGFmMM+5QQkVgD9xS3ZV?=
 =?us-ascii?Q?9/tDvPlgtXm8azMp68zx3BG/JcXP2vnYoNUkSiCYFAZGpRXFbr1fuNQ+ACV5?=
 =?us-ascii?Q?pqnAnUKkzvjb4zbcodf+V4JFMOXGNmMORapKbk2pmkwcvYpRrpi5323E9IMK?=
 =?us-ascii?Q?gXKA3ksoF31cPQJ+WtoIb/FjQxQIFsORczKJffhWT/ob8ahUAxmCJt4HmHNn?=
 =?us-ascii?Q?IgMM8MWFz6LrWEj7Qex8zjQOL7c6t046RuJDx0EU5emr3QCr0DH2K/xZHzLb?=
 =?us-ascii?Q?WYXvbZ0Fey6wQOhdMN4H6+Qkp/E3mf3B33YVUIkEB9LJYpxm4ULL00yM+l7T?=
 =?us-ascii?Q?00ZZVj8YqVYf/QXdOm9rBqjDmUARfX513iKf0FNfLIwT7fTcfouUdQahiHNh?=
 =?us-ascii?Q?5cB1LWqgzZKMlcPePsefH5dQhpg8ZVX7BzgqFnCA/mJVai9s58T/53pJunUj?=
 =?us-ascii?Q?jnPyAKWrKir5rtE7CXMc+vMl60kCoZ51OgtCg8As5pvrnF/rGISwo5fOKz3y?=
 =?us-ascii?Q?owg4zA9DtdqVfLaPT/LW11ds4OGDvd/hgUJNT+qqVbDFGuswRHZOI+6I6jUA?=
 =?us-ascii?Q?MODjKyQuIiaI22AxR7s2pHqZxWdWWszGVCOdvn0fPnaeBOnuWTrdv0tD5Bxm?=
 =?us-ascii?Q?9Zo909ff77hqwk2Ipdn9rD+RsNyYUgDH1JqoxfBfvcbnN9mOlVX/fXXZyGTU?=
 =?us-ascii?Q?+dDL49/ncwaeYN0wb5PMa3jOoL4w2Bp0GE4Hfy24VyjAx/HcWWrm8DV9Ni0P?=
 =?us-ascii?Q?JyxLAYU0GIDQ9h9OFtOB2psuvUYJnTr17VKgK28kA3EBmV3gxy1jun/7hGXF?=
 =?us-ascii?Q?6kshOi/dx5FzVZyuF0bdBMLj2KRmW/IEKbHy0kWuqogzx2TukLVAcYDfIEyQ?=
 =?us-ascii?Q?11c3OmQ8N70PfV2Dl+/3U6gOwjONGcopjqmLaKtkvHs2L4uvxr4+UbaiPCG4?=
 =?us-ascii?Q?jhJi1RolWMrBDLBTWu5Sln4060YMY9GX1ylrIHYhFR+tSPFmN34eqGJ/4GLk?=
 =?us-ascii?Q?Lpmxfz5Pm8v8M8CR0jIiIf0ilvr4Tz55ebog4zMX70E8n/c+L/XpO0FfSckI?=
 =?us-ascii?Q?FR0Ja41v5jZvk1P7+SxV2VoDmqSCLd1n6kdWAZZOq/RFzT3nI7/wyQarXZmk?=
 =?us-ascii?Q?fvl2ejZeyWNMet5L2HDKggIrXDv68CDcuEF3U1xOM4jOYR98+5fgkMlldGDT?=
 =?us-ascii?Q?g4Pw12Br7ZbOmTnhdtqY4ks+ztWAdclnV+kDaSdu1aknvSKYz+mVXD5WScmJ?=
 =?us-ascii?Q?HQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BYbLGC9TjMVkUo1A/2OtzaRBjrDjrXw64Z6UU5Zk6XpWtqMQmAiVMLvxwAFjCKzQgx2bFCtPq0mHstyj+UJg5mDJpkcHh3Bjk107aXWhJWRNJLO/RlMr68maOmcfxyxQRGk00h7ciuYuiQwUWyW0UhWYzuhKjjyP7bVlqqfIu765HNsMJFEsjx0mlG/KE9FtKZRrLq/XEStdJ+SGVP7rokAWptOU+NQxfUAKPMMcapDGF3NI87y4/jycZrhL7jxHGMPjYOrqW3UvN8JMrncE75AD5S2pw0snZ0CizKRNDhgtFjIykBRIyK9ebCrLOwPYETmtQ2RsIyCWeZ7J9izxFOZJHhnDcLiyYqQoLC94mI8rrEu/w49ARYFPJJBdGsKJ+FL7DwBN3+lMbhKlKXi8g4i0bpPeIhXT6naqAAJfpc0AaMn9B0q6NIT+pDcBiQ/5HC+qfcgIToCemoeqETuUAKz9KcHYzfZ9reVuaiIs2odxzvbuv4i+skVWPkxyPypJnA1c5BcpMNIZ3wRFcGJ8vNCi/kdn8qMLOgwCXtzVA7rhcntqE6m4O8g2YTxpzLpOzEdF7EJkFea3pO1eeQeLUSjm2R2x1minB6dWSlt69Vd1rBu5GqRzs+07yg0FMB6Cq73zG3BUcIt06QHjQSlClBMScxzoLRA3IhwX3zat+d9W6T4reB9an9fOBrhsJiXA1KxBCBYkHo6C6sqlxBTRX5wldSGxQmpqZJkhRgVftEAC8xpMUYSx5cVn3fQuCtf6eMk4OVW5woQ3qSmVB2E9Eiw9/2RYuDdW5zPLG6S3Kkqj2Kyyr17lzWsHVzCs4YX/n3F7diYQ2/wvnOp0lESd/iV5TGqzbBK9dart3wDUTkM7JZ6f4gxtmyueL0g8c0hGhvv6B/6ylvgHNSWjH2uENaM8VWYIbWsJVNzVOjDLU3s=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc45a265-e786-400a-64b6-08db61eb77cb
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 15:26:55.9825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qD+ho7YjVDfabAxiCAkkjYb0afQV2geh/rZGThr0xFHHmPl7Ta7qZTDbVSlrC5D4rvImy1KE3sCldgJnNx3ZrqQ8sjejRuc68/sl6rJX1zs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7636
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-31_10,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0
 phishscore=0 malwarescore=0 mlxlogscore=741 mlxscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305310131
X-Proofpoint-GUID: E_kdF7S1pPJ8PXbzWqNWr1kHHodW0w-t
X-Proofpoint-ORIG-GUID: E_kdF7S1pPJ8PXbzWqNWr1kHHodW0w-t
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Gustavo/Justin,

>> > We probably should have declared no_of_objects as __be32 to have
>> > avoided this confusion.
>>
>> Perhaps this patch can add that too?
>
> Yes, please.  Something like this is fine:

Please send a formal patch. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering