Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1046733rwd; Wed, 31 May 2023 08:47:16 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6riPjJ7DyTjKpCD1j1qaYql1+rJ8NargtGqNVXdByAaUGqW8JSdX8Duy5YEnpF3cMsJ3+N X-Received: by 2002:a17:902:b718:b0:1af:fd5c:d21f with SMTP id d24-20020a170902b71800b001affd5cd21fmr4046554pls.17.1685548036107; Wed, 31 May 2023 08:47:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685548036; cv=none; d=google.com; s=arc-20160816; b=Gi0N+7sISJMlEJFjGiSEn/WrcbSkW0pZQtfVhXhE+ekcJgfI9ObKoJCPRo4YxZDmvI X5/CCwF0TiGRLN+gl5V3ouJNK+z0g6JC7RdPjO3oNZg0w9GZf1aCWXT2TfsiqVFPcrEi vwdBt6bqOjhHoPdNkNEoLCpDHrudDlz5SsyKpMV9Mim40pxz+56VirCH/FPCpu83lIGg RS0J/AN2MlNAboUhTvQZL36lr+w9IflVYbY9vm2QrZp4+gdiwmhg1p5/0X22aKlqXbrv IMwZXSeAnlXt52Ld1OF4X+VwoTi0XuwmOdKRX8v1tRAECJbjm5QUMU+C6W877cXTEpx3 Boww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gMMLKYR6LwwerFeeNHSp7kotCz7/hIxfivRXb+7S/jQ=; b=gYzCkAf94xIvTf89RJIe5v5rKYbCMh0GRLqzI0il+4j8U7lTJpQUlGbcvzLy0s+CKq /RGagKHbrByTqpFsJIjibVBLo+1BFRS42DwuA8PSHLbrxABU9ijgbc82sYy2tOdDCRLb M0SNZvpwgV3sVJDytyZyUNrZ4pc6ajg98raUsUaNukzq21c/b7WxWMCqixUhcS+f0j43 D3c5rVgrsM+EuE4A53AvXQV9l3PBfzNX3ZEmWeWNzgmRuY8YigHhhz2YWEKN+ZpGsEp1 KTFRhaOxFLm/YUp8U032SXtBX/SepqBKLh34AuZIXuKMt+fTtcVxXrxC5YnASg3DY3RR o9TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=gXtM6WmP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g23-20020a1709029f9700b001ac83d19265si1026091plq.291.2023.05.31.08.47.01; Wed, 31 May 2023 08:47:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=gXtM6WmP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbjEaPfd (ORCPT + 99 others); Wed, 31 May 2023 11:35:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232867AbjEaPfa (ORCPT ); Wed, 31 May 2023 11:35:30 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40C85125; Wed, 31 May 2023 08:35:23 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3f6d3f83d0cso62870325e9.2; Wed, 31 May 2023 08:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685547322; x=1688139322; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gMMLKYR6LwwerFeeNHSp7kotCz7/hIxfivRXb+7S/jQ=; b=gXtM6WmPGHOFnqSQTqssenCj+2JZKiM5GNUQV/R01GBLBCiXsbQOXozk4sA0tpX7j0 DvN19BpMXZfRg0MZI8IjP1ZG11JVfdRnBWYiN9lhWNUgE1cNhqtuCPM3nwa+jTZvPUtL CUPPCl1sbAMBhSdPseMEXkTNrs98m78zO+pJfGvM7Gedh3HvY2IE7JRBNgutfHoJeOAB o2S1tDxy0CUeaLj4Ynyu2bQtCmXiC2UFQRrnBEqknthbvZYRDRjoNVcatE/ljUuFetQ3 1CbYX9rzJcSk2XJxG8EielgtUE/OwUqrAHluVrpcGOzuRhb2JuK0m09wL1fAsza11rEX tLKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685547322; x=1688139322; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gMMLKYR6LwwerFeeNHSp7kotCz7/hIxfivRXb+7S/jQ=; b=AD481OEWt95yzYqh3frH4NOTrjQG0SePPJDhUFsjPNxTk4Qblxm27LxeCAO6pidAin U05KaSGSwzvPa8DhDJPGDzjyMZAEVcNlMFzTR+U2QJ3TMbhfLdl17aXEzsr8KWoD53Ip HGhT5mzBj/cIzyMVms4w83PGmCaNxcb4E6UhT20fFH70KEP8nqDL3e/gVBezGChUCQEp yw2NXCO358AGXeNMIidw8T54rWWFVSmsjHJJvROCEWhISASY6RNbioxaV5upwmBZta/S cmO3BCZo4r2T1i8OI/6jiN5FY9pncR5gYcC59cBy6cwKLSYND+if8ExIbEbsXi/NGbDv ucrA== X-Gm-Message-State: AC+VfDw5ofJRPcrfnaiPCd8jAQXyIObKlSMjDAJACciLHagMVByDO00b IboFXejCP7ECGsuKDipiDlo= X-Received: by 2002:a5d:5903:0:b0:307:8cf6:c2f1 with SMTP id v3-20020a5d5903000000b003078cf6c2f1mr4184943wrd.34.1685547321438; Wed, 31 May 2023 08:35:21 -0700 (PDT) Received: from skbuf ([188.27.184.189]) by smtp.gmail.com with ESMTPSA id s16-20020adfeb10000000b0030630120e56sm7167262wrn.57.2023.05.31.08.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 08:35:21 -0700 (PDT) Date: Wed, 31 May 2023 18:35:19 +0300 From: Vladimir Oltean To: "Sverdlin, Alexander" Cc: "privat@egil-hjelmeland.no" , "netdev@vger.kernel.org" , "f.fainelli@gmail.com" , "andrew@lunn.ch" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net: dsa: lan9303: allow vid != 0 in port_fdb_{add|del} methods Message-ID: <20230531153519.t3go47caebkchltv@skbuf> References: <20230531143826.477267-1-alexander.sverdlin@siemens.com> <20230531151620.rqdaf2dlp5jsn6mk@skbuf> <426c54cdaa001d55cdcacee4ae9e7712cee617c2.camel@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <426c54cdaa001d55cdcacee4ae9e7712cee617c2.camel@siemens.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 03:20:19PM +0000, Sverdlin, Alexander wrote: > Well, it's not only about visible errors, but the driver also refused > to install the FDB entries, so it's change in behaviour, not only > cosmetics. Ok, makes sense. Let's see what will happen with the backport - to be honest I'm not completely sure. If you want to be completely sure I didn't just throw a wrench into your plans, feel free to resend a v2 with just my review tag (dropping my Fixes tag), and you could also add a comment stating that the ALR is VLAN-unaware while you're at it.