Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     Azeem Shaikh <azeemshaikh38@gmail.com>
Cc:     linux-hardening@vger.kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
In-Reply-To: <20230530155608.272266-1-azeemshaikh38@gmail.com>
References: <20230530155608.272266-1-azeemshaikh38@gmail.com>
Subject: Re: [PATCH] block: Replace all non-returning strlcpy with strscpy
Message-Id: <168555010526.195181.15421490997743979443.b4-ty@kernel.dk>
Date:   Wed, 31 May 2023 10:21:45 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On Tue, 30 May 2023 15:56:08 +0000, Azeem Shaikh wrote:
> strlcpy() reads the entire source buffer first.
> This read may exceed the destination size limit.
> This is both inefficient and can lead to linear read
> overflows if a source string is not NUL-terminated [1].
> In an effort to remove strlcpy() completely [2], replace
> strlcpy() here with strscpy().
> No return values were used, so direct replacement is safe.
> 
> [...]

Applied, thanks!

[1/1] block: Replace all non-returning strlcpy with strscpy
      commit: 8e8fedab1194ef90e007636eb3d224c4f8e979a7

Best regards,
-- 
Jens Axboe