Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Piyush Malgujar <pmalgujar@marvell.com>,
        "Wilczynski, Michal" <michal.wilczynski@intel.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
        "benjamin.cheatham@amd.com" <benjamin.cheatham@amd.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "jannadurai@marvell.com" <jannadurai@marvell.com>,
        "cchavva@marvell.com" <cchavva@marvell.com>
Subject: RE: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Topic: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Index: AQHZfoz/HoY7ASH3bUeV4msZv1/xf69KTa1QgABJGICAB3OngIAALJJAgCDtGgCAAYD7AIAAEZgw
Date:   Wed, 31 May 2023 16:23:23 +0000
Message-ID: <SJ1PR11MB608333C6628FE2FDBEB64C19FC489@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230504133224.2669-1-pmalgujar@marvell.com>
 <SJ1PR11MB6083A266C4A869FC9AAA5A9AFC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <SJ1PR11MB608326A6AC3FFE42699DDB40FC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20230509143721.GA10616@Dell2s-9>
 <SJ1PR11MB60831FCB30F2A642B95C9D9FFC769@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <4376a7ba-2f85-6160-b7d4-d5c08b5b3429@intel.com>
 <20230531150342.GA13601@Dell2s-9>
In-Reply-To: <20230531150342.GA13601@Dell2s-9>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4XDVVW27MZcvZgatdz9Y+LoA+EghDujqkKWb1Aap06VNHtRX92nI+1b7GwAG?=
 =?us-ascii?Q?cthM3YnbK4xIiBsQKUNVBVx10Y4mcSBob7PKbNtuWevUfLQ3uDW75AFTEpu1?=
 =?us-ascii?Q?0a/uSr/wQ2dQpVRE7iWB7C979oOUmadyPa0paTA4lUHG//KO3Ag09hzm9nh0?=
 =?us-ascii?Q?mNEOCiOANpGPwAkLCZrDiLoBmOFpK/Gxj+h8VM9jKYqZJultf7XUEYm3gW9r?=
 =?us-ascii?Q?rs+MY1eb6A+VCAUE3NwQ/o8nHlQk9KzujPrItN18jxyBFYFas55Y5BgNnpBD?=
 =?us-ascii?Q?ujEUDrd/pzKZxW7R3eGaeQsgeFCYmGsNM6iXsFf13XWU9DX8kVBXqx6doTbn?=
 =?us-ascii?Q?HDprdJ/6sr6aKTI0ZLQ2UPvbJ3akfXPA+5/l8r0iQ6vzgSTdJ+TacY4bBChL?=
 =?us-ascii?Q?JFii/kE3IaqsIroDR/wVvZdLf98hUbVHnjIwUp0hq7m3ALW4KptuBN4NwGME?=
 =?us-ascii?Q?M6SaYLJivC4TnQVUsrVdpmoDG2Xow92qdc1fC6SsyWzRGuMtpeqdQxZwgr3O?=
 =?us-ascii?Q?WWgqKmiI84nXxwSeVjehDJZdHK7wZTWt5U2yL+v0X+eAHIRCyWNH29YVf7og?=
 =?us-ascii?Q?F+qy4BprrdvRMewDQjuxUeUsVH9ONb/QeCLytzy6lemzkp7W/oe40d3lb3wT?=
 =?us-ascii?Q?4O6umlzAP86DQ5keZrkoO2DjjZVFUBiNiGVHcO8Kl+sv5b/4taYa0inN3SUq?=
 =?us-ascii?Q?EVzfuB3BY54+o+1Hup4ILrXb9ZdKtePxnBrskE0dTPQhd5ye4ippaYRyXDhM?=
 =?us-ascii?Q?hcgkp4HuZ+/Cjp7XXbZ/OHNax6+9+xmhMhTYfEp0b+vUgLwCLVqCRKNGhh04?=
 =?us-ascii?Q?3AuJnnRb2oiSS+wCk/ILDa9QLXQ10E3bqchavNQle5sQMeXr64NJdl6w8YPy?=
 =?us-ascii?Q?3484ZKfrDOqReTHZPox3BvizhWf6OlvePAhOn01/aPPnd91eHcJUNmRiBhhc?=
 =?us-ascii?Q?YMujVRWZvcLWnhdq8gD7kEI8GJIaZRhEXsohZybih5ewlQ1xesSzFFiMffKt?=
 =?us-ascii?Q?N0YmzwVeFz8mltdI5w3RRPl8/9GaTcKYRyeCu5wIyy8ztgcLr7RPdQvCm7WP?=
 =?us-ascii?Q?Cizf985K1pWtI5UjK7Y6oJIiHYHHlcs14YOpG8U4p4fYTF3IB6WtgibxSmJk?=
 =?us-ascii?Q?PF9J4V/yn+BvyOrNJCsB01pjmwngv+WCcraYCE1KAdP5rbwIFTSS7qgki4qn?=
 =?us-ascii?Q?o1mN9N9ma/CdPPKzTTBneeQf5MNliFYkj26qDGTMENcjyUmgs7fAJJZ0oFjn?=
 =?us-ascii?Q?7jmtF4QixyUUm4aFWrxmz6VepQ3jTiAkCJ0i5bJJtx0aHNEJUDZQJBX2HBWu?=
 =?us-ascii?Q?enXd428EuggohJ0ha8Z/ujNOQ3RbPiOo3F+bdbrYgTBfoL/4Kg9bA7yKsTmn?=
 =?us-ascii?Q?pSf10mXmT5fnP9oze5aVqEZsCAG1SwmgDUkwp59rhrOGHRtVjGPFKXBGNayF?=
 =?us-ascii?Q?nTmzS87epIKVFsxiKEiAFklYfS08/tnf6U0Jjg2UeFHM0PurWF6jnRLB8EV7?=
 =?us-ascii?Q?f2cUbSqMg9FVBadxG+2w7HKaYNqcdXUrer5P9FqDnjS6hnnKWRRwrPlKEfmx?=
 =?us-ascii?Q?2R86FuIZQIpzL8ivicg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd2d2ef7-0121-4f7e-2dc3-08db61f35b20
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 16:23:23.6659
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jUEZJIhB4XAp3tczkax/+5OlBWohJy+64S3iTLBx5oIwM85RPN7OCm2Bf1acJ/H6GTJaq5Tz4h5O+rhZQ/5Jyg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I get that we have to support v1 and v2 for backward compatibility, but f=
or the point no.2
> made by Tony -=20
> "2) Incremental systems that have both V1 and V2 interfaces.",
> just wanted to understand if we expect any use case where if EINJ V2 is s=
upported, both v1
> and v2 interfaces shall be required at the same time for error injection,=
 as from the spec,
> if V2 is supported, EINJV2_SET_ERROR_TYPE takes precedence.
>
> This seems to be similar with V1 action types - whether to go with SET_ER=
ROR_TYPE_WITH_ADDRESS or
> SET_ERROR_TYPE, is based on the action entry in the EINJ table where "SET=
_ERROR_TYPE_WITH_ADDRESS"
> gets precedence.

I don't think it will be required to support users mix and matching v1 and =
v2 in the middle of an injection.
So will need some locking between the einj/error_inject and the einjv2/erro=
r_inject action phase.

I'd still like to see the einjv2 injection supply all parameters in a singl=
e write to a debugfs file
and have the driver parse the values.

E.g.

# echo "corrected memory 0x1234567890 notrigger" > /sys/kernel/debug/apei/e=
injv2/error_inject

That would make injection a user-level atomic operation, and avoid all the =
confusion that results
from updating the param1, param2, ... files individually.

-Tony