Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 18:32:56 +0200
From:   Luca Ceresoli <luca.ceresoli@bootlin.com>
To:     Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     <mturquette@baylibre.com>, <sboyd@kernel.org>, <nm@ti.com>,
        <kristo@kernel.org>, <ssantosh@kernel.org>,
        <michal.simek@xilinx.com>, <aford173@gmail.com>,
        <mike.looijmans@topic.nl>, <robert.hancock@calian.com>,
        <shawn.guo@linaro.org>, <fabio.estevam@freescale.com>,
        <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/8] clk: vc5: check memory returned by kasprintf()
Message-ID: <20230531183256.48e1b893@booty>
In-Reply-To: <20230530093913.1656095-2-claudiu.beznea@microchip.com>
References: <20230530093913.1656095-1-claudiu.beznea@microchip.com>
        <20230530093913.1656095-2-claudiu.beznea@microchip.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Claudiu,

On Tue, 30 May 2023 12:39:06 +0300
Claudiu Beznea <claudiu.beznea@microchip.com> wrote:

> kasprintf() returns a pointer to dynamically allocated memory.
> Pointer could be NULL in case allocation fails. Check pointer validity.
> Identified with coccinelle (kmerr.cocci script).
> 
> Fixes: f491276a5168 ("clk: vc5: Allow Versaclock driver to support multiple instances")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

I think this driver would benefit a bit of refactoring, moving all
those similar sections to a single function.

But for the time being your change is fine:

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com