Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 19:02:52 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     David Howells <dhowells@redhat.com>
Cc:     netdev@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>,
        Boris Pismenny <borisp@nvidia.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        David Ahern <dsahern@kernel.org>,
        Matthew Wilcox <willy@infradead.org>,
        Jens Axboe <axboe@kernel.dk>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/6] net: Block MSG_SENDPAGE_* from being
 passed to sendmsg() by userspace
Message-ID: <ZHd9vCcBNtjkqeqg@corigine.com>
References: <20230531124528.699123-1-dhowells@redhat.com>
 <20230531124528.699123-3-dhowells@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230531124528.699123-3-dhowells@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?61BJzjAl+CaFtLMdncEcfnq7xPWk9kFploZSkMglcPWwxib+b2mVTWQ7FydH?=
 =?us-ascii?Q?mCv3lITNnHLoz15a8/nFKeFJzdTvu1kUtrqgeaMKDdMJj3s7sKcBdOTHnAUj?=
 =?us-ascii?Q?TPEVXbIEKF45k4yD6IrF4FVt3RY6wC7jrkwxNPBhwDktR2XDR8mIPFyBEL8v?=
 =?us-ascii?Q?gSN2c1plJFXt5rqYK6hAGsBb3FwZiJ99G59oWdPmh5uXTuLw9rTxNqgs54nl?=
 =?us-ascii?Q?g1Jn84faz3/imQw9Vn2bvfBWsJaAMzz322RmeJoNUxtbfXJXiAnKM927QBRH?=
 =?us-ascii?Q?kM/dMm2xE6bMBGJ7Rmij714EacVtHAW/kStzX8muJ4OooHzV5nbkei5cSukE?=
 =?us-ascii?Q?G1amzo3uE7Tn6JICqk/QfHdrPJmFPNcuHDfMKlN+jQXfG1Y5GOeoqfmX8GNu?=
 =?us-ascii?Q?QNU5ruvh4KfQnhuvkqkdoBgW2PpTXEyjYAaYu4qA1gvbYF6yVMEfNFlW5dEa?=
 =?us-ascii?Q?dP9uhyqkg565qVVI1gjIC0VCcKdNjwTMuMpcn5XxJkrxINHHzNS1Ers+rHem?=
 =?us-ascii?Q?IzNjZGdCACbz/ijz2snkCIFB3+7j400T4yc6oSdpEdks1JIvXgCSpC96e/jT?=
 =?us-ascii?Q?ouhbX6hX/XvFktvWA2ON7vXWHwM9tfIpah9ZvOv7J07YYHoZ1Ra3Z+cVpLGj?=
 =?us-ascii?Q?WAwZMmgwoP6oBPuyr70rQnkLCohuB1HT2iyKQGTDrWG32ywBfpHPypCnKXHH?=
 =?us-ascii?Q?6EkyOHRO/PpLD4GSJeNbJ27AR4NUV0Xuslt4jM4irBEMnvl73lN16S+mniWu?=
 =?us-ascii?Q?3qadZAnHUoX9uizcNdvfxZ2RdL/rvLEVhylP/d4CMMHVUriNlUIyha8aoHA9?=
 =?us-ascii?Q?o6Kv7X0cHL3qZ6bWxkUhQXclCCmOpTf2k9SlLqfZo3xTdlTllM+3Ft58el0P?=
 =?us-ascii?Q?xcNsJMFF+Q4x/3bT/i8X+4+mDU9bda6fC455xiQ84qTp0nVfVFt642Ugjgdo?=
 =?us-ascii?Q?LWh05KWfZJZhmDE+xQzPQ8kaYeNaYNSmB7EQiqpO/zkw5HqnnHWib//IbSTz?=
 =?us-ascii?Q?in57ci3Ur7UW3vnZNtMCauEeX7DsAqGNubrRG4Lao5o3PW85RAaBBoUC5Gbw?=
 =?us-ascii?Q?XHEb860Irat2JwXnmnSE9qzEvP0BQ8v2da9RUcfug68u7YmgmnMSFNv2q5Wh?=
 =?us-ascii?Q?YBMj+V5QahLAoPzSoTbvvn787/UNI9L+7ca0TV/AbSGlucghr8m+Usqxck1O?=
 =?us-ascii?Q?ZIB/QoVjjhHpqlEOkE6o6gl8pDaJWH0CwCqCgotdXhELAKhih1qASKyDbHg+?=
 =?us-ascii?Q?63g87DjCVzYZcOID6oJbwvwoIWzDGdYkqzeuNivlL1JKHFSB8M4OT4/Mj/nG?=
 =?us-ascii?Q?evqcQznAlPcqlFvmqB2u/k9n4lXd9p+8HvdUZjEKPl8wrMlAeUJgsiJTljTq?=
 =?us-ascii?Q?JcYfMItOBxOljsVQdNLSQk1lLYxr6iEZK9zDtnizhBZ/9xuerFtAimUVFDfU?=
 =?us-ascii?Q?I/fLNfWc35S3l44DmKOBlqiKz4cbc14rtQ10n32w3E3bnLT8tt1QPXE979An?=
 =?us-ascii?Q?2xUaRj0C8daKg4YvrhiJdIKsUzatnVIQdvMZ9wi974F5MbeQivJUlyUfBDcR?=
 =?us-ascii?Q?e5yvhJ/9cc4vRvkg0tSV+VL0jLIQcXnlCpElN31qAeWSrOrMey9AlknIXWKs?=
 =?us-ascii?Q?CinMzkUqmZ4GScsMF30P98Qj6SeXwC8H0DSOkwsbjhakp4F4tVuLIGo93RMH?=
 =?us-ascii?Q?OhUkrA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1fcdcbf-5a09-46f8-caec-08db61f8e399
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 17:03:00.2736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 44HFhWcAyLr5fcV728HBXFWxkHsQGS5keuMgPfEiBaZQm5mcY12dEwFjRegkVcJ0kFQ9B2gkBoM0qfH4dz039m/ub3n25bjertEmEId58w4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4839
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 31, 2023 at 01:45:24PM +0100, David Howells wrote:
> It is necessary to allow MSG_SENDPAGE_* to be passed into ->sendmsg() to
> allow sendmsg(MSG_SPLICE_PAGES) to replace ->sendpage().  Unblocking them
> in the network protocol, however, allows these flags to be passed in by
> userspace too[1].
> 
> Fix this by marking MSG_SENDPAGE_NOPOLICY, MSG_SENDPAGE_NOTLAST and
> MSG_SENDPAGE_DECRYPTED as internal flags, which causes sendmsg() to object
> if they are passed to sendmsg() by userspace.  Network protocol ->sendmsg()
> implementations can then allow them through.
> 
> Note that it should be possible to remove MSG_SENDPAGE_NOTLAST once
> sendpage is removed as a whole slew of pages will be passed in in one go by

Hi David,

on the off-chance that you need to respin for some other reason:

	s/in in/in/

> splice through sendmsg, with MSG_MORE being set if it has more data waiting
> in the pipe.

...