Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 19:58:19 +0300
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-pci@vger.kernel.org, netdev@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Michael Walle <michael@walle.cc>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH pci] PCI: don't skip probing entire device if first fn OF
 node has status = "disabled"
Message-ID: <20230531165819.phx7uwlgtvnt3tvb@skbuf>
References: <20230530231509.4bybb5nw4xyxxq2m@skbuf>
 <ZHd8Ig7LzHqseAnq@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZHd8Ig7LzHqseAnq@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VBqTvcPoSu367UXKjTmMeCZzvgFKzRAMpE7jiQppHZGLsvsLLWlp+mUp9n5j?=
 =?us-ascii?Q?PWpvP0qNqBs5SWShcu7wLWQmIWXdFfpdBGMH+z0VeeoLa+s4wEyqCPfChvUJ?=
 =?us-ascii?Q?qGp0RvO9lcq9mEDRTpfDDe0tSpZcdGECgTpkIR436ezNhD0faJucYhsppLWm?=
 =?us-ascii?Q?tBkkjpgJ9i1GDxE/tepsIXxGdQfVK9KiZag/2NqJVF02nMl8KliFhgcosUUC?=
 =?us-ascii?Q?05rwrb4/Kobz/sXy/5Fubhoel3Q5d7qIb9yDUValH0jRciX3p9JLuoeCrKxx?=
 =?us-ascii?Q?/5bntieaGqVNVner6ikrKFBa+P6rePLikfzFf9Pdm0R8m5n2H2SecMjN4YXm?=
 =?us-ascii?Q?ccqqECdjpJ21znY03OPTvnHHNVVDzaba9Yf183NmuZLijdYh3bFVKl1UD3Au?=
 =?us-ascii?Q?78aF+UDJhe7SNMpFhekq+8vz6llFMZgZgNkO+H+/uCBLOapnd7tVWn4Vw/V4?=
 =?us-ascii?Q?NSB7wogA5D4OgdpwdPRjpYlK9+e2FsHsRRpiAXJK75SaGHaZZEpXdF/X/Gvy?=
 =?us-ascii?Q?1D1Ph6NKv/3KayHUfPHgkinG6WzZxHmlhLXEuHqVBxRA5EQwb36AS21erLsp?=
 =?us-ascii?Q?KmlaOnztDMb0yCln6HZhEqMY7Xt+jH3jyJa/iLmdEfNjRAc+M1YHet0IQwCE?=
 =?us-ascii?Q?/Az2gqa57YOeN08jtsxoVXS+sJTvFLcoKaVQ0cS5dl+4IgnMk/J3HhR+j3QS?=
 =?us-ascii?Q?D3LuxeiV0KZSQfOSE8fe0o1uHHteNclkzdWIs7uMikTvyt/1Ns3paXiU7Vgw?=
 =?us-ascii?Q?56nSfnMCol9r2lp4uePhQI7AFPfzu+0P/06vZ3699Hj1pJZZn3qFcoyFi9vs?=
 =?us-ascii?Q?ToYDVpV0Suhc3LYCRvAhRp/51GOJAmGWYS0wpn0Df68UOrl6ivQvGZe9PpuK?=
 =?us-ascii?Q?0y7suzb4fefvlTHEPsVyV7U1rbWbvaVW9wlYhqH4/xFAC50RXVHnwUB8tuCa?=
 =?us-ascii?Q?/j//9MD2iRrppLwAXZCiDxhS5C6SLyQr+s/yQrAO+8gFxt39CI0XdEh3w5hV?=
 =?us-ascii?Q?KFpjdWYKEP1nI5YPSpMvliyZiRS9vm9zJgdIYvYdihXW6KiROs9FSIycN3Wb?=
 =?us-ascii?Q?6vTYrEBPmm6/QuWtPjCiw9WgW9ADfQtqQv2urM/9VcVDzsTCZzuBbGNLfKj3?=
 =?us-ascii?Q?dMD4S9OmeTZxDDk+xKdO+Q1T5kic0twmlf0shzzJDltm/yRlqkofZFMX6A77?=
 =?us-ascii?Q?bwai+LmSgcdkWb06JuvLOCWkyl3Zuey8V72OUTGkw5UprWQ1IA8BeDifI9ZT?=
 =?us-ascii?Q?MC8VvEV3NIF0IsdotIBajfctmYZlTQZNTwy7HrR1eCdC1ZiK82GmQSetRVm1?=
 =?us-ascii?Q?/Q8/4UallkyK8sH67IvBFOAU9W0FnGr/BBR2cctbaBitOSA3FHwZc28B4Zyd?=
 =?us-ascii?Q?AmSpKJC+iXFMw63KvnZxoy7Q2NfEzYLsw+SoVL9tRYwCZdA7cS5PHzkXPb7u?=
 =?us-ascii?Q?Zwh/+UB/MMRyVZd272PEMTw0G0fqCnF2gu4eF76wRVTUCfkv+vVFDmQiisYu?=
 =?us-ascii?Q?7sT5eUcy7Oac121B/e3TFRl7roZddPZ2L2WtFxfZSCmFB4rrfOm+M4fzgaoZ?=
 =?us-ascii?Q?LaasE4gZ6wa4dsBoqziMXqJ1QVb/nJ7FIu9/3n+Jt3r1xV9yJLksmtzNRphG?=
 =?us-ascii?Q?iw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5421563a-34c0-4e4f-73a9-08db61f83e54
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 16:58:23.0111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6raFeGySd6Nm3PJfxS2Y7YHXfIyspH13BRAg+jn2F8dBx3NGpSENuE4zYyBOdFBueXA+SObsM9C26e5aE70OoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8395
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 31, 2023 at 11:56:02AM -0500, Bjorn Helgaas wrote:
> On Wed, May 31, 2023 at 02:15:09AM +0300, Vladimir Oltean wrote:
> > On Tue, May 30, 2023 at 05:27:24PM -0500, Bjorn Helgaas wrote:
> > > Ah, you're right, sorry I missed that.  Dispensing with the SERDES
> > > details would make this more obvious.
> > 
> > Lesson learned. When I had just gotten out of college, every time I asked
> > the coworkers in my company what they're up to, I was amazed by them just
> > proceeding to tell me all the nitty gritty details of what they're doing
> > and debugging, like I was supposed to understand or care for that matter.
> > "Dude, can't you just paint the high level idea without using dorky words?"
> > Now I'm one of them...
> 
> Haha :)  Communication is the hardest part!

I know...

> What bad things happen without this patch?

It's in the commit title: probing the entire device (PCI device!!!) is
skipped if function 0 has status = "disabled". Aka PCIe functions 1, 2, 3, 4, ...