Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 19:08:10 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Gerhard Engleder <gerhard@engleder-embedded.com>,
        Amritha Nambiar <amritha.nambiar@intel.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Roger Quadros <rogerq@kernel.org>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>,
        Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>,
        Oleksij Rempel <linux@rempel-privat.de>,
        Jacob Keller <jacob.e.keller@intel.com>,
        linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        intel-wired-lan@lists.osuosl.org,
        Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Subject: Re: [PATCH net-next 2/5] net/sched: taprio: replace
 tc_taprio_qopt_offload :: enable with a "cmd" enum
Message-ID: <ZHd++lqP8EQocWQC@corigine.com>
References: <20230530091948.1408477-1-vladimir.oltean@nxp.com>
 <20230530091948.1408477-3-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230530091948.1408477-3-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bg5KahjNYj2IYeLi7fPOxS85Tnke5FVe8S0H5vlN/yJQbS9NMW8itle5VIzQ?=
 =?us-ascii?Q?1YPvxqT/OGFlaSTgpwwY/oFAu4pzqqef9FrO++7uBGkpfBZwzK60TffaiBDC?=
 =?us-ascii?Q?kkjwoLUMP5W6ZYyIBz75nx/RmGcGn5DlSf4syeKGIuY1YVS8Vrd4qgGQaxah?=
 =?us-ascii?Q?TH5GqCetzqJsljikRX/ct04uNWVTvmLjOFugnfO7KkUaj1grDzv/vPlcAWl6?=
 =?us-ascii?Q?aHDzu5/RxswAWBv3OzScG1a/1WHjW4PkTvnesaN+ct23MMwsibticDWG8NCS?=
 =?us-ascii?Q?lCDHMlBrinSUL1sMSfE1mxyWIbeGSsTVPU7KuEtKWyRbwxtfth69E0IYIbNL?=
 =?us-ascii?Q?94PFAImZHcpfEEDFQrvCShiPgqRoqQN6G32A+98V1bdH7iopjTz42lNiEjSu?=
 =?us-ascii?Q?WmykJ6RAGozVOTBUsd/sp4a8WCsX9mbwRaq2C0mK5HAYGylaAB5L14eP30Ue?=
 =?us-ascii?Q?hIeXpCiUL3lWxYf5AQztcpXksVu5zj+JC2Pnx4Sqq8NXOQEEhyXT0PMj81WK?=
 =?us-ascii?Q?4yoJ+jR9eZBxzG6D+5vmH7OXiiuZ+PheRxSbugwQlh1noFIlEcy37nS6HnSX?=
 =?us-ascii?Q?kPVZOnfEhNCTl0zyajUhlv1qhwfu9eHUJPzh4zUE56ARji4RUBZPD67xxP3U?=
 =?us-ascii?Q?xsNG8JKXZiIsAhP5FLtcNy1UGisQVkVnVhLFOTvBcOppJe2GpK0l0qgibsHw?=
 =?us-ascii?Q?p7lkgmlj8jEXjl4do01bQ6BUN1UK/Zu2n9NqJmDj208iOmarRUFf3PPNS7tr?=
 =?us-ascii?Q?+y5yuzjPiIVKZddtX6nBHy6fdsgxSjukUHQJoYmrEE0d3Orp2fj45x+4wpTo?=
 =?us-ascii?Q?hUoHQvqbebpB72+fMAC9jckChyWSbA+QIUYO7NskdDEX2PGYKa5nrUAGyzOs?=
 =?us-ascii?Q?exfTqaGMPH0erXGP6a2qynB+vlQLTBRPbMi0P5DMkWnUcSV27uaV65eekQGD?=
 =?us-ascii?Q?8ZkQMLCB5cnN1X6aqrIUFm59+WRNlbdql7eCCy5wrgh6dxiHiC0RSYDzHdlX?=
 =?us-ascii?Q?tTrEbBxHM/GR14OcQ23QPE9Vrj7i/FP8z/wyGTeiwEe/Mf0cwnbaz+1G4uiz?=
 =?us-ascii?Q?D3kWh+tUi5yBIiPvBiD17Rst1431rWG6PXHq8QlxHqfFC5BPlzFWZZ/MnbBl?=
 =?us-ascii?Q?ihUD8tmz5noJ4q8fTrTtSzFMPICs39o8Y6xEZXNeWOIamDF7WLq9qusaMB2c?=
 =?us-ascii?Q?NaEv3bsLLfUX4F9afcsn8onfQIMXvzRdsf0VtpXugxi9Hn2Y6vfbJFhqGOnE?=
 =?us-ascii?Q?szSQdDZdx6bt1U8Wm+/6aLUkRnPrda3J9n32nCfpN1V6LSLOtnxsV6KSfVXu?=
 =?us-ascii?Q?5tWB9XV6oHJhNeHvhK9uB7NbWFOUPOsheeY77nVfzO0MFxJb2hB788Hlj9pn?=
 =?us-ascii?Q?cAX8wFYPdh3GxdTsDO/3Vd2FpSS83JU+imtPf4vAffmbDmjLCU6IIBXwmwa4?=
 =?us-ascii?Q?5cDQ7yHt5bApoulXF48tPkmFl/FUMvguaKw7Z4LiPvLoqy/8AKkerBmKZ08B?=
 =?us-ascii?Q?Ufy5xgZKmk+6BC+76IBMpmCXyCOtHXxhJ7XmoVfwApmvFvDtZupihDxj+sUi?=
 =?us-ascii?Q?pfjcttvhI2deAKeQQiXVOtM1C6l9l48jgv2pgW2s8kw719qyGwc5MXPATVm5?=
 =?us-ascii?Q?UM7hBvx1GvOFI/QpawOvAjgS/mIfn0Fr/WkyuKenwgsy2sWa7lOt6zY7I1FF?=
 =?us-ascii?Q?7eWjYQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0e23b032-5eac-4bd0-d94a-08db61f9a2d4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 17:08:21.0977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FCd6RnTiuUotpy1/PeeO9ZxcAs39SISZfptxVELNuvztXQYX/r4zVARMnQt1LN85azFVZIiltRXqmAIbEwFvbtDgoBigtmXHcZSgwSgl2zc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3758
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 30, 2023 at 12:19:45PM +0300, Vladimir Oltean wrote:
> Inspired from struct flow_cls_offload :: cmd, in order for taprio to be
> able to report statistics (which is future work), it seems that we need
> to drill one step further with the ndo_setup_tc(TC_SETUP_QDISC_TAPRIO)
> multiplexing, and pass the command as part of the common portion of the
> muxed structure.
> 
> Since we already have an "enable" variable in tc_taprio_qopt_offload,
> refactor all drivers to check for "cmd" instead of "enable", and reject
> every other command except "replace" and "destroy" - to be future proof.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

...

> --- a/drivers/net/dsa/ocelot/felix_vsc9959.c
> +++ b/drivers/net/dsa/ocelot/felix_vsc9959.c

...

> @@ -1423,6 +1423,8 @@ static int vsc9959_qos_port_tas_set(struct ocelot *ocelot, int port,
>  
>  		mutex_unlock(&ocelot->tas_lock);
>  		return 0;
> +	} else if (taprio->cmd != TAPRIO_CMD_REPLACE) {

Hi Vladimir,

Do you need to 'mutex_unlock(&ocelot->tas_lock)' here?

> +		return -EOPNOTSUPP;
>  	}
>  
>  	ret = ocelot_port_mqprio(ocelot, port, &taprio->mqprio);

...