Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1202450rwd; Wed, 31 May 2023 10:42:41 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5//jn6sEKPsNV5/q6hMmP/hUj4PA4HFHDJ64Uo1lLO5G5huHlxs55yGzu0K5WhRSIFphg6 X-Received: by 2002:a05:6a21:2c97:b0:10e:d4fb:b031 with SMTP id ua23-20020a056a212c9700b0010ed4fbb031mr4202858pzb.61.1685554960797; Wed, 31 May 2023 10:42:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685554960; cv=none; d=google.com; s=arc-20160816; b=d1Quwe0YtVnhCbD9xOuUuMCPGaPWCqHcAPGuMMTzr5vNueeOuN5B0RkFWOPJyxZOYD NBbgdApIExSd0OzJCT6WiLg9+PtQJkNNEzketn5y843y/SQ+NH3bmrjiyojf1SRsVIaV vv3OW7LeN/gTyvGoh1o2m307Y84hFpT0VfZnA4JtKLahx5sVCmhP9jnPGXRyVYlsFZtH s0FI18R7snHxY2ND2d2EC+IsrFGhqUDZk+BBfN1Kq+WFzVKMUWQPylKScd1aDwMAl6R+ 0GAbngNOIpEnolFWusHa88eYd649GZWzBu3i+2qp0bZroLhKKVT+wAqDDwtif4W+xFrK kLqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=76vg60iW/EsEINmD+Bil9N8BO8s1pVlIY0spf2KHpnw=; b=CVLtCvBCz8g8YAA/07Ex7p+9mtPBdCkbHsDW896a19BN1sGUFbXFyoz7X66rE24QJP WT1XGOoF16Z0drRCYwQX0luEa25sACGUcCqyK295FWPo3gwZI7Ig2Zb9XXvX12A/ajDA 2Hn9iQOrJYG83/FqaXrCmDMMw2uXTZKPD6cI8hGE60ehBdkvyV7wjG6MQak7AjOfufBV Mvigezd583plH7Ghap6RJigxEisDGUdF63uDeDlJZXYvbeTUv9kuUxhKGKraGI/Z050w toEGnScECrh/7XIJdgxKRdNj7ANMROkdsdRzK8frZfMqsoaIj+UCZDWcbcyki+1gB8Ws TdfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=AqFFPdnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d66-20020a633645000000b00534839d1219si1277365pga.138.2023.05.31.10.42.26; Wed, 31 May 2023 10:42:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=AqFFPdnW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229938AbjEaRHx (ORCPT + 99 others); Wed, 31 May 2023 13:07:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjEaRHu (ORCPT ); Wed, 31 May 2023 13:07:50 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A00C91AD; Wed, 31 May 2023 10:07:46 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-bad97da58adso6736455276.1; Wed, 31 May 2023 10:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685552866; x=1688144866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=76vg60iW/EsEINmD+Bil9N8BO8s1pVlIY0spf2KHpnw=; b=AqFFPdnWQgjfaEVYQJhTRCZLbnnoP1T/OuVLPkM82QjyaLFvqLZkQvnLuFiUKznvbg 5mnVnDzBYCxL/hKfAytTdiJQOLdEgoCvVB6AsWcKlQhmLeM+4GvfhyiTSKwYPOLeHCCr tKsAHo6lumCftCJDl3h3MmoFksS2OV/aCzedbK+fKrjLdgkBktemgwYem72t/j5R6V2U dXvny0xVl+mUZs5tJWBoYgmrvu6ydBZH+L8ohdlnNwHbsfpSkJkkjqZOpjXj7C1UA6It YihUAZcK76QDC7mPDkjbTJd7R2xdv95bumAe3vbat6Ttu/5QCDTK70W5HCpqe9JAsNCm BEUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685552866; x=1688144866; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=76vg60iW/EsEINmD+Bil9N8BO8s1pVlIY0spf2KHpnw=; b=lDdTVvoOEbB5VpsQbrhgGsqG2Cvqfj5KUOiDMdy01TjIMHVWvsjmTPmcElblPsuryX XYw+nZ1qaxRTk8LIP6fCbF4lZnlIUS6lJZfl9JqNCulnI7xrTVr/tPE0txPaW7l6QYJO XxNIY+eN6ZKnvZIg3i1TiAHf9WdALN7SCc3IqyXHu5cTtbQyPoH4BNEiQrwC9H65NdLS 5XGSjdny0YmP6RADE4fxyZ2wKFkGdyOdTaLQrx7EVu85pRNCZbHh1ye4y+cpy+6br/2j ZwHWyweJ2trWvA9Yr0nkBNPtArqXqgjMRu/AtpzHFrAAvj9js0VM7Wh1EqSjn7NkQ9HP ns7g== X-Gm-Message-State: AC+VfDx2/0d4F6ZfpaZbnp1FLV8M0aXATzUqCQa9ybhr/3l6x+YfF+uw /pqux/K/4XP+c4ylx5X7dO7bDtJ9GSGwtixXbc4= X-Received: by 2002:a25:5087:0:b0:ba2:ca56:7206 with SMTP id e129-20020a255087000000b00ba2ca567206mr7209029ybb.17.1685552865848; Wed, 31 May 2023 10:07:45 -0700 (PDT) MIME-Version: 1.0 References: <20230424081112.99890-1-benno.lossin@proton.me> In-Reply-To: <20230424081112.99890-1-benno.lossin@proton.me> From: Miguel Ojeda Date: Wed, 31 May 2023 19:07:34 +0200 Message-ID: Subject: Re: [PATCH 1/4] rust: macros: fix usage of `#[allow]` in `quote!` To: Benno Lossin Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 24, 2023 at 10:11=E2=80=AFAM Benno Lossin wrote: > > When using `quote!` as part of an expression that was not the last one > in a function, the `#[allow(clippy::vec_init_then_push)]` attribute > would be present on an expression, which is not allowed. > This patch refactors that part of the macro to use a statement instead. > > Signed-off-by: Benno Lossin Series applied to `rust-next` (with the newline added) -- thanks everyone! Cheers, Miguel