Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jon Kohler <jon@nutanix.com>
To:     Eric Dumazet <edumazet@google.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Pavel Begunkov <asml.silence@gmail.com>,
        Richard Gobert <richardbgobert@gmail.com>,
        Menglong Dong <imagedong@tencent.com>,
        Wojciech Drewek <wojciech.drewek@intel.com>,
        Guillaume Nault <gnault@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Stanislav Fomichev <sdf@google.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Shmulik Ladkani <shmulik.ladkani@gmail.com>,
        Qingqing Yang <qingqing.yang@broadcom.com>,
        Daniel Xu <dxu@dxuuu.xyz>, Felix Fietkau <nbd@nbd.name>,
        Ludovic Cintrat <ludovic.cintrat@gatewatcher.com>,
        Jason Wang <jasowang@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] flow_dissector: introduce skb_get_hash_symmetric()
Thread-Topic: [PATCH] flow_dissector: introduce skb_get_hash_symmetric()
Thread-Index: AQHZk+RxmdTXxpqVM0m0KZDS1nnqo690pFCAgAAD0oA=
Date:   Wed, 31 May 2023 17:47:25 +0000
Message-ID: <30861EDF-D063-43C7-94A7-9C3C5ED13E54@nutanix.com>
References: <20230531172158.90406-1-jon@nutanix.com>
 <CANn89iLE1d=MuSMTisEbLh6Q_c4rjagd8xuRj0PC-4ua0pDRPA@mail.gmail.com>
In-Reply-To: <CANn89iLE1d=MuSMTisEbLh6Q_c4rjagd8xuRj0PC-4ua0pDRPA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T0xEYW9NMklwSlRVUURzMlZjTHc5ZVA0SEw3NW1JSERpQXNvZm1aL2txTmIx?=
 =?utf-8?B?WXdRdmpmN0R1K0JuZmF2TEZGZTEyOXpnaVRkSXo0YmRzb00xQTVrK0lDUEpj?=
 =?utf-8?B?MC9PakhDRk9QNUpZK1lRTTdrVkgzQlVwT3U5NTQ4dkZIZjRhV3pqdEs5U0E0?=
 =?utf-8?B?R1ZpaWZRMjAzNmlUTlRQWURIRytYQWRWTGJHL3BtS1Q0aVRpNmR5L2xmRXZp?=
 =?utf-8?B?WC9kY3o0eUs2SU45OE1LYzJwaGwzcVQwT3dVWjYwL09GdnVHaDRxZnZxajZz?=
 =?utf-8?B?cm8vdm52K3hBdi80ckZsVG10SS84L3hWd3IrM2ZJYm44YThSOTRYeFdjaXVZ?=
 =?utf-8?B?NXdDRVJwckJaOU90d2FudHhaRjBJOFlvM3JSY1hvWUlIZlNpVUx4N016eUFN?=
 =?utf-8?B?Y0R6dDg1bC9XS0JQcmQwWlZtZml6SXMweHB2R0ZEQzF6aGNhb2JVa1hmVjNa?=
 =?utf-8?B?RXZWdml0V2dnVzk5dktxUGludzNPRFcxYTQ2VjY3MUk3amJBcGo5NmkxRUV4?=
 =?utf-8?B?QjFHRlVBdzlCZW1IQllZQW04dHpldXovQWZzekVuT0NwWE0raUF6clVGWkp1?=
 =?utf-8?B?SlUzdzdrQ2VxTUlGWWF4RVppR2toV0kxM2Z4NTFRMmlET2c3aU9hVkMxTmRn?=
 =?utf-8?B?QzI2SHNIWkNYWUR1anFwVFFXWkpJb1AyakcwY29lOEdRaDlYMFNpSzBDczdI?=
 =?utf-8?B?M1Rib2VHWS9UTlIwQWRJZkoyZjVDdTFIV1NQaGJ2d1Jna2UxeEdYYkpCeXFr?=
 =?utf-8?B?dU1OOTcyRTZ4Z0krTXp0QXRNTVZuZENCZ09GRHRoazdYSGxycmRLOS9aVk1L?=
 =?utf-8?B?Z0llTmltdytONkpKV1JNenl0dERXV2MzRGVXN3JnSXBjUGdmckQ0c2ZtaEl6?=
 =?utf-8?B?aVZiMDFGZkxobC9XMWNleEh5OGF4RzVGbTdGbUVJMkVjeWpRd1QzMXhLaWk1?=
 =?utf-8?B?SDJod1FueHZuZE9WU21SbjFTQW1NcXJMMGgyTVArK2VmOE9NVUM5QlBVMEZz?=
 =?utf-8?B?SmdXM1ViWXloT3hQTHhUcjFpUmFlSU8wL0R2T085SStSeklodEtLQUNjZDRM?=
 =?utf-8?B?RUF1Z0JCOU1TbUdLWE1ydHZYeDYzQlZVVko1MVFMTlZoYk0ySEdtbHcrUCtT?=
 =?utf-8?B?QmI3TldLUHdwNEdHTmZSck92aUZxVmNYc1dtbm1aQ1lURXNaaWc3N2tLdTI3?=
 =?utf-8?B?cTJvTHNqajlnMlEySWk4SjB1dEloYmpCSElGN2x5NURIMTR3M3VleHhuZkQy?=
 =?utf-8?B?emkzYjlSUk03NG9RSjcvUnJtQ29kSjJBMFVaZGpjcnZOWG1UZU1xYlR5dHlv?=
 =?utf-8?B?Yjh2dHI2b0l2TUhKV3V6UThyOXhWdkRhZ1BqejBhOHR6cTVKZjdnV21YV3gw?=
 =?utf-8?B?NE94dWgrVitwbTBzSy9sQlJtc1dyb0F3R0RBRThlVzdhSXBMc2VkTzNTRnh1?=
 =?utf-8?B?RSszZDdzYVBRL3NTb3lUdlIrOFl4YmVQd3ordlEzM294V1BUVFF3SytKZU9G?=
 =?utf-8?B?QzB6NGtZT2NJeDl1ejV5TExHRnZRTk81dUk2dThPVGxuNDVLMldoRDlSZUYv?=
 =?utf-8?B?clVhL0lMdDlLM3lORUh3aXd6N1B3UG5EZ2lhcmZUbncrWWpsSy9MRmp1QnNG?=
 =?utf-8?B?cVFNOUlXNlIwU29DT2xUM3J2alZOd0hSMFlETUgwQUxtZzVTZ3N0dHA0UGN4?=
 =?utf-8?B?QmVTdG1RL2pTTnZHKytvTkhhUXd6bURvOVVuRTRYZFM5c1VyNnhQK0xiRnRN?=
 =?utf-8?B?VFNIQlpyY0taQXAvOWhsUnN6SG81MW1GQkgyYWw0STNZNFBxNit0R1lpckI3?=
 =?utf-8?B?Z2dBY0tvdThDUWxScUpZalZlOFY0VUNCQWRRQVNzdmlZTjE0S1ZmOUNFaloz?=
 =?utf-8?B?dGtaV3dLeVlISmpvbDZQS2VpQ3dJZm92TGtpSjBvUm1uTkJnemZ5eG4wRlN4?=
 =?utf-8?B?enZiQndsVFJRQW54U2Z2d1pMaExjMHI5RHluVkdINEdVNTMzWjJCbzIreWlI?=
 =?utf-8?B?UUdjaUNnMlgraVdHeWV2aUFsUjQrcUQrWVgyWlEzSUFYemllakVHdHlIcnBP?=
 =?utf-8?B?VVJkODdKYmpxUU5XM2ZGSTBBU0VEVFpUVWxRVmJjRWM5encrWHhieXB3aU85?=
 =?utf-8?B?NnFITzA5K2grYU9mQmJBVm9TZUZkcnYrR0hmQm8waldXRjBuMGluMWswcnVy?=
 =?utf-8?B?MThXUXRsbTJiZWVBV0cxcDVkR1M0Yytkb3lZTm9wMmFEZGZaYlBXRGlKckZH?=
 =?utf-8?B?ZUhmTXd3b3I1NjFDZzFLYm55YnhnPT0=?=
Content-Type: text/plain; charset="utf-8"
Content-ID: <378C8E3DEB1B674DA4F288CA1F556DA2@namprd02.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: nutanix.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR02MB4579.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85db4e99-f620-4fb3-8f75-08db61ff1888
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 17:47:25.9038
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: bb047546-786f-4de1-bd75-24e5b6f79043
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /sZY5SFo7eR5i1dq3wvBzU6/zU+9NajywkQqUYQuZuX+S+MOQADyhFr83ApGSFNeNjeCVXKXRbwBv46T/y4Vlbs/bLRX7+jEkqHUu3SWQAo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6630
X-Proofpoint-GUID: DNj_pxSHeE8IOF1jBPAPNcCqGH-4Ea40
X-Proofpoint-ORIG-GUID: DNj_pxSHeE8IOF1jBPAPNcCqGH-4Ea40
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-05-31_12,2023-05-31_03,2023-05-22_02
X-Proofpoint-Spam-Reason: safe
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

DQoNCj4gT24gTWF5IDMxLCAyMDIzLCBhdCAxOjMzIFBNLCBFcmljIER1bWF6ZXQgPGVkdW1hemV0
QGdvb2dsZS5jb20+IHdyb3RlOg0KPiANCj4gT24gV2VkLCBNYXkgMzEsIDIwMjMgYXQgNzoyMuKA
r1BNIEpvbiBLb2hsZXIgPGpvbkBudXRhbml4LmNvbT4gd3JvdGU6DQo+PiANCj4+IHR1bi5jIGNo
YW5nZWQgZnJvbSBza2JfZ2V0X2hhc2goKSB0byBfX3NrYl9nZXRfaGFzaF9zeW1tZXRyaWMoKSBv
bg0KPj4gY29tbWl0IGZlZWMwODRhN2NmNCAoInR1bjogdXNlIHN5bW1ldHJpYyBoYXNoIiksIHdo
aWNoIGV4cG9zZXMgYW4NCj4+IG92ZXJoZWFkIGZvciBPVlMgZGF0YXBhdGgsIHdoZXJlIG92c19k
cF9wcm9jZXNzX3BhY2tldCgpIGhhcyB0bw0KPj4gY2FsY3VsYXRlIHRoZSBoYXNoIGFnYWluIGJl
Y2F1c2UgX19za2JfZ2V0X2hhc2hfc3ltbWV0cmljKCkgZG9lcyBub3QNCj4+IHJldGFpbiB0aGUg
aGFzaCB0aGF0IGl0IGNhbGN1bGF0ZXMuDQo+PiANCj4+IEludHJvZHVjZSBza2JfZ2V0X2hhc2hf
c3ltbWV0cmljKCksIHdoaWNoIHdpbGwgZ2V0IGFuZCBzYXZlIHRoZSBoYXNoDQo+PiBpbiBvbmUg
Z28sIHNvIHRoYXQgY2FsY3VhdGlvbiB3b3JrIGRvZXMgbm90IGdvIHRvIHdhc3RlLCBhbmQgcGx1
bWIgaXQNCj4+IGludG8gdHVuLmMuDQo+PiANCj4+IEZpeGVzOiBmZWVjMDg0YTdjZjQgKCJ0dW46
IHVzZSBzeW1tZXRyaWMgaGFzaCIpDQo+IA0KPiANCj4+IFNpZ25lZC1vZmYtYnk6IEpvbiBLb2hs
ZXIgPGpvbkBudXRhbml4LmNvbT4NCj4+IENDOiBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQu
Y29tPg0KPj4gQ0M6IERhdmlkIFMuIE1pbGxlciA8ZGF2ZW1AZGF2ZW1sb2Z0Lm5ldD4NCj4+IC0t
LQ0KPj4gDQo+IA0KPj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvc2tidWZmLmggYi9pbmNs
dWRlL2xpbnV4L3NrYnVmZi5oDQo+PiBpbmRleCAwYjQwNDE3NDU3Y2QuLjgxMTJiMWFiNTczNSAx
MDA2NDQNCj4+IC0tLSBhL2luY2x1ZGUvbGludXgvc2tidWZmLmgNCj4+ICsrKyBiL2luY2x1ZGUv
bGludXgvc2tidWZmLmgNCj4+IEBAIC0xNDc0LDYgKzE0NzQsNyBAQCBfX3NrYl9zZXRfc3dfaGFz
aChzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCBfX3UzMiBoYXNoLCBib29sIGlzX2w0KQ0KPj4gDQo+PiB2
b2lkIF9fc2tiX2dldF9oYXNoKHN0cnVjdCBza19idWZmICpza2IpOw0KPj4gdTMyIF9fc2tiX2dl
dF9oYXNoX3N5bW1ldHJpYyhjb25zdCBzdHJ1Y3Qgc2tfYnVmZiAqc2tiKTsNCj4+ICt1MzIgc2ti
X2dldF9oYXNoX3N5bW1ldHJpYyhzdHJ1Y3Qgc2tfYnVmZiAqc2tiKTsNCj4+IHUzMiBza2JfZ2V0
X3BvZmYoY29uc3Qgc3RydWN0IHNrX2J1ZmYgKnNrYik7DQo+PiB1MzIgX19za2JfZ2V0X3BvZmYo
Y29uc3Qgc3RydWN0IHNrX2J1ZmYgKnNrYiwgY29uc3Qgdm9pZCAqZGF0YSwNCj4+ICAgICAgICAg
ICAgICAgICAgIGNvbnN0IHN0cnVjdCBmbG93X2tleXNfYmFzaWMgKmtleXMsIGludCBobGVuKTsN
Cj4+IGRpZmYgLS1naXQgYS9uZXQvY29yZS9mbG93X2Rpc3NlY3Rvci5jIGIvbmV0L2NvcmUvZmxv
d19kaXNzZWN0b3IuYw0KPj4gaW5kZXggMjVmYjBiYmMzMTBmLi5kOGMwZTgwNGJiZmUgMTAwNjQ0
DQo+PiAtLS0gYS9uZXQvY29yZS9mbG93X2Rpc3NlY3Rvci5jDQo+PiArKysgYi9uZXQvY29yZS9m
bG93X2Rpc3NlY3Rvci5jDQo+PiBAQCAtMTc0Nyw2ICsxNzQ3LDM1IEBAIHUzMiBfX3NrYl9nZXRf
aGFzaF9zeW1tZXRyaWMoY29uc3Qgc3RydWN0IHNrX2J1ZmYgKnNrYikNCj4+IH0NCj4+IEVYUE9S
VF9TWU1CT0xfR1BMKF9fc2tiX2dldF9oYXNoX3N5bW1ldHJpYyk7DQo+PiANCj4+ICsvKioNCj4+
ICsgKiBza2JfZ2V0X2hhc2hfc3ltbWV0cmljOiBjYWxjdWxhdGUgYW5kIHNldCBhIGZsb3cgaGFz
aCBpbiBAc2tiLCB1c2luZw0KPj4gKyAqIGZsb3dfa2V5c19kaXNzZWN0b3Jfc3ltbWV0cmljLg0K
Pj4gKyAqIEBza2I6IHNrX2J1ZmYgdG8gY2FsY3VsYXRlIGZsb3cgaGFzaCBmcm9tDQo+PiArICoN
Cj4+ICsgKiBUaGlzIGZ1bmN0aW9uIGlzIHNpbWlsYXIgdG8gX19za2JfZ2V0X2hhc2hfc3ltbWV0
cmljIGV4Y2VwdCB0aGF0IGl0DQo+PiArICogcmV0YWlucyB0aGUgaGFzaCB3aXRoaW4gdGhlIHNr
Yiwgc3VjaCB0aGF0IGl0IGNhbiBiZSByZXVzZWQgd2l0aG91dA0KPj4gKyAqIGJlaW5nIHJlY2Fs
Y3VsYXRlZCBsYXRlci4NCj4+ICsgKi8NCj4+ICt1MzIgc2tiX2dldF9oYXNoX3N5bW1ldHJpYyhz
dHJ1Y3Qgc2tfYnVmZiAqc2tiKQ0KPj4gK3sNCj4+ICsgICAgICAgc3RydWN0IGZsb3dfa2V5cyBr
ZXlzOw0KPj4gKyAgICAgICB1MzIgaGFzaDsNCj4+ICsNCj4+ICsgICAgICAgX19mbG93X2hhc2hf
c2VjcmV0X2luaXQoKTsNCj4+ICsNCj4+ICsgICAgICAgbWVtc2V0KCZrZXlzLCAwLCBzaXplb2Yo
a2V5cykpOw0KPj4gKyAgICAgICBfX3NrYl9mbG93X2Rpc3NlY3QoTlVMTCwgc2tiLCAmZmxvd19r
ZXlzX2Rpc3NlY3Rvcl9zeW1tZXRyaWMsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAm
a2V5cywgTlVMTCwgMCwgMCwgMCwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIEZMT1df
RElTU0VDVE9SX0ZfU1RPUF9BVF9GTE9XX0xBQkVMKTsNCj4+ICsNCj4+ICsgICAgICAgaGFzaCA9
IF9fZmxvd19oYXNoX2Zyb21fa2V5cygma2V5cywgJmhhc2hybmQpOw0KPj4gKw0KPj4gKyAgICAg
ICBfX3NrYl9zZXRfc3dfaGFzaChza2IsIGhhc2gsIGZsb3dfa2V5c19oYXZlX2w0KCZrZXlzKSk7
DQo+PiArDQo+PiArICAgICAgIHJldHVybiBoYXNoOw0KPj4gK30NCj4+ICtFWFBPUlRfU1lNQk9M
X0dQTChza2JfZ2V0X2hhc2hfc3ltbWV0cmljKTsNCj4+ICsNCj4gDQo+IFdoeSBjb3B5L3Bhc3Rp
bmcgX19za2JfZ2V0X2hhc2hfc3ltbWV0cmljKCkgPw0KPiANCj4gQ2FuIHlvdSByZXVzZSBpdCA/
DQoNCk5vdCBkaXJlY3RseSwgYmVjYXVzZSB0byB1c2UgX19za2Jfc2V0X3N3X2hhc2ggcmVxdWly
ZXMgc3RydWN0IGZsb3dfa2V5cw0Kd2hlbiB1c2luZyBmbG93X2tleXNfaGF2ZV9sNCgpLiBfX3Nr
Yl9nZXRfaGFzaF9zeW1tZXRyaWMoKSBkb2VzIG5vdCANCnRha2Ugb3IgcmV0dXJuIHRoYXQgc3Ry
dWN0LCBzbyB3ZeKAmWQgZWl0aGVyIGhhdmUgdG8gcmVmYWN0b3IgdGhhdCAoYW5kIGl0cyBjYWxs
ZXJzKQ0Kb3IgaW50cm9kdWNlIHlldCBhbm90aGVyIGZ1bmN0aW9uIGFuZCBjb25zb2xpZGF0ZSBk
b3duIHRvIHRoYXQg4oCcbmV3IG9uZeKAnS4NCg0KSSBwbGF5ZWQgYXJvdW5kIHdpdGggdGhhdCBl
eGFjdCB0aG91Z2h0IGJ5IHRha2luZyB0aGUgZnVuY3Rpb25hbCBndXRzIG91dCBvZg0KX19za2Jf
Z2V0X2hhc2hfc3ltbWV0cmljLCBtYWtpbmcgaXQgYSBuZXcgc3RhdGljIGZ1bmN0aW9uLCBwbHVt
YmluZyB0aGF0DQppbnRvIF9fc2tiX2dldF9oYXNoX3N5bW1ldHJpYyBhbmQgdGhpcyBuZXcgc2ti
X2dldF9oYXNoX3N5bW1ldHJpYywgYnV0DQp0aGUgTE9DIGNodXJuIHdhcyBiYXNpY2FsbHkgdGhl
IHNhbWUgYW5kIGl0IGZlbHQgYSBiaXQgd29yc2UgdGhhbiBqdXN0IGEgDQpjb3B5L3Bhc3RlLg0K
DQpBbHRlcm5hdGl2ZWx5LCBpZiBpdCB0dXJuZWQgb3V0IHRoYXQgZmxvd19rZXlzX2hhdmVfbDQo
KSB3YXNu4oCZdCBpbXBvcnRhbnQsIHdlDQpDb3VsZCBzaW1wbHkgc2V0IHRoYXQgdG8gZmFsc2Ug
YW5kIHRoZW4gcmV1c2UgX19za2JfZ2V0X2hhc2hfc3ltbWV0cmljDQppbiBhIHRyaXZpYWwgbWFu
bmVyLiBJIGNvdWxkbuKAmXQgcXVpdGUgZmlndXJlIG91dCBpZiBMNCBmbGFnIHdhcyBuZWNlc3Nh
cnksIHNvIEkNCndlbnQgdGhlIHNhZmUobWF5YmU/KSByb3V0ZSBhbmQgY29weS9wYXN0ZSBpbnN0
ZWFkLg0KDQpIYXBweSB0byB0YWtlIHN1Z2dlc3Rpb25zIGVpdGhlciB3YXkh