Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc1cefef-eeb9-67d5-ca73-64855a85b01b@linaro.org>
Date:   Wed, 31 May 2023 20:22:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 3/3] dt-bindings: phy: realtek: Add the doc about the
 Realtek SoC USB 2.0/3.0 PHY
Content-Language: en-US
To:     =?UTF-8?B?U3RhbmxleSBDaGFuZ1vmmIzogrLlvrdd?= 
        <stanley_chang@realtek.com>, Conor Dooley <conor@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Flavio Suligoi <f.suligoi@asem.it>,
        Mathias Nyman <mathias.nyman@linux.intel.com>,
        Douglas Anderson <dianders@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Ray Chi <raychi@google.com>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
References: <20230525022617.30537-1-stanley_chang@realtek.com>
 <20230525022617.30537-3-stanley_chang@realtek.com>
 <20230529-impurity-dismount-bca5c9100c9b@spud>
 <6f8fb4c9d5d14cfd8c4f1feafa229df7@realtek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <6f8fb4c9d5d14cfd8c4f1feafa229df7@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 30/05/2023 04:53, Stanley Chang[昌育德] wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - realtek,usb3phy
>>> +      - realtek,rtd-usb3phy
>>> +      - realtek,rtd1295-usb3phy
>>> +      - realtek,rtd1619-usb3phy
>>> +      - realtek,rtd1319-usb3phy
>>> +      - realtek,rtd1619b-usb3phy
>>> +      - realtek,rtd1319d-usb3phy
> 
>> Ignoring everything else, because I really want Krzysztof or Rob to
>> review this rather than me, but what's going on here with the
>> compatibles?
>> What hardware do "usbNphy" and "rtd-usbNphy" represent?
>>
>> You have device-specific compatibles, which is great, but you also allow
>> only those two generic ones. I had a _brief_ look at the driver, and it
>> seems like there is no decision making done based on the compatibles,
>> only on the properties. Is that correct?
>> If it is, I would understand having "realtek,usb3phy" as a fallback
>> compatible for "realtek,rtd1619-usb3phy", but I do not get the current
>> setup.
> 
> This driver is compatible with all Realtek RTD SoCs without specifying different settings.
> So use "realtek,usb3phy" as fallback compatible for all SoCs.

Binding says something entirely else...

Best regards,
Krzysztof