Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1335564rwd; Wed, 31 May 2023 12:24:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ExLtqduKQrHL2dtKwxcCo5e9CFTORWSakqJB6MjAl4MgEj4awPC8uoTHONbbFsRWFwyRf X-Received: by 2002:a05:6808:148b:b0:394:ba74:a522 with SMTP id e11-20020a056808148b00b00394ba74a522mr5387784oiw.57.1685561069494; Wed, 31 May 2023 12:24:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685561069; cv=none; d=google.com; s=arc-20160816; b=Al2Vytiyu08S6VQWZZB1dcDp/yZGj/uf24QQ/TtvuHCBGGzrPG60mC41/W8E9siFn4 798SwR1I2JwXssi4QoM3DZYBXCBuKcbbvbkHH7/mVZYy15YjtHXjqrpHj0VKuGpwc7Cc kJQXrzaP60NVs3njXAlenFO1gxJTkaZNfag/yhKS0eLOdGgUtpZ7QLvzKPKTb7yju4cU FdPnUcHfjcpekhmVLMBVmB5sJPtUGeT3W5FCSq5Lgtp5eTHyS5ipjEG6hsWcrzBhxb0j 6TsCnT+IY/usl5y48cuAs5afSdyaAFhZr0grxHQPWDxhi50z7M29oLo82Ccq1ZKM0VVs xBaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=KV+zKqTXjVWLo2o1uBDDcBww4MaWYfwVCV2qstDoq3M=; b=T8iNcIcmC+neaoofDYiUt6Nv/HgG2gPPTf2jGVov9NZPcSvl93wFRbGXDmhfk26U60 MsbMTv2VI9vvnmEn4CXMSA6jqvDqX6VLvTFmRMcieZ5lX7CiW1umZvi3X+3pQENhH9pu 84vCckl4r1Pf88oGMmWxRXTtRGoWm/RQ5rZex+m5ok3iVTxLz3ahRbTMpMyPQ9ZC6I0b 1y2cCXPEyEAdEq083BweidbNnncdxTZ2mv2XwP+iIgcEQb9LZ+lR+LXVmrG1gz8DH3XW 8Q11j8S8nPmWNFKtHR6ynaQGLg3p3+FbLWq2yhWBRym3+eRymIKXCaJ6zHTR84+WX5g2 drpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mqQj0TNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f25-20020a637559000000b0052cb473f95esi1495518pgn.214.2023.05.31.12.24.10; Wed, 31 May 2023 12:24:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mqQj0TNb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229795AbjEaTUY (ORCPT + 99 others); Wed, 31 May 2023 15:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229672AbjEaTUT (ORCPT ); Wed, 31 May 2023 15:20:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A96F7125; Wed, 31 May 2023 12:20:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 454D763EC0; Wed, 31 May 2023 19:20:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36E97C433A0; Wed, 31 May 2023 19:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685560817; bh=jTk0m0B7gEiFeTTGawi6b2rAEXlbeTrHQEZbeN1MMqc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqQj0TNbpB82QHQEayA6DVZWzEL3RPSNZVjtT6Cd6U6EDvY207Wa38AMiJpvxloiW 1jl5UkzMdOnNBQrzm/9FuL2/HQ6+uIZ8RFdm1UvhhSqJfQNneDk5P2DSGaakQ1pDiP XVVGecNkO4heaJBkjW4Re0PVvpqCi2kBjigsjIWQ= Date: Wed, 31 May 2023 20:20:13 +0100 From: Greg Kroah-Hartman To: Maxime Ripard Cc: "Rafael J. Wysocki" , Brendan Higgins , David Gow , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] drivers: base: Add tests showing devm handling inconsistencies Message-ID: <2023053137-leggings-grumbly-a33a@gregkh> References: <20230329-kunit-devm-inconsistencies-test-v1-0-c33127048375@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 17, 2023 at 06:12:26PM +0200, Maxime Ripard wrote: > Hi, > > On Wed, Mar 29, 2023 at 08:38:30PM +0100, Maxime Ripard wrote: > > Hi, > > > > This follows the discussion here: > > https://lore.kernel.org/linux-kselftest/20230324123157.bbwvfq4gsxnlnfwb@houat/ > > > > This shows a couple of inconsistencies with regard to how device-managed > > resources are cleaned up. Basically, devm resources will only be cleaned up > > if the device is attached to a bus and bound to a driver. Failing any of > > these cases, a call to device_unregister will not end up in the devm > > resources being released. > > > > We had to work around it in DRM to provide helpers to create a device for > > kunit tests, but the current discussion around creating similar, generic, > > helpers for kunit resumed interest in fixing this. > > > > This can be tested using the command: > > ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/base/test/ > > > > Let me know what you think, > > Maxime > > > > Signed-off-by: Maxime Ripard > > Is there any news on this? Can you resend, last I saw the kernel test robot had a problem, which causes any patch series like that to be ignored by me. thanks, greg k-h