Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1349444rwd; Wed, 31 May 2023 12:36:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6bhyyy67LGVzk9iR94MalZeDLIUA7KzFu/BjJQQIGWicEVGIxKDqLuRM1w4Xd4addSPlTp X-Received: by 2002:a05:6358:4408:b0:123:4e5e:d65 with SMTP id z8-20020a056358440800b001234e5e0d65mr3237771rwc.10.1685561803051; Wed, 31 May 2023 12:36:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685561803; cv=none; d=google.com; s=arc-20160816; b=lf+gGKuJNl2/Zdkfhjz9uAjAUQHxGCnzp6nFZn6gPfK1YVdvzMOAc79Ikf+nWm03OL ov13QFh6aRxKP3IsjAMeh9PWB6t08V0L1AJIlVJZkQRIy6WsXQiBlaXnb/MGTXX4Hz2C TZIkdKYqQ/5hM/bbRPOotaTtUv6+NRz0GlFQmHimRuKwPp4ucEISx3tB6tJgaufqNsJ7 hq3Wt2Rc1vTybkjTzeZhN0CG1vOgG1TIZK70nEOUvUcM2agEfKG6espZtArVqOyuczzL kMlxn7TTHJNiCOxFrw/4QgDY7gb4TnxzTRFb77QZ/UaKIgzyDQYBkCqySWIqtnhNZiwN wvIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=li1rLK9XujeX0q5u14Qp5sO7HKgYaV/K5LyQO1RXxac=; b=d3HOlXAgHBcKkoCh8Ti8BdFkdNSnyC24H8XZADQjC07Du3wJskSPvVjM/2pyl5FdSp lduGhWCljoshWViOlrcTwJ16O2T83ro3K+47iQMngFNtMUOKVAdHPLkN8BiqjYk2jNKR DXcQYCTvsnYPrGLPpiDR0zRNgNGA+476ICoTxmkSMKEktiAPpjkSYNJ7JW5I/oYXABEk hS34g77IVLvl9z8qRXsxK+xi45HOnlZTjN5Tn7pL4yOEUv5bX44h0YSrz5vhWWZ8mf8N xtNV56k9cVL0TicK6/Q5JkOppuQJR6FEPQdk8UjX7Na1yah0m8cAC//ooKFoWYf/YWvt YHRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fbPzdDPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d25-20020a637359000000b0052c7ad564e2si1535007pgn.707.2023.05.31.12.35.59; Wed, 31 May 2023 12:36:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=fbPzdDPX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbjEaTXt (ORCPT + 99 others); Wed, 31 May 2023 15:23:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229715AbjEaTXs (ORCPT ); Wed, 31 May 2023 15:23:48 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38E0107 for ; Wed, 31 May 2023 12:23:45 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-64d30ab1ef2so97202b3a.2 for ; Wed, 31 May 2023 12:23:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685561025; x=1688153025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=li1rLK9XujeX0q5u14Qp5sO7HKgYaV/K5LyQO1RXxac=; b=fbPzdDPXelC0pn8nvQrSsUn3ouI3Mw6fmXmeONg0gi5YJEK+03UFY8G6Zb5Ntfek7u oCTHtY3cgTjnDD8ceChY5p5ACghTa0z7m8el2XFecNk8ageNHdtZUEBijdcXaWKEuV52 qrfkGj6KkkQZ1fa87fyCFIqLCW9KCffsGVwfw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685561025; x=1688153025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=li1rLK9XujeX0q5u14Qp5sO7HKgYaV/K5LyQO1RXxac=; b=LrrySQ+gJXlgdUxp0IllVqfkHoR3SDlwmLmImOZLBtD3GgiPqGmGjitQAT1ZNHT9DG ECNa1iTuo+XMw17Dwf+hnfpCLzE3uFYC8BSFId2fsjLCK6ZTOp0qsybvN+32FdpZD1dU +tJsCho4eAdNjRYtAGp3m18P/XGXQwneHoQNs0Kl0FCngBqIqfjdTL28HqUW4ITXeK+F 0hS60qGSiZislXBLn4MQgMx/4Llz8xzLRToUe26UBI1zd2mkILbZXwrlYnSATuxQE9Bh J2l8LZQFXe2CP8oKWZ3MFFunefKv+ZNP7E2IIIrysL32mSCIdqk7iFj1EgMqqacgVlDG f/pg== X-Gm-Message-State: AC+VfDxmqEKG1oB/ZPAtKVUzSoJ7XLQAdKG6sSqNQ8UILGWNkQEUi0JB /0EAzg8eO9K7vZ3TJB0iNH78Sg== X-Received: by 2002:a05:6a00:21cf:b0:64d:7225:cfff with SMTP id t15-20020a056a0021cf00b0064d7225cfffmr6860176pfj.8.1685561025193; Wed, 31 May 2023 12:23:45 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j8-20020a62e908000000b0064f97ff4506sm3093355pfh.68.2023.05.31.12.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 May 2023 12:23:44 -0700 (PDT) Date: Wed, 31 May 2023 12:23:43 -0700 From: Kees Cook To: John Johansen Cc: "Gustavo A . R . Silva" , Paul Moore , James Morris , "Serge E. Hallyn" , apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] apparmor: aa_buffer: Convert 1-element array to flexible array Message-ID: <202305311223.5912EDF4@keescook> References: <20230511213441.never.401-kees@kernel.org> <7085879d-4d21-b90a-c08d-60450d1c7d38@canonical.com> <202305301555.102E1890@keescook> <1f35dbba-9344-75c5-e870-31bc3198dbe0@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f35dbba-9344-75c5-e870-31bc3198dbe0@canonical.com> X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 31, 2023 at 05:21:40AM -0700, John Johansen wrote: > On 5/30/23 15:55, Kees Cook wrote: > > On Thu, May 11, 2023 at 02:48:29PM -0700, John Johansen wrote: > > > On 5/11/23 14:34, Kees Cook wrote: > > > > In the ongoing effort to convert all fake flexible arrays to proper > > > > flexible arrays, replace aa_buffer's 1-element "buffer" member with a > > > > flexible array. > > > > > > > > Cc: John Johansen > > > > Cc: Gustavo A. R. Silva > > > > Cc: Paul Moore > > > > Cc: James Morris > > > > Cc: "Serge E. Hallyn" > > > > Cc: apparmor@lists.ubuntu.com > > > > Cc: linux-security-module@vger.kernel.org > > > > Signed-off-by: Kees Cook > > > > > > Acked-by: John Johansen > > > > > > I have pulled this into my tree. > > > > Just a quick ping: I haven't seen this show up in -next yet... > > > > oop, sorry looks like I didn't push, it should be fixed now Awesome; thanks! -- Kees Cook