Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22ac8a99-d243-c537-41c7-ff2c5e69d28f@gmail.com>
Date:   Wed, 31 May 2023 16:48:27 -0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH 3/3] rust: upgrade to Rust 1.68.2
Content-Language: en-US
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     ojeda@kernel.org, alex.gaynor@gmail.com, benno.lossin@proton.me,
        bjorn3_gh@protonmail.com, boqun.feng@gmail.com, gary@garyguo.net,
        gyakovlev@gentoo.org, jan.steffens@gmail.com, jistone@redhat.com,
        linux-kernel@vger.kernel.org, patches@lists.linux.dev,
        rust-for-linux@vger.kernel.org, wedsonaf@gmail.com,
        william.brown@suse.com
References: <20230418214347.324156-4-ojeda@kernel.org>
 <20230419030243.540348-1-yakoyoku@gmail.com>
 <CANiq72knVpyaKdT2iwrBNYorAt3Y5M-r6pXHc9JAZRCVmBYusQ@mail.gmail.com>
From:   Martin Rodriguez Reboredo <yakoyoku@gmail.com>
In-Reply-To: <CANiq72knVpyaKdT2iwrBNYorAt3Y5M-r6pXHc9JAZRCVmBYusQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 5/31/23 14:02, Miguel Ojeda wrote:
> On Wed, Apr 19, 2023 at 5:02 AM Martin Rodriguez Reboredo
> <yakoyoku@gmail.com> wrote:
>>
>> Kinda bunch to review, although may I ask if each time the `alloc`
>> crate is updated is worth to mention the changes upon it [1], can be
>> skipped otherwise.
>>
>> Link: https://github.com/rust-lang/rust/commits/master/library/alloc [1]
> 
> That could be nice if we could give a link similar to, say, what:
> 
>      git log 1.62.0..1.68.2 -- library/alloc/src/
> 
> produces (or perhaps a list of PRs) -- is it possible to do so with a
> GitHub URL? If so, please let me know!
> 
> Cheers,
> Miguel


It seems that kind of URL comparisons in GitHub aren't supported yet
per the docs say [1]. Sad but maybe in the future they are going to be
supported, or at least I hope GitLab or Gitea do it.

Link: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/viewing-and-comparing-commits/comparing-commits [1]