Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 14:49:46 -0700
From:   Saeed Mahameed <saeed@kernel.org>
To:     =?iso-8859-1?Q?C=E9dric?= Le Goater <clegoate@redhat.com>
Cc:     Niklas Schnelle <schnelle@linux.ibm.com>,
        Shay Drory <shayd@nvidia.com>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Eli Cohen <elic@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        Mark Brown <broonie@kernel.org>,
        Simon Horman <simon.horman@corigine.com>,
        linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v2] net/mlx5: Fix setting of irq->map.index for
 static IRQ case
Message-ID: <ZHfA+i4E3SykRT4O@x130>
References: <20230531084856.2091666-1-schnelle@linux.ibm.com>
 <cdd8953e-2187-32f7-bb3c-aaf54581775d@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cdd8953e-2187-32f7-bb3c-aaf54581775d@redhat.com>
Precedence: bulk

On 31 May 11:38, C?dric Le Goater wrote:
>On 5/31/23 10:48, Niklas Schnelle wrote:
>>When dynamic IRQ allocation is not supported all IRQs are allocated up
>>front in mlx5_irq_table_create() instead of dynamically as part of
>>mlx5_irq_alloc(). In the latter dynamic case irq->map.index is set
>>via the mapping returned by pci_msix_alloc_irq_at(). In the static case
>>and prior to commit 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
>>irq->map.index was set in mlx5_irq_alloc() twice once initially to 0 and
>>then to the requested index before storing in the xarray. After this
>>commit it is only set to 0 which breaks all other IRQ mappings.
>>
>>Fix this by setting irq->map.index to the requested index together with
>>irq->map.virq and improve the related comment to make it clearer which
>>cases it deals with.
>>
>>Tested-by: Mark Brown <broonie@kernel.org>
>>Reviewed-by: Mark Brown <broonie@kernel.org>
>>Reviewed-by: Simon Horman <simon.horman@corigine.com>
>>Reviewed-by: Eli Cohen <elic@nvidia.com>
>>Fixes: 1da438c0ae02 ("net/mlx5: Fix indexing of mlx5_irq")
>>Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
>

Applied to net-mlx5. 

Thanks.