Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 23:50:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc:     netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: pch_gbe: Allow build on MIPS_GENERIC kernel
Message-ID: <ZHfBIkdXeP5rc7Lf@corigine.com>
References: <20230530150301.9555-1-jiaxun.yang@flygoat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230530150301.9555-1-jiaxun.yang@flygoat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YcRlabFIcld4y3JNBX8OHWTzDKVtS5StRwX5xqcwk8ayFiEbUM5QlX7W0XBR?=
 =?us-ascii?Q?dLZdVv7hjaNQVWPVyNL2SU3ZYSRkp7o1Sg/MP/BVt38hkF7iLtaL1PaN0vt9?=
 =?us-ascii?Q?NZ4VbPuDLhJi4fNU6oNfc0zd7ATSGoLwMOoz3jaVazAtiZtCJjtIxyQeB1mn?=
 =?us-ascii?Q?w6B8J8UDBgxmv6ZIAU+Xf0JqH0EKWhE5nMr2dvh7Clb5dDrKOVSOEAzRK1K5?=
 =?us-ascii?Q?LFFOJvnoOzlskWPKJS9cRq/09bnlQP0SkDr41kgK+EWy6kvQiDmzzSQN+DQQ?=
 =?us-ascii?Q?EY2YNxHsscny4iHV6U6k9f+4uA1uKHmDelZbhDsBimswR2qqXRgfjbJDZOWL?=
 =?us-ascii?Q?okRtZjKiJdex3DDcCJv6WOpJl4sRDJ7jxnvrvhCvtQe7vcyrGuDCbXjBOHOB?=
 =?us-ascii?Q?RZ6abZ7ODa7JiqA6gAuv4w0mo3pXWIYaalcmpdYf4baat9bI0Ru7DV8YQn85?=
 =?us-ascii?Q?XNcHYw6ok/xH62O+xwahv3A9ifq5cNSDIu2lSBipK5unvd42YuIuoLJR8+5J?=
 =?us-ascii?Q?485wQZYTbsEOU4dJ9L2ESOuzyA82K15CRCnJIWxh+Ylf/9V6oAQqxAMTx8S6?=
 =?us-ascii?Q?h2Bwy1jUc+22X0AVxNJaVzWxbSRYCvK/yqRCmbgRqNX7oYBOni+3VEYx67LK?=
 =?us-ascii?Q?j08gVgo6y4iRHNSkLwVMY/XxKmFKupfcnfwCoQKnSH3RRqYWnuF1UnuzGIlJ?=
 =?us-ascii?Q?iWl20D+S1iT848iSrtxODg05hs+iwRbfKEC+cMPnQ7NfH9JSyOxCt8X2xw1s?=
 =?us-ascii?Q?fQF0161cWT8HQIizGv9IWwSHGpafedhJPPuPCTvyhDB9AGw7X+v0R0neivTi?=
 =?us-ascii?Q?E6f4CPEkyNMO5nWFZiOG/g4qvXhWs1j1eu8R40/O1JUHViTxKrsTBepkVW7B?=
 =?us-ascii?Q?beage/1MqzrVwb87O8ffonmteCOCPyLBats1l/4WISHfJyasY4fJ/vpTnEy9?=
 =?us-ascii?Q?EtLNEXVOMZeMK1k9rHliKQX0XSGMR7CxO2Hk+hO/y0rjkR5BWrh/d87tTPNr?=
 =?us-ascii?Q?psEox5W4asrO4QNH5FtYuWSx8KeJG1pRWgaKlU3gYv/V4E4EKy3kR8D0jDSt?=
 =?us-ascii?Q?Kkco0lBoZviAaZCMLQLQMI7v8dwN6pJp5MOqg4iSpXOzhCvv6+0eNKRrO9E7?=
 =?us-ascii?Q?uIslfy3TBu8Nct0zAnDVHTCDX+yWDHlNZfbZ9PTp53YCQs//VdoCK11HpTzg?=
 =?us-ascii?Q?bFotM6MZloqums/q4toFoaJnhvh8LCeRr17dmcbfxWxXhrFc2vXd21MtePhL?=
 =?us-ascii?Q?EeukK/vv+EPmaE7536Fyq9cMa76qYi2+yUtdBlSJc70ffj4lVnFqMOACLeft?=
 =?us-ascii?Q?H8mkNO6Xe0aBWSrNqFttzVXUU4YSmMXnf/c40/c2oQ6iq7gp6UbR6af6zdIm?=
 =?us-ascii?Q?SJEMpUNNl9m+z0QP5kfmpcnLc/XWxO+SHqoZP5tuc5yFG7QxwT29uxoUDVKi?=
 =?us-ascii?Q?UbJktwPIiZnivXsQAr3zBFcvGbHZSFaz29IgwZeZz9mROwE+k4zpqZziOd1K?=
 =?us-ascii?Q?KcNSRGoMq7WgYzHVyWfFOzzenwsNt1056IBKBRU0l1C8h+O0EKgopz82eOyV?=
 =?us-ascii?Q?AbJAvo4XUdVlEUWBv75VLHnsNXWA/LJIWAs030ppLNVQcVqFL36sBeXvQhcz?=
 =?us-ascii?Q?bA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86ac73be-1c9f-4ecd-89dd-08db62210f27
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 21:50:33.7420
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r+SLIYNInVIOliRpC+oBptUYsitcqLpCnv53skFndhPmPKXBtCMFBXi0j+y4dQd78mAoz/faz+xMABGUCT8JLozlPsP0i+2H3VuUX4YcM5k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5776
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[ Fixed Jakub's email address ]

On Tue, May 30, 2023 at 04:03:01PM +0100, Jiaxun Yang wrote:
> MIPS Boston board, which is using MIPS_GENERIC kernel is using
> EG20T PCH and thus need this driver.
> 
> Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
> board-boston.config for a while, some how it's never wired up
> in Kconfig.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> Netdev maintainers, is it possible to squeeze this tiny patch into
> fixes tree?

Hi Jianxun Yang,

with this patch applied on top of net [1] I see the following.
Am I doing something wrong?

ARCH=mips

$ make defconfig
CONFIG: mips-gcc-12.2.0
*** Default configuration is based on target '32r2el_defconfig'
Using ./arch/mips/configs/generic_defconfig as base
Merging arch/mips/configs/generic/32r2.config
Merging arch/mips/configs/generic/el.config
Merging ./arch/mips/configs/generic/board-boston.config
Merging ./arch/mips/configs/generic/board-marduk.config
Merging ./arch/mips/configs/generic/board-ni169445.config
Merging ./arch/mips/configs/generic/board-ocelot.config
Merging ./arch/mips/configs/generic/board-ranchu.config
Merging ./arch/mips/configs/generic/board-sead-3.config
Merging ./arch/mips/configs/generic/board-virt.config
Merging ./arch/mips/configs/generic/board-xilfpga.config

WARNING: unmet direct dependencies detected for PTP_1588_CLOCK_PCH
  Depends on [n]: (X86_32 || COMPILE_TEST [=n]) && HAS_IOMEM [=y] && PCI [=y] && NET [=y] && PTP_1588_CLOCK [=y]
  Selected by [y]:
  - PCH_GBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_OKI [=y] && PCI [=y] && (MIPS_GENERIC [=y] || X86_32 || COMPILE_TEST [=n]) && PTP_1588_CLOCK [=y]
#
# configuration written to .config
#

Other than the warning a kernel build with this config seemed to work fine

[1] 7ba0732c805f ("Merge branch 'selftests-mptcp-skip-tests-not-supported-by-old-kernels-part-1'")
    https://git.kernel.org/netdev/net/c/7ba0732c805f


Also, if the patch is targeted at 'net' then that should be noted in the
subject.

	Subject: [PATCH net] ...

And 'pch_gbe: ' is probably a slightly better prefix.

	Subject: [PATCH net] pch_gbe: ...

...