Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Jun 2023 00:07:39 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Bert Karwatzki <spasswolf@web.de>
Cc:     davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, elder@kernel.org, netdev@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE
Message-ID: <ZHfFK0+lgv2pSkFb@corigine.com>
References: <e144386d-e62a-a470-fcf9-0dab6f7ab837@linaro.org>
 <20230531103618.102608-1-spasswolf@web.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230531103618.102608-1-spasswolf@web.de>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g57HYgTO5Qd+e3TN54s8FOYZViWEbDhhVOVC0N2WDA4WmN03kGLGFyxko5ex?=
 =?us-ascii?Q?zh+w4WZiQGjvc/Wi+3rPIHgz4+CTl1pYC1VOL4UHY/S2WPYjeT9/IR2gtNM2?=
 =?us-ascii?Q?i+L4iFQZyUqCdJ4wp+3cw8I4qXK8znA1Em1yLLHP0lbzBGa4sIoC+vOT3uPw?=
 =?us-ascii?Q?8Ueki4sf5zYAf/4IoSqFIjCee7Q5rGGrWeTe22EXNJ7bt78ewnUMxuYc2PlH?=
 =?us-ascii?Q?uU32QX5hQQ1ZJyfzcnuB/eRaow/fjIZItwAOQLCUI0yChZhz8Sgd8lFnMXJa?=
 =?us-ascii?Q?ApXATtAAOzq6RLcyEJ1H+5fI6a9Vwpf5m7vhSv8dV0aMzX2cntOJbyPmj+Z7?=
 =?us-ascii?Q?FoWy9oA1xp7UlH46jcUCJ4MspuY3xIH6vZmbFcFHY4KAQfOPj6PxgtNavBzf?=
 =?us-ascii?Q?ywOT/CMU+O2JuISddS8Qq5Z57qGgnSun3VmZO7Zzzc3EsuxCflQMWudSm5tu?=
 =?us-ascii?Q?KuLM54ygsAAFs2kwsR5gCPeBPOdoDEzwpgk3EBRSUwOCZFpQPYIOelMX7iL5?=
 =?us-ascii?Q?qZCRBlmp81LA/qG0YLSVqc30t1oHagsxB2XBaorwP/V9DtKrQANnyBiZohIE?=
 =?us-ascii?Q?QC6kTB47rzKL7YvUiMLVm5yhlKBpmfljmS/MzH3awoFfffLte7k9yd5NWoS3?=
 =?us-ascii?Q?LypdYHvoAihCDt/CwQ+gyVoXGRerVkA0Zwsprn2stK4ddDKF6koPjv/Kl6D+?=
 =?us-ascii?Q?NHvTEWwcawyrkPClXIcCyheApiHUfXc17vMZ7eQwYca4hfPYM9Tfjr/0xfHM?=
 =?us-ascii?Q?Ou+NsAzdU75VapIlx9890Wg9gMxAfxGb9SsoQbiDLyZp4jFh+azfkQxMQDAr?=
 =?us-ascii?Q?9xJKyuqYyJintXsSOJC40JsnkoR1HJbkLeEO4Y1+BM9jJtpG2Vk3aaLlkBT7?=
 =?us-ascii?Q?OrNtmuvSvSjwWYHrH3nJzh/nTM6pV8vPOn7mPUg5hFPx28Q+wwB8cvirEbtz?=
 =?us-ascii?Q?du5HsSjN8pyzAfO0+Zkd75ahnMbyEnNypmCW10Coyz1gg3t00RHM8OWd3LaW?=
 =?us-ascii?Q?piIKZqQsrvENvnKekCfIlTdrPgRFvoMinwVvAlIJxTkc+coBh2QehTeFWzwE?=
 =?us-ascii?Q?QW08vckLcLdMxbNwP1nYTG6Cj00r2V4HJ8WOG+9sqo2FhC2iOQF3YkPBNQzE?=
 =?us-ascii?Q?kusY/rLGWo4E0U9DA7kWQKRyjCWd2p3VMWCSzyiy2rXjOxfe5jLmhpv+O2Xh?=
 =?us-ascii?Q?AzHoLulxUQuzQ/Te3uU1ns015EXYhn8em63Rc68GQ7GV1N2yhyeHAun5QQ6K?=
 =?us-ascii?Q?jjc8L0EJZNFvlg0zfcfk1dL8Txn2gKAhXObmkcN7R6CAO84bUfv6I2UX3Es+?=
 =?us-ascii?Q?UuW45rk7ZX1vHgQtHNH+yvItn/2WUC/3xE9eMN9sdiINzBGxMJ9NsTQnmFhN?=
 =?us-ascii?Q?Iwjvf2Ja1MVvnxYLnCsLSHfuGsQU0BPX2VDOlnwBaAOK5KOGI7q5Du0GSe71?=
 =?us-ascii?Q?NE3d+X1CPp3erMHZoR6UdtiJkt2HMmcpCGeQsur/OiwZbDwb7k4w/VpbvRwg?=
 =?us-ascii?Q?Nm2oPF3ad42tg9irOe+V32eIDiCW2vdl0KoxiWexPtIg1oOviwQnC3OcFRjR?=
 =?us-ascii?Q?0rGIcXWpm9nTwsSTOAgdNvJrbD+8sR6ST7HK/isSNGT7c4ELKq1+vkKZzvGN?=
 =?us-ascii?Q?0w=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca1e0f1f-698c-49f6-ba64-08db622376e8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 22:07:46.2643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JJ86k4bQlvPho0dAXB/WGqIDGHf0RNNRc5W7O/ANrF8MLSp+YbZbvLlUhWNTUj10hd/Cd7SHsylqeE6k0Pzd9N7iC59j4tRXDlCtHPNp2uo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR13MB4950
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 31, 2023 at 12:36:19PM +0200, Bert Karwatzki wrote:
> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
> for the size of the removed struct ipa_status which had size
> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
> 
> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
> ---
>  drivers/net/ipa/ipa_endpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
> index 2ee80ed140b7..afa1d56d9095 100644
> --- a/drivers/net/ipa/ipa_endpoint.c
> +++ b/drivers/net/ipa/ipa_endpoint.c
> @@ -119,7 +119,7 @@ enum ipa_status_field_id {
>  };
> 
>  /* Size in bytes of an IPA packet status structure */
> -#define IPA_STATUS_SIZE			sizeof(__le32[4])
> +#define IPA_STATUS_SIZE			sizeof(__le32[8])
> 
>  /* IPA status structure decoder; looks up field values for a structure */
>  static u32 ipa_status_extract(struct ipa *ipa, const void *data,
> --
> 2.40.1
> 
> As none of you seem to be in Europe, I'll do another attempt, this time
> with git send-email.

This looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

(somewhere in Europe)