Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230530155818.368562-1-azeemshaikh38@gmail.com> <yq1zg5kcgac.fsf@ca-mkp.ca.oracle.com>
In-Reply-To: <yq1zg5kcgac.fsf@ca-mkp.ca.oracle.com>
From:   Azeem Shaikh <azeemshaikh38@gmail.com>
Date:   Wed, 31 May 2023 18:40:24 -0400
Message-ID: <CADmuW3V=b3SOvijU0MPCBadpcRBtRYfT5eWVQOvL8WH-z-BqbA@mail.gmail.com>
Subject: Re: [PATCH] scsi: libfcoe: Replace all non-returning strlcpy with strscpy
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     Hannes Reinecke <hare@suse.de>, linux-hardening@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "James E.J. Bottomley" <jejb@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 31, 2023 at 6:03=E2=80=AFPM Martin K. Petersen
<martin.petersen@oracle.com> wrote:
>
>
> Azeem,
>
> > strlcpy() reads the entire source buffer first. This read may exceed
> > the destination size limit. This is both inefficient and can lead to
> > linear read overflows if a source string is not NUL-terminated [1]. In
> > an effort to remove strlcpy() completely [2], replace strlcpy() here
> > with strscpy(). No return values were used, so direct replacement is
> > safe.
>
> Applied to 6.5/scsi-staging!

Thanks Martin!

>
> PS. It would help if you could submit changes like these as a series in
> the future so I don't have to track each patch individually.
>

Sure, I can do that.