Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
To:     Marc Dionne <marc.dionne@auristor.com>
cc:     dhowells@redhat.com, linux-afs@lists.infradead.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] afs: Fix setting of mtime when creating a file/dir/symlink
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <808139.1685573412.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Wed, 31 May 2023 23:50:12 +0100
Message-ID: <808140.1685573412@warthog.procyon.org.uk>
Precedence: bulk

    =

kafs incorrectly passes a zero mtime (ie. 1st Jan 1970) to the server when
creating a file, dir or symlink because commit 52af7105eceb caused the
mtime recorded in the afs_operation struct to be passed to the server, but
didn't modify the afs_mkdir(), afs_create() and afs_symlink() functions to
set it first.

Those functions were written with the assumption that the mtime would be
obtained from the server - but that fell foul of malsynchronised clocks, s=
o
it was decided that the mtime should be set from the client instead.

Fix this by filling in op->mtime before calling the create op.

Fixes: 52af7105eceb ("afs: Set mtime from the client for yfs create operat=
ions")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
---
 fs/afs/dir.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/afs/dir.c b/fs/afs/dir.c
index 4dd97afa536c..5219182e52e1 100644
--- a/fs/afs/dir.c
+++ b/fs/afs/dir.c
@@ -1358,6 +1358,7 @@ static int afs_mkdir(struct mnt_idmap *idmap, struct=
 inode *dir,
 	op->dentry	=3D dentry;
 	op->create.mode	=3D S_IFDIR | mode;
 	op->create.reason =3D afs_edit_dir_for_mkdir;
+	op->mtime	=3D current_time(dir);
 	op->ops		=3D &afs_mkdir_operation;
 	return afs_do_sync_operation(op);
 }
@@ -1661,6 +1662,7 @@ static int afs_create(struct mnt_idmap *idmap, struc=
t inode *dir,
 	op->dentry	=3D dentry;
 	op->create.mode	=3D S_IFREG | mode;
 	op->create.reason =3D afs_edit_dir_for_create;
+	op->mtime	=3D current_time(dir);
 	op->ops		=3D &afs_create_operation;
 	return afs_do_sync_operation(op);
 =

@@ -1796,6 +1798,7 @@ static int afs_symlink(struct mnt_idmap *idmap, stru=
ct inode *dir,
 	op->ops			=3D &afs_symlink_operation;
 	op->create.reason	=3D afs_edit_dir_for_symlink;
 	op->create.symlink	=3D content;
+	op->mtime		=3D current_time(dir);
 	return afs_do_sync_operation(op);
 =

 error: