Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <98ffc5cd-7129-3128-1f83-d66b4fc8c78a@quicinc.com>
Date:   Wed, 31 May 2023 17:55:45 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.1
Subject: Re: [PATCH v4 1/2] remoteproc: Introduce traces for remoteproc events
Content-Language: en-US
To:     Trilok Soni <quic_tsoni@quicinc.com>,
        <linux-remoteproc@vger.kernel.org>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        "Satya Durga Srinivasu Prabhala" <quic_satyap@quicinc.com>,
        Rajendra Nayak <quic_rjendra@quicinc.com>,
        Elliot Berman <quic_eberman@quicinc.com>,
        "Guru Das Srinagesh" <quic_gurus@quicinc.com>,
        Sibi Sankar <quic_sibis@quicinc.com>,
        Melody Olvera <quic_molvera@quicinc.com>
References: <cover.1685486994.git.quic_gokukris@quicinc.com>
 <5c1744bc362fbc80615349f12c18c8ab5c4f0a6e.1685486994.git.quic_gokukris@quicinc.com>
 <b332eaf8-2528-ad71-9118-6627bf9ab7c1@quicinc.com>
From:   Gokul Krishna Krishnakumar <quic_gokukris@quicinc.com>
In-Reply-To: <b332eaf8-2528-ad71-9118-6627bf9ab7c1@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 5/31/2023 2:51 PM, Trilok Soni wrote:
> On 5/31/2023 2:28 PM, Gokul krishna Krishnakumar wrote:
>> Adding Traces for the following remoteproc events:
>>     rproc_subdev_event,
>>     rproc_interrupt_event,
>>     rproc_load_event,
>>     rproc_start_event,
>>     rproc_stop_event
>>
>> Signed-off-by: Gokul krishna Krishnakumar <quic_gokukris@quicinc.com>
>> ---
>>   drivers/remoteproc/Kconfig                    |   5 +
>>   drivers/remoteproc/Makefile                   |   1 +
>>   drivers/remoteproc/remoteproc_tracepoints.c   |  13 ++
>>   include/trace/events/remoteproc_tracepoints.h | 129 ++++++++++++++++++
>>   4 files changed, 148 insertions(+)
>>   create mode 100644 drivers/remoteproc/remoteproc_tracepoints.c
>>   create mode 100644 include/trace/events/remoteproc_tracepoints.h
>>
>> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
>> index a850e9f486dd..2ef4f527f1c1 100644
>> --- a/drivers/remoteproc/Kconfig
>> +++ b/drivers/remoteproc/Kconfig
>> @@ -365,6 +365,11 @@ config XLNX_R5_REMOTEPROC
>>         It's safe to say N if not interested in using RPU r5f cores.
>> +config REMOTEPROC_TRACEPOINTS
>> +    bool "Support for Remote Processor subsystem traces"
>> +    help
>> +      Say y to add traces to the remoteproc events.
> 
> More information here please. What information these traces provide? How 
> they can be useful to developers? More text will always be helpful.
> 
Say y to add traces to remoteproc events of interest such as the 
start/stop/crash events in a remote-processor and also sub-device 
stop/start events and there errors.
These traces can be useful while debugging errors with subsystem restart 
and draw an estimate on how long each event takes to run.

> ---Trilok Soni

How does this look.
Thanks,
Gokul