Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230531111518.396868-1-victorshihgli@gmail.com>
 <20230531111518.396868-4-victorshihgli@gmail.com> <55a83234-afa9-12de-d366-961b6909efaf@intel.com>
In-Reply-To: <55a83234-afa9-12de-d366-961b6909efaf@intel.com>
From:   Victor Shih <victorshihgli@gmail.com>
Date:   Thu, 1 Jun 2023 09:48:05 +0800
Message-ID: <CAK00qKAW_Daihb-G9FP+Ldw3hPOUqEMF6_2R76zUi-KUY5_kzw@mail.gmail.com>
Subject: Re: [PATCH V4 3/4] mmc: sdhci: Add VDD2 definition for power control register
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org, benchuanggli@gmail.com,
        HL.Liu@genesyslogic.com.tw, Greg.tu@genesyslogic.com.tw,
        Ben Chuang <ben.chuang@genesyslogic.com.tw>,
        Victor Shih <victor.shih@genesyslogic.com.tw>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Adrian

On Wed, May 31, 2023 at 9:27=E2=80=AFPM Adrian Hunter <adrian.hunter@intel.=
com> wrote:
>
> On 31/05/23 14:15, Victor Shih wrote:
> > From: Victor Shih <victor.shih@genesyslogic.com.tw>
> >
> > Add new definition for VDD2 - UHS2 or PCIe/NVMe.
> >
> > Signed-off-by: Ben Chuang <ben.chuang@genesyslogic.com.tw>
> > Signed-off-by: Victor Shih <victor.shih@genesyslogic.com.tw>
> > ---
> >  drivers/mmc/host/sdhci.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> > index f4f2085c274c..140a0c20d4f2 100644
> > --- a/drivers/mmc/host/sdhci.h
> > +++ b/drivers/mmc/host/sdhci.h
> > @@ -100,6 +100,14 @@
> >  #define  SDHCI_POWER_300     0x0C
> >  #define  SDHCI_POWER_330     0x0E
> >
> > +/*
> > + * VDD2 - UHS2 or PCIe/NVMe
> > + * VDD2 power on/off and voltage select
> > + */
> > +#define SDHCI_VDD2_POWER_ON  0x10
> > +#define SDHCI_VDD2_POWER_120 0x80
> > +#define SDHCI_VDD2_POWER_180 0xA0
>
> They should really align with SDHCI_POWER_330 etc
> above as they are all from SDHCI_POWER_CONTROL
>

I will update it in patch v5.

> > +
> >  #define SDHCI_BLOCK_GAP_CONTROL      0x2A
> >
> >  #define SDHCI_WAKE_UP_CONTROL        0x2B
>

Thanks, Victor Shih