Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Jonathan Corbet <corbet@lwn.net>, Will Deacon <will@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Besar Wicaksono <bwicaksono@nvidia.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Robin Murphy <robin.murphy@arm.com>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ilkka Koskinen <ilkka@os.amperecomputing.com>
Subject: [PATCH v2 3/5] perf: arm_cspmu: Support implementation specific filters
Date:   Wed, 31 May 2023 20:01:42 -0700
Message-Id: <20230601030144.3458136-4-ilkka@os.amperecomputing.com>
In-Reply-To: <20230601030144.3458136-1-ilkka@os.amperecomputing.com>
References: <20230601030144.3458136-1-ilkka@os.amperecomputing.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P7VCHjPxzt4Elu162CnqtNFFOPtelN4k+O7GkIUp2ZGtfXAEDzE0YqwEE1nX?=
 =?us-ascii?Q?R3UKBhKdJA/1U1kg/3MMblsY5LT6l3XmOM9XV53vdImS8t+TNdybTJGUQBH3?=
 =?us-ascii?Q?XhKKO97MmwlSuixGb2fp26InskgC7/o/ToiGotOuYyAevSXh9G6hHjxLQ/e8?=
 =?us-ascii?Q?K+X88fhKQ7MvKPX/Gcz9/9E+mUvbTCKDPxZWHwP6pN7vn2i2XauQ/XiNG2TI?=
 =?us-ascii?Q?DpuVC0/BvzvbV4JyYl2OvJy/uR9scuM8o6hznn6rpZJp7ndnKwzU3CvP012T?=
 =?us-ascii?Q?VR5xRnMkgGhCE4jPzTJtbk1cfJvDSFX8WwNwLrDXFU92Hu9v7Bfw3ZxTRJE0?=
 =?us-ascii?Q?Rn13bg7yzSmcMcarKfY8Fw7eVhFoZYnZdjvEIHOPZosvBivVHWIGkwQJX6Dn?=
 =?us-ascii?Q?LOz4Ys1GUR4fE8DLnvTEaqTCZubEdM2niyRgrDYC/RC2DwUYYvB1xp7ec5bv?=
 =?us-ascii?Q?3XbsBzFSM5G4Vtb89P+9pkzDCfpyz/xl1tMY7FX+RcgMssTxpxHpzPiEnRrq?=
 =?us-ascii?Q?BBhrPA/23MElF9BbdfLvtTZcnM03T51G42sc+M61Equ7rgU+9AdDiryrDiiV?=
 =?us-ascii?Q?27N4Oquw8Vv2fO8hAuus/+1dTIrrK3U1HPtdwMFLqQkCmAL7SGtBUUf/aGNS?=
 =?us-ascii?Q?O0b893/JQ/pCD+B7Az8fPDhdB7J1R0DXBQDwY5bb6R6HQeffkW3GjMwk3865?=
 =?us-ascii?Q?BFG07bFtwWe5noSOBQy6Tj4LDDWjBEbXvzcyIh7VY7k95pSu3dHDbhAYh7gv?=
 =?us-ascii?Q?p6Otge+1akAbzn+e/t7+vwOfsoP6c9lSjZuBGVOTYD64mZLCVZUHZ1ES3reO?=
 =?us-ascii?Q?xAj1t+zucmX73pke8ssn/rWWPmuenyzbW6rDhVaDtfCRR0YXaG6br0mT9W+E?=
 =?us-ascii?Q?ql+ZkzY/lQdY5u6Xh/k0QCKCRaVSB7x9UJtZehw2oZJuLuZ6bNUuFKOiEWcd?=
 =?us-ascii?Q?3HRvGR4DTly0xoLUJdgxBGxGTa8121eX2J+lS0QEh550tZwluWRA674N0UMy?=
 =?us-ascii?Q?aOkxv0YdOsGnShuirIsKJ4bphdCbZGNCjAPKnzUO12HAM4oD+uJiRnrE61Sb?=
 =?us-ascii?Q?GUeemC56VqC/AbwJ3i7DtqekP9qXMkDpVnn2gGmSM9U7y+aDucx03Jq8kQiB?=
 =?us-ascii?Q?IGFGuy9+Xu4PUKpqGTRAnxzoJ46/WnvJswNZpoJW6WWLXn7rl315CiHF1iU3?=
 =?us-ascii?Q?Mn/FFBHM8dnv4iAmq9vWKOzRfaBnyMLecaTrKJWcEHCnbVi1HQ5y44ccfUja?=
 =?us-ascii?Q?B8fc1EcHMekjS5XliF+eE5SRr5gq0ozAw25ZNFNvphyascdnpWMXbjQTkvt4?=
 =?us-ascii?Q?MdaJPluTDIUcFQRJ/3EUMNKd7CBCLRTk0sxueOIRYfPKoUyNH5fw+IB5ud+g?=
 =?us-ascii?Q?2y6mc3AfvOTZIB70NxOFnp0SUkjLOZ3V/I6H95p3gBN8TcDmcY6L86xm++EP?=
 =?us-ascii?Q?pv/BNsqZQ4lDKY57JXAH3jIp3hPI6W1fzfF5no3N4E9aZ418aX4QEyRJp1QS?=
 =?us-ascii?Q?JdK1ezsxTLs11hEsuu7vfJI1jUSdcPnrsuZIpsfkUszxkfyVJLrBc1j1MNkn?=
 =?us-ascii?Q?iZCzvxIhPAJTYjL26z/t6EdSL1auBf2hgH6T3I4KmHP4a1VUZaV/DCglX69m?=
 =?us-ascii?Q?9Xr6QJbRDM+Sl3n3ktQIqk0=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a2fa18a8-e9ed-41b3-7fbe-08db624caa12
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 03:02:41.5518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nlVoaBElR7l6F7zcveT56qYb3xhhKPgLsrBX5tRVh/W36k9iFHRy0/lRKhIKuJi9JDDVBnYxzdUAeF2LEJ4KK+IcJ08usbupKg5Rsp8RwOjyQV7c4F1X4MFQg3rqMQ7d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6709
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Generic filters aren't used in all the platforms. Instead, the platforms
may use different means to filter events. Add support for implementation
specific filters.

Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
---
 drivers/perf/arm_cspmu/arm_cspmu.c | 8 ++++++--
 drivers/perf/arm_cspmu/arm_cspmu.h | 4 ++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
index cc5204d1b5fb..b4c4ef81c719 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.c
+++ b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -122,6 +122,9 @@
 
 static unsigned long arm_cspmu_cpuhp_state;
 
+static void arm_cspmu_set_ev_filter(struct arm_cspmu *cspmu,
+				    struct hw_perf_event *hwc, u32 filter);
+
 /*
  * In CoreSight PMU architecture, all of the MMIO registers are 32-bit except
  * counter register. The counter register can be implemented as 32-bit or 64-bit
@@ -432,6 +435,7 @@ static int arm_cspmu_init_impl_ops(struct arm_cspmu *cspmu)
 	CHECK_DEFAULT_IMPL_OPS(impl_ops, event_type);
 	CHECK_DEFAULT_IMPL_OPS(impl_ops, event_filter);
 	CHECK_DEFAULT_IMPL_OPS(impl_ops, event_attr_is_visible);
+	CHECK_DEFAULT_IMPL_OPS(impl_ops, set_ev_filter);
 
 	return 0;
 }
@@ -799,7 +803,7 @@ static inline void arm_cspmu_set_event(struct arm_cspmu *cspmu,
 	writel(hwc->config, cspmu->base0 + offset);
 }
 
-static inline void arm_cspmu_set_ev_filter(struct arm_cspmu *cspmu,
+static void arm_cspmu_set_ev_filter(struct arm_cspmu *cspmu,
 					   struct hw_perf_event *hwc,
 					   u32 filter)
 {
@@ -833,7 +837,7 @@ static void arm_cspmu_start(struct perf_event *event, int pmu_flags)
 		arm_cspmu_set_cc_filter(cspmu, filter);
 	} else {
 		arm_cspmu_set_event(cspmu, hwc);
-		arm_cspmu_set_ev_filter(cspmu, hwc, filter);
+		cspmu->impl.ops.set_ev_filter(cspmu, hwc, filter);
 	}
 
 	hwc->state = 0;
diff --git a/drivers/perf/arm_cspmu/arm_cspmu.h b/drivers/perf/arm_cspmu/arm_cspmu.h
index c0412cf2bd97..4a29b921f7e8 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.h
+++ b/drivers/perf/arm_cspmu/arm_cspmu.h
@@ -102,6 +102,10 @@ struct arm_cspmu_impl_ops {
 	u32 (*event_type)(const struct perf_event *event);
 	/* Decode filter value from configs */
 	u32 (*event_filter)(const struct perf_event *event);
+	/* Set event filter */
+	void (*set_ev_filter)(struct arm_cspmu *cspmu,
+			      struct hw_perf_event *hwc,
+			      u32 filter);
 	/* Hide/show unsupported events */
 	umode_t (*event_attr_is_visible)(struct kobject *kobj,
 					 struct attribute *attr, int unused);
-- 
2.40.1