Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp123404rwd; Wed, 31 May 2023 20:15:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7NiZB2dEaL9eWxFjzIfI4qI8fWcJdtGPezBQ0uG8wBlbMuSYA6y5SbCl/Y587uTEjkE5ZW X-Received: by 2002:a05:6358:948f:b0:125:76f7:3eaf with SMTP id i15-20020a056358948f00b0012576f73eafmr2513196rwb.12.1685589315194; Wed, 31 May 2023 20:15:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685589315; cv=none; d=google.com; s=arc-20160816; b=ZIAR6S2E9eaPfgl4cXxY+hzpI1I22p6McKp6Oux56O1c2aZBveStM/3e35VKDuvqiY ZdH33LOpl6AxUwNmgvY/sG6BxKkfaKrUK/GZAhpAIutFx8twxXegVxd30W8juAlqdFfu OkZWAq7P6b7GOrPnbpegojKsl9fH7NObzNOGj+eJaFHc0lg7z8UMiZVtlNU0zZHjT3N6 7KsTSCOP67SLyQM/2GIYGavaD4kVgLr5VIevPUTbk4Ns9tp81TVZ6na5ugUA8F3WEHQc uQJ/sT3pwBIlQ0iSv+CYPdz/4rwn6MmtB6dPjNzDl+vX2DT2491rlKOfGfn2NWKkBGfp m4kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=j+kvxiUD89YnB62DXBY8di4kOffItK33fytfxIVrFE8=; b=v/D8Vhf8hsXzF4e4mo2ztZvVmIv2ywWJCCSjR8jBcC2Nc3144o+I5OWyOK2QEUwlHJ zNzQ1a6SMI2K9+ATRFzmzNuX1zqGGFdiGoEZTTmUq82n8BMLGWwOFr3O/0dqMZGYp6aa nCK+xoHTJoBsk1pi0u+obR4A2+fe4PLIkLikQVATJwTQz//eO6Z55Kg2WZ9ohsRKTLjc Syc5FCeHIOkfRnPNXvh2UZJsX3r99Fv1FGZcbeoZBdkXF+jpFisk9lXydE79yKUL9ivr uMwHmE1snMWSG5MQWfebmzOzXd6nXow1RVl5suesyNjsJ6sAx/9v07t8NpjbHJaEfM0l g1fA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d16-20020a17090abf9000b0024e29660f61si376302pjs.90.2023.05.31.20.14.39; Wed, 31 May 2023 20:15:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231283AbjFADCJ (ORCPT + 99 others); Wed, 31 May 2023 23:02:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229946AbjFADCF (ORCPT ); Wed, 31 May 2023 23:02:05 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A30124 for ; Wed, 31 May 2023 20:02:00 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vk-f9VS_1685588516; Received: from 30.97.48.255(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vk-f9VS_1685588516) by smtp.aliyun-inc.com; Thu, 01 Jun 2023 11:01:57 +0800 Message-ID: <02887eb0-e7e5-34b3-dbb4-a689b9dc233d@linux.alibaba.com> Date: Thu, 1 Jun 2023 11:01:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 1/6] erofs: convert erofs_read_metabuf() to erofs_bread() for xattr To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230601024347.108469-1-jefflexu@linux.alibaba.com> <20230601024347.108469-2-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230601024347.108469-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/6/1 10:43, Jingbo Xu wrote: > buf->inode is constant once initialized during erofs_buf's lifetime. > Thus call erofs_init_metabuf() and erofs_bread() separately to avoid > the repetition of assigning buf->inode when iterating xattrs. > > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang