Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 May 2023 20:12:16 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
CC:     Davidlohr Bueso <dave@stgolabs.net>, LiuLele <liu.lele@qq.com>,
        <dave.jiang@intel.com>, <Jonathan.Cameron@huawei.com>,
        <alison.schofield@intel.com>, <bhelgaas@google.com>,
        <bwidawsk@kernel.org>, <dan.j.williams@intel.com>,
        <helgaas@kernel.org>, <linux-acpi@vger.kernel.org>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-pci@vger.kernel.org>, <rostedt@goodmis.org>,
        <vishal.l.verma@intel.com>
Subject: Re: CXL memory device not created correctly
Message-ID: <64780c904d3c_c35b294ce@iweiny-mobl.notmuch>
References: <cec6a8f5-a284-4f46-1ada-4edd625a9a2e@intel.com>
 <tencent_D9D9D358330CA573E23D490C6EE13E0DC105@qq.com>
 <gbsxrcjtnf67jxpqmbn57nqoslpmjtuk2ycatmau3vfsmpvbrd@c2umpofn2hti>
 <646793cc665bf_1231462943c@iweiny-mobl.notmuch>
 <ZHaubgQOFU0+r1MD@bombadil.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZHaubgQOFU0+r1MD@bombadil.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LkaABwlL0Zy17qfhrZL0LUVA2gUG9ImVWCmQvoBvn6FbNABd7GlD7MtLPU/w?=
 =?us-ascii?Q?m5pZw8tO4X477EzEEEV9w8HKA9bqTpny/29yOWFTeskwYYOwBlH7ULzvJKj1?=
 =?us-ascii?Q?mgnTADctLSQPXOTeQG7zqLW0qNranyPWrdBqmPAyTmYWveqRJHLxl5jTvXFu?=
 =?us-ascii?Q?RF68Yh3HGS39R07URaasGGHsRPaBShzuRmXYSfs9VkW1mFgU6LkIWKXOjvjM?=
 =?us-ascii?Q?Orcztor+FRDgkKi7S9WR59Kzg2iYITKt5taVlUWxDqEYOkjGmhCU84s5obWD?=
 =?us-ascii?Q?y6HUD+D+arkZ92dM5DJfnchyUAcSHeWigWfKk1oqGgmocoYanA+yumJR579o?=
 =?us-ascii?Q?xpjYkTue8o4jRxcxtGV6YP77oF2n8VDyIMhjpxYTyVy7sv3uejSAvvHSHP/l?=
 =?us-ascii?Q?ymfXVYLyUE9qpr0Pspe0Mkuliddp4aYMmcbP1d7H9RpJ11qQ3QMzQNE8N5iC?=
 =?us-ascii?Q?UR0rlmOJ4acLAXNz57QgmkS+0dD9xFTXge9K8AvmtVgbYW3XtZARuaOSt9HX?=
 =?us-ascii?Q?hij5freLhg0jocUxlm4Dv8RAFaytophI5jiUIfL0Gni51yY6I1+gu18hPPXv?=
 =?us-ascii?Q?1sCJB32L1m4FIMjIYwMIapOjXwa6GHJ5eCyGbOdgXMjm6E1KZCzov80pVR8d?=
 =?us-ascii?Q?Bwrp8iOjuoD/8vHstBebMlGLAGNgDpuHhoJoHsk1fPK8PXeJiIzlUnUWxUMv?=
 =?us-ascii?Q?QTachR0bDktvMscrfrmrZFQ6vjlvLVt1Ub4eFBZUDNvKasIiYOKU2CSxdBy4?=
 =?us-ascii?Q?OQiwkkZOFrm6xn15qaLj5dshHqs9z6PyxYnX/rK6KxztTO+uAR43nr0pQFUG?=
 =?us-ascii?Q?aOyapsv3vi9l/QWdCyKhmq3D/6dTk0OSzs7cw/zFw5j4Wv5jdbRj9izfz6Dd?=
 =?us-ascii?Q?Qg2jSRWHstFValkjTaKzlsHWv4KTv9cgN/oM1L1kukzhs7eVxorLBlspAKw8?=
 =?us-ascii?Q?K/ItCU93DxURpLb05rRPK+W2oi8c/qaF3X4zWN5NF8GXdKUNiqM98ZsmbWKx?=
 =?us-ascii?Q?+O0+HA23bgewtrjxLVOwS1IjdiGVeIY00Vu54x2qSYR++MYZ4oWQrr64n55P?=
 =?us-ascii?Q?hGgY4w2jJX9VX7hTPAZFuxbikuCrVyYnl88vHeXoH0qGVYY7THBJPUJO5kLu?=
 =?us-ascii?Q?zypblXWq28kAvmF8MS8/t+vb1Og0wxwlogHop34SDe6s+mcK4wUoRZscTDCY?=
 =?us-ascii?Q?UsJjKjhDIUpIjDRQc/BMRN/NpOcG/jpS1pSdQ9nfvhk94K/42qKTWc+hdYHC?=
 =?us-ascii?Q?s144OmeBQ6jD++e2oL+Bt2Qvt5UEIwkk4gedfM57LDIhTGeG+PXtPmgDGqbu?=
 =?us-ascii?Q?00ab3sdtbEOLRC61E0Znqszrv0/NN5WrcIXTmP1xRZcnACYJAcmwHehOrzLo?=
 =?us-ascii?Q?PukFlX3pyiuq9GbjDenSkygzT85dPsL35lsuuMA0oBF1hg0SFIAfr3pJFzt6?=
 =?us-ascii?Q?w7ZcYWr38srQvYREGBfl8M5+iuJDDo5dEMEaKyYF80NoUaGksZeVek86Q3mH?=
 =?us-ascii?Q?clzR7bBSipEimDEBTh9o+CXprsJnpXvNKFexR+ATi+K7VHe4QBlb35kMGaW7?=
 =?us-ascii?Q?qsos5DICG/RPhz2lYnWCOibJCfM3FYwR4RqgIshQ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1733f04-ba63-46e4-b813-08db624e0418
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB6739.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2023 03:12:22.1796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IMlTI2MXYl6tcBJ/SO6+DfUMBmWApef4d0qRt2vxA4wb0fv8TORgpv+cSc/k4eB0zUJKYxL15Fxr9IkmAhr+kQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4542
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Luis Chamberlain wrote:
> On Fri, May 19, 2023 at 08:20:44AM -0700, Ira Weiny wrote:
> > Davidlohr Bueso wrote:
> > > On Fri, 19 May 2023, LiuLele wrote:
> > > 
> > > >In my testing CXL device /sys/bus/cxl/devices/mem0  not created, and the get error messages :
> > > >
> > > >```
> > > >cxl_pci 0000:0d:00.0: Failed to get interrupt for event Info log
> > > >```
> > > >
> > > >My test environment is a qemu CXL emulator with qemu v8.0.0, Linux kernel v6.3.0.
> > > >While with kernel 5.9.13,  /sys/bus/cxl/devices/mem0  can be created.
> > > 
> > > Yes, this can be annoying and would argue the probe should not error out.
> > 
> > I had to double check.  Events are mandatory on devices.  On checking
> > again interrupt support is mandatory as well.  So that is why I errored
> > out here.
> 
> The failure essentially creates a user visible regression whereas
> booting an older kernel fixes it. It is not a friendly error message
> when testing kernels / upgrading / test environments. The only thing
> I can think of is if a new kconfig symbol is introduced so to make
> such cases a bit more clearer for now as things get settled.

Ah I see now.  This is a qemu without the event support.  :-/

> 
> Otherwise for testing this creates a few cycles of just noise. And I'd
> imagine even a few developer hours.

I don't think the kernel should be changed for following the spec.  But I
do sympathize with you.  I know Jonathan is working to get the event
support into qemu soon.  I've reviewed that series (the patches I did not
author) so I think it will land soon.

Can this be weathered until then?

Ira