Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230511141211.2418-1-jszhang@kernel.org> <20230511141211.2418-4-jszhang@kernel.org>
In-Reply-To: <20230511141211.2418-4-jszhang@kernel.org>
From:   Guo Ren <guoren@kernel.org>
Date:   Thu, 1 Jun 2023 12:58:45 +0800
Message-ID: <CAJF2gTSCLLviJ_JzjetU3ajRQtU+L7epeWOOVOeN_pqrfhKLHg@mail.gmail.com>
Subject: Re: [PATCH 3/4] vmlinux.lds.h: use correct .init.data.* section name
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Arnd Bergmann <arnd@arndb.de>, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, May 11, 2023 at 10:27=E2=80=AFPM Jisheng Zhang <jszhang@kernel.org>=
 wrote:
>
> If building with -fdata-sections on riscv, LD_ORPHAN_WARN will warn
> similar as below:
>
> riscv64-linux-gnu-ld: warning: orphan section `.init.data.efi_loglevel'
> from `./drivers/firmware/efi/libstub/printk.stub.o' being placed in
> section `.init.data.efi_loglevel'
>
> I believe this is caused by a a typo:
> init.data.* should be .init.data.*
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Seems it's a fixup for all architectures, what's the Fix: tag?

> ---
>  include/asm-generic/vmlinux.lds.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmli=
nux.lds.h
> index d1f57e4868ed..371026ca7221 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -688,7 +688,7 @@
>  /* init and exit section handling */
>  #define INIT_DATA                                                      \
>         KEEP(*(SORT(___kentry+*)))                                      \
> -       *(.init.data init.data.*)                                       \
> +       *(.init.data .init.data.*)                                      \
>         MEM_DISCARD(init.data*)                                         \
>         KERNEL_CTORS()                                                  \
>         MCOUNT_REC()                                                    \
> --
> 2.40.1
>


--=20
Best Regards
 Guo Ren